Add splat formatting regression tests - #7032
Merged
Merged
Conversation
Manishearth
approved these changes
Aug 17, 2026
ytmimi
approved these changes
Aug 17, 2026
Member
Author
|
Note: these tests also act as regression tests for #6590 . |
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unstable Rust compiler feature tracking issue: rust-lang/rust#153629
I created these tests to track down a code formatting bug where the
#[rustc_splat]attribute is deleted in function pointer types.These tests pass on recent nightly versions of rustfmt, but fail on recent beta (2026-08-14) and stable versions. I've asked how to fix this in Zulip.
Update: this bug was fixed in #6590 which is pending a rust-lang/rust subtree sync. When the sync happens, nightly rustfmt releases will be fixed.
The syntax of this feature is still unstable, so the goal of these tests is to check attribute formatting.