Skip to content

Add splat formatting regression tests - #7032

Merged
ytmimi merged 1 commit into
rust-lang:mainfrom
teor2345:splat-attr-tests
Aug 17, 2026
Merged

Add splat formatting regression tests#7032
ytmimi merged 1 commit into
rust-lang:mainfrom
teor2345:splat-attr-tests

Conversation

@teor2345

@teor2345 teor2345 commented Aug 17, 2026

Copy link
Copy Markdown
Member

Unstable Rust compiler feature tracking issue: rust-lang/rust#153629

I created these tests to track down a code formatting bug where the #[rustc_splat] attribute is deleted in function pointer types.

These tests pass on recent nightly versions of rustfmt, but fail on recent beta (2026-08-14) and stable versions. I've asked how to fix this in Zulip.

Update: this bug was fixed in #6590 which is pending a rust-lang/rust subtree sync. When the sync happens, nightly rustfmt releases will be fixed.

The syntax of this feature is still unstable, so the goal of these tests is to check attribute formatting.

@rustbot rustbot added the S-waiting-on-review Status: awaiting review from the assignee but also interested parties. label Aug 17, 2026
@teor2345 teor2345 changed the title Add splat formatting tests Add splat formatting regression tests Aug 17, 2026
@ytmimi
ytmimi added this pull request to the merge queue Aug 17, 2026
Merged via the queue into rust-lang:main with commit 8f8b296 Aug 17, 2026
27 checks passed
@rustbot rustbot added the release-notes Needs an associated changelog entry label Aug 17, 2026
@teor2345

Copy link
Copy Markdown
Member Author

Note: these tests also act as regression tests for #6590 .
The attribute-deleting bug will be fixed in rustfmt releases the next time we do a subtree sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes Needs an associated changelog entry S-waiting-on-review Status: awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants