Update clippy by Manishearth · Pull Request #54784 · rust-lang/rust

Manishearth · 2018-10-03T12:22:40Z

No description provided.

oli-obk · 2018-10-03T12:47:18Z

@bors r+ p=1

bors · 2018-10-03T12:47:20Z

📌 Commit bf1e325b30c5d9701ac76881915da37dde47364b has been approved by oli-obk

bors · 2018-10-03T13:15:29Z

⌛ Testing commit bf1e325b30c5d9701ac76881915da37dde47364b with merge 18f146d0789237dc6cf14ec480f7c44ea16df564...

bors · 2018-10-03T14:26:12Z

💔 Test failed - status-travis

rust-highfive · 2018-10-03T14:26:14Z

The job dist-x86_64-apple-alt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:24]       Memory: 8 GB
[00:03:24]       Boot ROM Version: VMW71.00V.0.B64.1704110547
[00:03:24]       Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:03:24]       SMC Version (system): 2.8f0
[00:03:24]       Serial Number (system): VM9EoW7iZl+4
[00:03:24] 
[00:03:24] hw.ncpu: 4
[00:03:24] hw.byteorder: 1234
[00:03:24] hw.memsize: 8589934592
---
[01:02:29] [RUSTC-TIMING] clippy_lints test:false 82.838
[01:02:52] [RUSTC-TIMING] cargo_clippy test:false 1.193
[01:02:57] [RUSTC-TIMING] clippy_driver test:false 6.262
[01:02:57]     Finished release [optimized] target(s) in 2m 57s
[01:02:57] duplicate artfacts found when compiling a tool, this typically means that something was recompiled because a transitive dependency has different features activated than in a previous build:
[01:02:57] 
[01:02:57] the following dependencies are duplicated although they have the same features enabled:
[01:02:57] the following dependencies have different features:
[01:02:57]   serde_json 1.0.31 (registry+https://github.com/rust-lang/crates.io-index)
[01:02:57]     `clippy-driver` additionally enabled features {} at "/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/stage2-tools/x86_64-apple-darwin/release/deps/libserde_json-866c5e2383ccaafb.rlib"
[01:02:57]     `cargo` additionally enabled features {"raw_value"} at "/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/stage2-tools/x86_64-apple-darwin/release/deps/libserde_json-a09a736f2b1f9335.rlib"
[01:02:57] 
[01:02:57] to fix this you will probably want to edit the local src/tools/rustc-workspace-hack/Cargo.toml crate, as that will update the dependency graph to ensure that these crates all share the same feature set
[01:02:57] thread 'main' panicked at 'tools should not compile multiple copies of the same crate', bootstrap/tool.rs:178:13
[01:02:57] travis_fold:end:stage2-clippy-driver

[01:02:57] travis_time:end:stage2-clippy-driver:start=1538576470476599000,finish=1538576647726045000,duration=177249446000


[01:02:57] failed to run: /Users/travis/build/rust-lang/rust/build/bootstrap/debug/bootstrap build
[01:02:57] Build completed unsuccessfully in 0:58:29
[01:02:58] make: *** [all] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:04a100af
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_fold:start:after_failure.2
travis_time:start:0c48a29f
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
total 0
drwx------+ 15 travis  staff  510 Jan 25  2018 ..
drwx------   2 travis  staff   68 Dec  6  2017 .
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:12be6d3e
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
travis_time:end:12be6d3e:start=1538576653093985000,finish=1538576653113528000,duration=19543000
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1a85320a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:05759572
travis_time:start:05759572
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:09e88677
$ dmesg | grep -i kill
$ dmesg | grep -i kill
Unable to obtain kernel buffer: Operation not permitted
usage: sudo dmesg
travis_fold:end:after_failure.6

Done. Your build exited with 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Manishearth · 2018-10-03T14:30:12Z

@bors r=oli-obk

bors · 2018-10-03T14:30:16Z

📌 Commit 7b12f012c621c65c230f9ac024b14c0650c41af5 has been approved by oli-obk

rust-highfive · 2018-10-03T14:34:49Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:02:01] extracting /checkout/obj/build/cache/2018-09-23/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:02:01] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:04]     Updating crates.io index
[00:02:09]     Updating crates.io index
[00:02:10] error: no matching package named `libserde-json` found
[00:02:10] location searched: registry `https://github.com/rust-lang/crates.io-index`
[00:02:10] required by package `rustc-workspace-hack v1.0.0 (/checkout/src/tools/rustc-workspace-hack)`
[00:02:10]     ... which is depended on by `rls v0.130.5 (/checkout/src/tools/rls)`
[00:02:10] Build completed unsuccessfully in 0:00:22
[00:02:10] Makefile:81: recipe for target 'prepare' failed
[00:02:10] make: *** [prepare] Error 1
[00:02:11] Command failed. Attempt 2/5:
[00:02:11] Command failed. Attempt 2/5:
[00:02:11] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:11]     Updating crates.io index
[00:02:11] error: no matching package named `libserde-json` found
[00:02:11] location searched: registry `https://github.com/rust-lang/crates.io-index`
[00:02:11] required by package `rustc-workspace-hack v1.0.0 (/checkout/src/tools/rustc-workspace-hack)`
[00:02:11]     ... which is depended on by `rls v0.130.5 (/checkout/src/tools/rls)`
[00:02:11] Build completed unsuccessfully in 0:00:00
[00:02:11] make: *** [prepare] Error 1
[00:02:11] Makefile:81: recipe for target 'prepare' failed
[00:02:13] Command failed. Attempt 3/5:
[00:02:13] Command failed. Attempt 3/5:
[00:02:13] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:13]     Updating crates.io index
[00:02:13] error: no matching package named `libserde-json` found
[00:02:13] location searched: registry `https://github.com/rust-lang/crates.io-index`
[00:02:13] required by package `rustc-workspace-hack v1.0.0 (/checkout/src/tools/rustc-workspace-hack)`
[00:02:13]     ... which is depended on by `rls v0.130.5 (/checkout/src/tools/rls)`
[00:02:13] Build completed unsuccessfully in 0:00:00
[00:02:13] Makefile:81: recipe for target 'prepare' failed
[00:02:13] make: *** [prepare] Error 1
[00:02:16] Command failed. Attempt 4/5:
[00:02:16] Command failed. Attempt 4/5:
[00:02:16] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:17]     Updating crates.io index
[00:02:17] error: no matching package named `libserde-json` found
[00:02:17] location searched: registry `https://github.com/rust-lang/crates.io-index`
[00:02:17] required by package `rustc-workspace-hack v1.0.0 (/checkout/src/tools/rustc-workspace-hack)`
[00:02:17]     ... which is depended on by `rls v0.130.5 (/checkout/src/tools/rls)`
[00:02:17] Build completed unsuccessfully in 0:00:00
[00:02:17] make: *** [prepare] Error 1
[00:02:17] Makefile:81: recipe for target 'prepare' failed
[00:02:21] Command failed. Attempt 5/5:
[00:02:21] Command failed. Attempt 5/5:
[00:02:21] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:21]     Updating crates.io index
[00:02:21] error: no matching package named `libserde-json` found
[00:02:21] location searched: registry `https://github.com/rust-lang/crates.io-index`
[00:02:21] required by package `rustc-workspace-hack v1.0.0 (/checkout/src/tools/rustc-workspace-hack)`
[00:02:21]     ... which is depended on by `rls v0.130.5 (/checkout/src/tools/rls)`
[00:02:21] Build completed unsuccessfully in 0:00:00
[00:02:21] make: *** [prepare] Error 1
[00:02:21] Makefile:81: recipe for target 'prepare' failed
[00:02:21] The command has failed after 5 attempts.
---
travis_time:end:117edec4:start=1538577267397516502,finish=1538577267403434180,duration=5917678
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:11b34958
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:108f1b6c
travis_time:start:108f1b6c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0462873c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-10-03T14:52:52Z

@bors r-

[00:02:21] error: no matching package named `libserde-json` found

kennytm · 2018-10-03T14:53:23Z

Do you mean serde_json

Manishearth · 2018-10-03T15:12:31Z

@bors r=oli-obk

bors · 2018-10-03T15:12:37Z

📌 Commit c2c8f8a has been approved by oli-obk

Update clippy None

bors · 2018-10-03T16:56:19Z

⌛ Testing commit c2c8f8a with merge 6ada35e5c3e024a69a5111964349711021092678...

bors · 2018-10-03T18:12:19Z

💔 Test failed - status-travis

rust-highfive · 2018-10-03T18:12:20Z

The job dist-x86_64-apple-alt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:27]       Memory: 8 GB
[00:03:27]       Boot ROM Version: VMW71.00V.0.B64.1704110547
[00:03:27]       Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:03:27]       SMC Version (system): 2.8f0
[00:03:27]       Serial Number (system): VMHVZnaZ/gwW
[00:03:27] 
[00:03:27] hw.ncpu: 4
[00:03:27] hw.byteorder: 1234
[00:03:27] hw.memsize: 8589934592
---
[01:06:37] [RUSTC-TIMING] racer test:false 25.597
[01:07:00] [RUSTC-TIMING] rustfmt_nightly test:false 48.970
[01:08:05] [RUSTC-TIMING] rls test:false 64.613
[01:08:05]     Finished release [optimized] target(s) in 5m 29s
[01:08:05] duplicate artfacts found when compiling a tool, this typically means that something was recompiled because a transitive dependency has different features activated than in a previous build:
[01:08:05] 
[01:08:05] the following dependencies are duplicated although they have the same features enabled:
[01:08:05]   tempfile 3.0.3 (registry+https://github.com/rust-lang/crates.io-index)
[01:08:05]     `rls` ("/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/stage2-tools/x86_64-apple-darwin/release/deps/libtempfile-f5f1cfa5ccd89317.rlib")
[01:08:05]     `cargo` ("/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/stage2-tools/x86_64-apple-darwin/release/deps/libtempfile-0ee2c9a6386ea9fc.rlib")
[01:08:05] the following dependencies have different features:
[01:08:05]   rand 0.5.5 (registry+https://github.com/rust-lang/crates.io-index)
[01:08:05]     `rls` additionally enabled features {} at "/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/stage2-tools/x86_64-apple-darwin/release/deps/librand-3bfb134e2a7f77c2.rlib"
[01:08:05]     `cargo` additionally enabled features {"i128_support"} at "/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/stage2-tools/x86_64-apple-darwin/release/deps/librand-942306da3e39e7b2.rlib"
[01:08:05] 
[01:08:05] to fix this you will probably want to edit the local src/tools/rustc-workspace-hack/Cargo.toml crate, as that will update the dependency graph to ensure that these crates all share the same feature set
[01:08:05] thread 'main' panicked at 'tools should not compile multiple copies of the same crate', bootstrap/tool.rs:178:13
[01:08:05] travis_fold:end:stage2-rls

[01:08:05] travis_time:end:stage2-rls:start=1538589889136717000,finish=1538590219047987000,duration=329911270000


[01:08:05] failed to run: /Users/travis/build/rust-lang/rust/build/bootstrap/debug/bootstrap build
[01:08:05] Build completed unsuccessfully in 1:03:31
[01:08:05] make: *** [all] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:285b9e0e
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_fold:start:after_failure.2
travis_time:start:1df7402f
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
total 0
drwx------+ 15 travis  staff  510 Jan 25  2018 ..
drwx------   2 travis  staff   68 Dec  6  2017 .
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:2784ea18
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
travis_time:end:2784ea18:start=1538590222637828000,finish=1538590222653227000,duration=15399000
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:01722258
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:11d1f024
travis_time:start:11d1f024
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:195d021e
$ dmesg | grep -i kill
$ dmesg | grep -i kill
Unable to obtain kernel buffer: Operation not permitted
usage: sudo dmesg
travis_fold:end:after_failure.6

Done. Your build exited with 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2018-10-04T10:40:50Z

@bors r+ p=1

bors · 2018-10-04T10:40:51Z

📌 Commit 54c416d has been approved by oli-obk

rust-highfive · 2018-10-04T10:46:19Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

######################################################################## 100.0%
[00:01:56] extracting /checkout/obj/build/cache/2018-09-23/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:56] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:01:56]     Updating crates.io index
[00:02:01] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:01] Build completed unsuccessfully in 0:00:17
[00:02:01] make: *** [prepare] Error 1
[00:02:01] Makefile:81: recipe for target 'prepare' failed
[00:02:02] Command failed. Attempt 2/5:
[00:02:02] Command failed. Attempt 2/5:
[00:02:02] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:02] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:02] Build completed unsuccessfully in 0:00:00
[00:02:02] make: *** [prepare] Error 1
[00:02:02] Makefile:81: recipe for target 'prepare' failed
[00:02:04] Command failed. Attempt 3/5:
[00:02:04] Command failed. Attempt 3/5:
[00:02:04] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:05] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:05] Build completed unsuccessfully in 0:00:00
[00:02:05] make: *** [prepare] Error 1
[00:02:05] Makefile:81: recipe for target 'prepare' failed
[00:02:08] Command failed. Attempt 4/5:
[00:02:08] Command failed. Attempt 4/5:
[00:02:08] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:08] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:08] Build completed unsuccessfully in 0:00:00
[00:02:08] make: *** [prepare] Error 1
[00:02:08] Makefile:81: recipe for target 'prepare' failed
[00:02:12] Command failed. Attempt 5/5:
[00:02:12] Command failed. Attempt 5/5:
[00:02:12] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:12] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:12] Build completed unsuccessfully in 0:00:00
[00:02:12] make: *** [prepare] Error 1
[00:02:12] Makefile:81: recipe for target 'prepare' failed
[00:02:12] The command has failed after 5 attempts.
---
travis_time:end:0db297d8:start=1538649924519494582,finish=1538649924525671831,duration=6177249
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:16d22e89
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:03afb6b7
travis_time:start:03afb6b7
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:00143f70
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2018-10-04T10:50:11Z

@bors r-

oli-obk · 2018-10-04T10:52:30Z

@bors r+ p=1

bors · 2018-10-04T10:52:30Z

📌 Commit b0643ad has been approved by oli-obk

bors · 2018-10-04T14:08:19Z

⌛ Testing commit b0643ad with merge 5de5281...

Update clippy None

bors · 2018-10-04T16:34:16Z

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing 5de5281 to master...

rust-highfive · 2018-10-04T16:36:09Z

📣 Toolstate changed by #54784!

Tested on commit 5de5281.
Direct link to PR: #54784

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.

Tested on commit rust-lang/rust@5de5281. Direct link to PR: <rust-lang/rust#54784> 🎉 clippy-driver on windows: build-fail → test-pass. 🎉 clippy-driver on linux: build-fail → test-pass. 🎉 rls on windows: build-fail → test-pass. 🎉 rls on linux: build-fail → test-pass.

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 3, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 3, 2018

Manishearth force-pushed the clippyup branch from bf1e325 to 7b12f01 Compare October 3, 2018 14:30

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 3, 2018

kennytm reviewed Oct 3, 2018

View reviewed changes

Comment thread src/tools/rustc-workspace-hack/Cargo.toml Outdated

kennytm Oct 3, 2018

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean serde_json

Manishearth force-pushed the clippyup branch 2 times, most recently from e0e3c74 to dcb6a60 Compare October 3, 2018 15:11

Update clippy

c2c8f8a

Manishearth force-pushed the clippyup branch from dcb6a60 to c2c8f8a Compare October 3, 2018 15:12

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 3, 2018

kennytm added a commit to kennytm/rust that referenced this pull request Oct 3, 2018

Rollup merge of rust-lang#54784 - Manishearth:clippyup, r=oli-obk

a42a4d6

Update clippy None

kennytm mentioned this pull request Oct 3, 2018

Rollup of 10 pull requests #54790

Closed

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 3, 2018

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 3, 2018

Add features to the workspace hack

54c416d

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 4, 2018

Update Cargo.lock

b0643ad

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2018

bors added a commit that referenced this pull request Oct 4, 2018

Auto merge of #54784 - Manishearth:clippyup, r=oli-obk

5de5281

Update clippy None

bors merged commit b0643ad into rust-lang:master Oct 4, 2018

pnkfelix mentioned this pull request Nov 9, 2018

apint fails to compile on beta #55806

Closed

spastorino mentioned this pull request Jun 10, 2020

Regression: Not well-formed HRTB doesn't compile #55498

Closed

Uh oh!

Conversation

Manishearth commented Oct 3, 2018

Uh oh!

oli-obk commented Oct 3, 2018

Uh oh!

bors commented Oct 3, 2018

Uh oh!

bors commented Oct 3, 2018

Uh oh!

bors commented Oct 3, 2018

Uh oh!

rust-highfive commented Oct 3, 2018

Uh oh!

Manishearth commented Oct 3, 2018

Uh oh!

bors commented Oct 3, 2018

Uh oh!

rust-highfive commented Oct 3, 2018

Uh oh!

kennytm commented Oct 3, 2018

Uh oh!

kennytm Oct 3, 2018

Choose a reason for hiding this comment

Uh oh!

Manishearth commented Oct 3, 2018

Uh oh!

bors commented Oct 3, 2018

Uh oh!

bors commented Oct 3, 2018

Uh oh!

bors commented Oct 3, 2018

Uh oh!

rust-highfive commented Oct 3, 2018

Uh oh!

oli-obk commented Oct 4, 2018

Uh oh!

bors commented Oct 4, 2018

Uh oh!

rust-highfive commented Oct 4, 2018

Uh oh!

oli-obk commented Oct 4, 2018

Uh oh!

oli-obk commented Oct 4, 2018

Uh oh!

bors commented Oct 4, 2018

Uh oh!

bors commented Oct 4, 2018

Uh oh!

bors commented Oct 4, 2018

Uh oh!

rust-highfive commented Oct 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants