Don't emit "unused extern crate" warnings for `extern crate foo as _;` by joshtriplett · Pull Request #53479 · rust-lang/rust

joshtriplett · 2018-08-18T23:22:20Z

When importing a crate and renaming it to an underscore-prefixed name,
suppress "unused extern crate" warnings (but not idiom lints).

rust-highfive · 2018-08-18T23:22:23Z

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

joshtriplett · 2018-08-18T23:23:14Z

r? @eddyb

eddyb · 2018-08-18T23:37:05Z

@bors r+

bors · 2018-08-18T23:37:06Z

📌 Commit e2651be has been approved by eddyb

estebank · 2018-08-20T23:42:03Z

    use m::Tr1 as _; //~ WARN unused import
    use S as _; //~ WARN unused import
-    extern crate core as _; //~ WARN unused extern crate
+    extern crate core as _; // OK


Shouldn't we add a test triggering the warning?

bors · 2018-08-22T05:06:35Z

⌛ Testing commit e2651be with merge 274ef46...

Don't emit "unused extern crate" warnings for `extern crate foo as _;` When importing a crate and renaming it to an underscore-prefixed name, suppress "unused extern crate" warnings (but not idiom lints).

bors · 2018-08-22T06:52:10Z

💔 Test failed - status-travis

rust-highfive · 2018-08-22T06:52:11Z

The job x86_64-gnu-aux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:41:43] 
[01:41:43] testing https://github.com/BurntSushi/xsv
[01:41:43] Initialized empty Git repository in /checkout/obj/build/ct/xsv/.git/
[01:41:43] fatal: Could not parse object '66956b6bfd62d6ac767a6b6499c982eae20a2c9f'.
[01:42:03] fatal: unable to access 'https://github.com/BurntSushi/xsv/': Could not resolve host: github.com
[01:42:03] thread 'main' panicked at 'assertion failed: status.success()', tools/cargotest/main.rs:128:13
[01:42:03] 
[01:42:03] 
[01:42:03] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/cargotest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build/ct"
[01:42:03] expected success, got: exit code: 101
[01:42:03] expected success, got: exit code: 101
[01:42:03] 
[01:42:03] 
[01:42:03] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/test/pretty src/test/run-pass/pretty src/test/run-fail/pretty src/test/run-pass-valgrind/pretty src/test/run-pass-fulldeps/pretty src/test/run-fail-fulldeps/pretty src/tools/cargo src/tools/cargotest
[01:42:03] Build completed unsuccessfully in 0:42:47
[01:42:03] make: *** [check-aux] Error 1
[01:42:03] Makefile:60: recipe for target 'check-aux' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:088e71e2
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0c85e520:start=1534920666242412003,finish=1534920666250721263,duration=8309260
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:04adebda
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:078cca15
travis_time:start:078cca15
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:39f10cbe
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

estebank · 2018-08-22T17:01:05Z

@bors retry

timeout fetching from github

bors · 2018-08-22T22:10:07Z

☔ The latest upstream changes (presumably #53607) made this pull request unmergeable. Please resolve the merge conflicts.

TimNN · 2018-08-28T17:06:26Z

Ping from triage, @joshtriplett: This PR needs to be rebased.

When importing a crate and renaming it to an underscore-prefixed name, suppress "unused extern crate" warnings (but not idiom lints).

joshtriplett · 2018-08-29T15:56:22Z

@bors retry

estebank · 2018-08-29T17:23:55Z

@bors r+
I believe @joshtriplett after rebase the PR needs to be approved again as the commit hash changes.

estebank · 2018-08-29T17:24:17Z

@bors r=eddyb

bors · 2018-08-29T17:24:17Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Avoid calling unroll_place() in a common case. #53733

bors · 2018-08-29T17:24:18Z

📌 Commit 7cec516 has been approved by eddyb

bors · 2018-08-29T17:28:28Z

⌛ Testing commit 7cec516 with merge 769769af3430b6d6947bcf09e92a3e00366c8eb1...

joshtriplett · 2018-08-29T20:49:39Z

@bors retry

bors · 2018-08-30T00:07:24Z

⌛ Testing commit 7cec516 with merge 6244625...

Don't emit "unused extern crate" warnings for `extern crate foo as _;` When importing a crate and renaming it to an underscore-prefixed name, suppress "unused extern crate" warnings (but not idiom lints).

bors · 2018-08-30T02:57:58Z

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 6244625 to master...

rust-highfive assigned varkor Aug 18, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2018

rust-highfive assigned eddyb and unassigned varkor Aug 18, 2018

joshtriplett mentioned this pull request Aug 18, 2018

Tracking issue for RFC #2166: impl-only-use #48216

Closed

3 tasks

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2018

Mark-Simulacrum mentioned this pull request Aug 19, 2018

Rollup of 3 pull requests #53483

Closed

Nemo157 mentioned this pull request Aug 19, 2018

(Modules) Tracking issue for (use) crate_name:: paths without extern crate #53128

Closed

3 tasks

estebank reviewed Aug 20, 2018

View reviewed changes

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2018

Don't emit "unused extern crate" warnings for extern crate foo as _;

7cec516

When importing a crate and renaming it to an underscore-prefixed name, suppress "unused extern crate" warnings (but not idiom lints).

joshtriplett force-pushed the underscore-means-unused branch from e2651be to 7cec516 Compare August 29, 2018 15:55

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 29, 2018

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 29, 2018

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2018

bors merged commit 7cec516 into rust-lang:master Aug 30, 2018

Uh oh!

Conversation

joshtriplett commented Aug 18, 2018

Uh oh!

rust-highfive commented Aug 18, 2018

Uh oh!

joshtriplett commented Aug 18, 2018

Uh oh!

eddyb commented Aug 18, 2018

Uh oh!

bors commented Aug 18, 2018

Uh oh!

estebank Aug 20, 2018

Choose a reason for hiding this comment

Uh oh!

bors commented Aug 22, 2018

Uh oh!

bors commented Aug 22, 2018

Uh oh!

rust-highfive commented Aug 22, 2018

Uh oh!

estebank commented Aug 22, 2018

Uh oh!

bors commented Aug 22, 2018

Uh oh!

TimNN commented Aug 28, 2018

Uh oh!

joshtriplett commented Aug 29, 2018

Uh oh!

estebank commented Aug 29, 2018

Uh oh!

This comment has been minimized.

estebank commented Aug 29, 2018

Uh oh!

bors commented Aug 29, 2018

Uh oh!

bors commented Aug 29, 2018

Uh oh!

bors commented Aug 29, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

joshtriplett commented Aug 29, 2018

Uh oh!

bors commented Aug 30, 2018

Uh oh!

bors commented Aug 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants