Extract impl_header_lifetime_elision out of in_band_lifetimes#53016
Conversation
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
unassigning self as i'm about to go on PTO |
|
(who I assume will have good sense to delegate accordingly if necessary) |
As mentioned in the 2018-08-04 edition status update, these are postponed as lacking consensus to stabilize.
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
I have a nit, but it hardly matters
| @@ -718,6 +720,10 @@ impl<'a> LoweringContext<'a> { | |||
| return; | |||
| } | |||
There was a problem hiding this comment.
seems like we could remove this if, as it serves no purpose now
|
@bors r+ |
|
📌 Commit 1c7af27 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 Giving higher priority because this is an EP2 blocker |
…atsakis Extract impl_header_lifetime_elision out of in_band_lifetimes This way we can experiment with `impl Debug for &MyType` separately from `impl Debug for &'a MyType`. I can't say I know what the code in here is doing, so please let me know if there's a better way 🙂 I marked this as enabled in 2018 so that edition code continues to work without another flag. Actual feature PR #49251; Tracking Issue #15872; In-band lifetimes tracking issue #44524. cc @aturon, per discussion on discord earlier cc @cramertj & @nikomatsakis, who actually wrote these features
|
☀️ Test successful - status-appveyor, status-travis |
|
📣 Toolstate changed by #53016! Tested on commit 45a9d41. 💔 clippy-driver on windows: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). |
Tested on commit rust-lang/rust@45a9d41. Direct link to PR: <rust-lang/rust#53016> 💔 clippy-driver on windows: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 💔 clippy-driver on linux: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
In-band lifetimes are no longer in the edition, so update the one place that was using them.
5 participants
This way we can experiment with
impl Debug for &MyTypeseparately fromimpl Debug for &'a MyType.I can't say I know what the code in here is doing, so please let me know if there's a better way 🙂
I marked this as enabled in 2018 so that edition code continues to work without another flag.
Actual feature PR #49251; Tracking Issue #15872; In-band lifetimes tracking issue #44524.
cc @aturon, per discussion on discord earlier
cc @cramertj & @nikomatsakis, who actually wrote these features