Remove unused LLVM related code#47233
Conversation
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
hanna-kruppe
left a comment
hanna-kruppe
left a comment
There was a problem hiding this comment.
LGTM except removing the -Z flag.
There was a problem hiding this comment.
Is the idea behind removing this flag that one can pass -Cllvm-args=-debug instead? I'm fine with that, but it's not exactly "unused".
There was a problem hiding this comment.
Oh yes, now I see that the commit message mentions precisely that. As I said I'm fine with it but it's kind of a visible change so I don't feel comfortable giving r+ myself.
|
@bors: r+ Nice! |
|
📌 Commit 0b00ee7 has been approved by |
|
☔ The latest upstream changes (presumably #47235) made this pull request unmergeable. Please resolve the merge conflicts. |
The same effect can be achieved using -Cllvm-args=-debug Refs rust-lang#46437 as it removes LLVMRustSetDebug()
Refs rust-lang#46437 as it also removes LLVMRustWriteDebugLocToString()
|
@bors r=alexcrichton |
|
📌 Commit 907855f has been approved by |
|
⌛ Testing commit 907855f with merge 30105f8d4ffe1f55e3a9a896abb576cc3e3f3625... |
|
💔 Test failed - status-appveyor |
|
Looks like a timeout? I don't see any errors and the log seems to be cut off |
Remove unused LLVM related code Ticks a few more boxes on rust-lang#46437
6 participants
Ticks a few more boxes on #46437