Skip to content

gdb: Fix pretty-printing special-cased Rust types#35585

Merged
bors merged 1 commit into
rust-lang:masterfrom
Kha:gdb-qualified
Aug 31, 2016
Merged

gdb: Fix pretty-printing special-cased Rust types#35585
bors merged 1 commit into
rust-lang:masterfrom
Kha:gdb-qualified

Conversation

@Kha

@Kha Kha commented Aug 11, 2016

Copy link
Copy Markdown
Contributor

gdb trunk now reports fully qualified type names, just like lldb. Move lldb code for extracting unqualified names to shared file.

For current releases of gdb, extract_type_name should just be a no-op.

Fixes #35155

gdb trunk now reports fully qualified type names, just like lldb. Move
lldb code for extracting unqualified names to shared file.
@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aturon

aturon commented Aug 27, 2016

Copy link
Copy Markdown
Contributor

r? @michaelwoerister

@michaelwoerister

Copy link
Copy Markdown
Member

@bors r+

Thanks for the PR, looks good to me!

@bors

bors commented Aug 29, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 4714072 has been approved by michaelwoerister

@bors

bors commented Aug 30, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4714072 with merge 2582133...

@bors

bors commented Aug 30, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt

@alexcrichton

Copy link
Copy Markdown
Member

@bors: retry

On Tue, Aug 30, 2016 at 12:20 PM, bors notifications@github.com wrote:

💔 Test failed - auto-mac-64-opt
https://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/10368


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#35585 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95DcPRJTRNfKjyF4ukXlkltLHVeojks5qlIKMgaJpZM4JhwNH
.

@bors

bors commented Aug 31, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4714072 with merge 824000a...

bors added a commit that referenced this pull request Aug 31, 2016
gdb: Fix pretty-printing special-cased Rust types

gdb trunk now reports fully qualified type names, just like lldb. Move lldb code for extracting unqualified names to shared file.

For current releases of gdb, `extract_type_name` should just be a no-op.

Fixes #35155
@bors bors merged commit 4714072 into rust-lang:master Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants