Skip to content

std: Fix usage of SOCK_CLOEXEC#34946

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:fix-cfg
Jul 28, 2016
Merged

std: Fix usage of SOCK_CLOEXEC#34946
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:fix-cfg

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

This code path was intended to only get executed on Linux, but unfortunately the
cfg! was malformed so it actually never got executed.

This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@brson

brson commented Jul 21, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jul 21, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 15cd5a1 has been approved by brson

@brson brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 21, 2016
@bors

bors commented Jul 21, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15cd5a1 with merge 4b0371c...

@bors

bors commented Jul 21, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-cargotest

@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: retry

On Wed, Jul 20, 2016 at 6:01 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-cargotest
https://buildbot.rust-lang.org/builders/auto-linux-64-cargotest/builds/1194


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95JX_cwRUN9dmuS56Vz6pHH6eD2Sdks5qXsTagaJpZM4JRVeA
.

@bors

bors commented Jul 21, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15cd5a1 with merge 4b24e08...

@bors

bors commented Jul 21, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-msvc-64-opt-mir

@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: retry

On Thu, Jul 21, 2016 at 12:39 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-mir
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-mir/builds/1504


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Labf_72DTySjVrco2zfV0cAkkLyks5qX8r_gaJpZM4JRVeA
.

@bors

bors commented Jul 22, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15cd5a1 with merge 1054428...

@bors

bors commented Jul 22, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: retry

On Fri, Jul 22, 2016 at 4:17 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1912


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95KakrrcAF6y0trCPm3znaSIZZ2nmks5qYU-BgaJpZM4JRVeA
.

@bors

bors commented Jul 23, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15cd5a1 with merge 1bdc162...

bors added a commit that referenced this pull request Jul 23, 2016
std: Fix usage of SOCK_CLOEXEC

This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@bors

bors commented Jul 23, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-x-android-t

@arielb1

arielb1 commented Jul 23, 2016

Copy link
Copy Markdown
Contributor

@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: retry

@bors

bors commented Jul 25, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15cd5a1 with merge d33473b...

@bors

bors commented Jul 25, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: retry

On Sun, Jul 24, 2016 at 10:47 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1925


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95LkDh18vC9B9hGz5fkoYmvtVqqT6ks5qZE3dgaJpZM4JRVeA
.

@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: retry

@bors

bors commented Jul 25, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15cd5a1 with merge 65b403a...

@bors

bors commented Jul 25, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: retry

On Mon, Jul 25, 2016 at 2:59 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/5070


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95CF2J5CF1UW_cperKIrl6WJOq7l2ks5qZTGpgaJpZM4JRVeA
.

@bors

bors commented Jul 26, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15cd5a1 with merge d510024...

@bors

bors commented Jul 26, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: retry

On Tue, Jul 26, 2016 at 3:20 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1953


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34946 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95I18rfRgI-2FdCGnvjaFyhA70NGqks5qZd-GgaJpZM4JRVeA
.

@bors

bors commented Jul 28, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15cd5a1 with merge f5d7952...

bors added a commit that referenced this pull request Jul 28, 2016
std: Fix usage of SOCK_CLOEXEC

This code path was intended to only get executed on Linux, but unfortunately the
`cfg!` was malformed so it actually never got executed.
@bors bors merged commit 15cd5a1 into rust-lang:master Jul 28, 2016
@alexcrichton alexcrichton deleted the fix-cfg branch August 26, 2016 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes Marks issues that should be documented in the release notes of the next release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants