rustdoc: Fix search result layout for enum variants and struct fields#34477
Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
Thanks! @bors: r+ |
Collaborator
|
📌 Commit 27e4ecd has been approved by |
Collaborator
|
⌛ Testing commit 27e4ecd with merge e9ab267... |
Collaborator
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
Member
|
@bors: retry |
Collaborator
|
⌛ Testing commit 27e4ecd with merge 6fb20ac... |
Collaborator
|
💔 Test failed - auto-linux-32-opt |
Member
|
@bors: retry |
Collaborator
bors
added a commit
that referenced
this pull request
Jun 27, 2016
rustdoc: Fix search result layout for enum variants and struct fields This was broken in #34234. For example: [before](https://doc.rust-lang.org/nightly/std/?search=cow%3A%3Aborrowed) [after](https://ollie27.github.io/rust_doc_test/std/?search=cow%3A%3Aborrowed) [before](https://doc.rust-lang.org/nightly/std/?search=range%3A%3Astart) [after](https://ollie27.github.io/rust_doc_test/std/?search=range%3A%3Astart) cc @GuillaumeGomez
Collaborator
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 11, 2017
…aumeGomez rustdoc: Fix broken CSS in search results The layout is currently broken for struct/union fields and enum variants in the search results when searching from a struct, union or enum page. Some examples: https://doc.rust-lang.org/nightly/std/ops/struct.RangeInclusive.html?search=start https://doc.rust-lang.org/nightly/std/option/enum.Option.html?search=some rust-lang#34477 was an incomplete fix
MaloJaffre
added a commit
to MaloJaffre/rust
that referenced
this pull request
Aug 11, 2017
…aumeGomez rustdoc: Fix broken CSS in search results The layout is currently broken for struct/union fields and enum variants in the search results when searching from a struct, union or enum page. Some examples: https://doc.rust-lang.org/nightly/std/ops/struct.RangeInclusive.html?search=start https://doc.rust-lang.org/nightly/std/option/enum.Option.html?search=some rust-lang#34477 was an incomplete fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken in #34234.
For example:
before after
before after
cc @GuillaumeGomez