Revert "Convert negate_unsigned feature gate to a warning"#28468
Merged
Conversation
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
nagisa
force-pushed
the
revert-negate-unsigned-warning
branch
from
df3d3ab to
240d018
Compare
Member
|
Looks like there's a legit test failure on travis, but otherwise r=me. |
nagisa
force-pushed
the
revert-negate-unsigned-warning
branch
from
240d018 to
8131c63
Compare
Member
Author
|
I believe I fixed it. |
Member
|
Could you squash the commits together as well? |
This reverts commit 0ca8e49 and fixes the code to work with current rustc. Fixes rust-lang#27141
nagisa
force-pushed
the
revert-negate-unsigned-warning
branch
from
8131c63 to
5104a93
Compare
Member
Author
|
Done. |
Member
alexcrichton
added
the
relnotes
Member
|
Tagging with relnotes for @brson as well |
Collaborator
Collaborator
|
💔 Test failed - auto-win-gnu-32-nopt-t |
Member
|
@bors: retry On Fri, Sep 18, 2015 at 5:08 PM, bors notifications@github.com wrote:
|
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0ca8e49.
Fixes #27141