Skip to content

Smaller refactor svh#27461

Closed
richo wants to merge 1 commit into
rust-lang:masterfrom
richo:smaller-refactor-svh
Closed

Smaller refactor svh#27461
richo wants to merge 1 commit into
rust-lang:masterfrom
richo:smaller-refactor-svh

Conversation

@richo

@richo richo commented Aug 1, 2015

Copy link
Copy Markdown
Contributor

This is the first half of the implementation of what I set out to do in #26629.

This will make the location of attrs in crates not affect their hash values any more, although it doesn't expose a public way to do this outside of an entire Svh yet, which is how I intended to implement the dupe attribute lint.

For posterity, I did the yolo science with: https://gist.github.com/richo/f750855a762804e2b3e9

r? @alexcrichton

Ping #14132

This makes the hash of a crate no longer whitespace dependant on it's
attributes

Ping rust-lang#14132
@richo richo force-pushed the smaller-refactor-svh branch from cc3ebbb to de81de5 Compare August 1, 2015 21:42
@richo

richo commented Aug 1, 2015

Copy link
Copy Markdown
Contributor Author

(The assertion that this closes #14132 was based on yolo-science™, updated to reflect that)

@brson

brson commented Aug 2, 2015

Copy link
Copy Markdown
Contributor

@bors r+ Nice improvements.

@bors

bors commented Aug 2, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit de81de5 has been approved by brson

@richo

richo commented Aug 2, 2015

Copy link
Copy Markdown
Contributor Author

@brson you'll need to r-, I ran make check overnight and it breaks some svh tests (in the same way that my other changes did, it's upset about the crates hashes changing)

@Gankra

Gankra commented Aug 2, 2015

Copy link
Copy Markdown
Contributor

@bors r-

On Sun, Aug 2, 2015 at 11:54 AM, Richo Healey notifications@github.com
wrote:

@brson https://github.com/brson you'll need to r-, I ran make check
overnight and it breaks some svh tests (in the same way that my other
changes did, it's upset about the crates hashes changing)


Reply to this email directly or view it on GitHub
#27461 (comment).

@alexcrichton

Copy link
Copy Markdown
Member

Closing due to inactivity, but feel free to send a new PR with tests fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants