Skip to content

Cleanup configure nits#27331

Closed
mstewartgallus wants to merge 8 commits into
rust-lang:masterfrom
mstewartgallus:cleanup-configure-nits
Closed

Cleanup configure nits#27331
mstewartgallus wants to merge 8 commits into
rust-lang:masterfrom
mstewartgallus:cleanup-configure-nits

Conversation

@mstewartgallus

Copy link
Copy Markdown
Contributor

So, I'm doing more things to cleanup the configure script.

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

Copy link
Copy Markdown
Member

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned pcwalton Jul 27, 2015
@bors

bors commented Jul 28, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #27250) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

bors commented Jul 28, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #27173) made this pull request unmergeable. Please resolve the merge conflicts.

@mstewartgallus

Copy link
Copy Markdown
Contributor Author

I did make this ready merge and change the parts talked about.

@brson

brson commented Aug 12, 2015

Copy link
Copy Markdown
Contributor

I haven't seen this PR before. Will review tomorrow.

@bors

bors commented Aug 12, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #27630) made this pull request unmergeable. Please resolve the merge conflicts.

@brson

brson commented Aug 14, 2015

Copy link
Copy Markdown
Contributor

r=me I'm sorry I forgot about this.

@tamird

tamird commented Sep 24, 2015

Copy link
Copy Markdown
Contributor

needs a rebase

@alexcrichton

Copy link
Copy Markdown
Member

Closing due to inactivity, but feel free to resend with a rebase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants