syntax: Allow semi tokens after macro ty/path#27000
Merged
Merged
Conversation
This commit expands the follow set of the `ty` and `path` macro fragments to
include the semicolon token as well. A semicolon is already allowed after these
tokens, so it's currently a little too restrictive to not have a semicolon
allowed. For example:
extern {
fn foo() -> i32; // semicolon after type
}
fn main() {
struct Foo;
Foo; // semicolon after path
}
Contributor
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
LGTM - I believe @cmr is the follow token czar though. |
Contributor
|
Looking. |
Contributor
|
👍, could you also send a PR to update the RFC text here |
Contributor
|
@bors: r+ rollup |
Collaborator
|
📌 Commit af55623 has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Jul 13, 2015
This commit expands the follow set of the `ty` and `path` macro fragments to
include the semicolon token as well. A semicolon is already allowed after these
tokens, so it's currently a little too restrictive to not have a semicolon
allowed. For example:
extern {
fn foo() -> i32; // semicolon after type
}
fn main() {
struct Foo;
Foo; // semicolon after path
}
Collaborator
alexcrichton
added a commit
to alexcrichton/rfcs
that referenced
this pull request
Jul 13, 2015
Accounts for rust-lang/rust#27000
brson
added
the
relnotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit expands the follow set of the
tyandpathmacro fragments toinclude the semicolon token as well. A semicolon is already allowed after these
tokens, so it's currently a little too restrictive to not have a semicolon
allowed. For example: