Add test for #15919#24987
Closed
bombless wants to merge 2 commits into
Closed
Conversation
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 1, 2015
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 1, 2015
Member
|
@bors: r- The test fails due to an unexpected warning. Manishearth@ac12fc8 fixes that, but the error disappears. Please fix these first, thanks! |
Contributor
Author
|
Sorry, I'll reopen it once I fix it. |
Contributor
Author
|
Okay, fixed. Sorry for the trouble. |
Contributor
Author
|
r? @pnkfelix |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 4c8b813 has been approved by |
Contributor
|
@bors rollup |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 12, 2015
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 13, 2015
Contributor
|
This still doesn't work, and caused the rollup to fail http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4955/steps/test/logs/stdio |
Contributor
|
@bors: r- |
Contributor
Author
|
Mac again... so the bug still exist on Mac OSX in a different form, closing this PR. |
Member
|
It's not a mac issue; it's a 32bit vs 64bit issue. (mac is just the fastest builder and fails first) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15919