Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
src/librustc/metadata/encoder.rs
Outdated
There was a problem hiding this comment.
I think this was correct "one test was failing"
|
Oops, there was a wrong patch, reverted it |
|
This looks good to me, but can you squash into one commit, please? r=me after |
Also, update description of macro invocation syntax: after rust-lang#20563 there is a number of additional limitations on macro syntax.
|
Squashed into one commit |
|
@alkor it only lets people with permission do it, and you have to put it on the commit, rather than the PR. But thanks! |
Doc fixes Reviewed-by: steveklabnik
|
@steveklabnik Where can I find info about these r[-+=] commands? Readme at https://github.com/graydon/bors seems incomplete and I only briefly looked at the source code of bors. |
|
@steveklabnik Thank you! |
[r+] Doc fixes Reviewed-by: steveklabnik
[r+] Doc fixes Reviewed-by: steveklabnik
[r+] Doc fixes Reviewed-by: steveklabnik
Corrections in TRPL macros guide
…port-for-postcard Integrate postcard support into proc-macro server CLI
6 participants
Corrections in TRPL macros guide