Add skip(n: uint) to Read, Seek, File, MemReader and BufferedReader#18137
Closed
nodakai wants to merge 2 commits into
Closed
Add skip(n: uint) to Read, Seek, File, MemReader and BufferedReader#18137nodakai wants to merge 2 commits into
nodakai wants to merge 2 commits into
Conversation
One step forward to rust-lang#13989 Signed-off-by: NODA, Kai <nodakai@gmail.com>
Resolve rust-lang#13989 Signed-off-by: NODA, Kai <nodakai@gmail.com>
Contributor
Contributor
|
Wow, sorry for the delay! This needs a rebase, but I wonder if the changes in the past month (like multidispatch traits) would change how #13989 is approached. |
Member
|
@nodakai like @bstrie, I'd like to apologize for the delay here, sorry about that! This week @aturon and I have taken a close look at Thanks for being patient, and I'll try to be sure to keep you updated on the status of the RFC (coming soon!). |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Sep 25, 2024
feat: Implement `expr_2021` Resolves rust-lang#18062
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #13989
Note: the second patch is based on UFCS and doesn't compile with snapshot 2014-10-10.
I could write unit tests only for Read::skip(). How should I add more?