Disable compilation on some extensionless files#17945
Closed
natepisarski wants to merge 2 commits into
Closed
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. |
Member
|
Thanks @natepisarski! The tracking issue for this is #13019, so you could actually put I think there may also be some more cases that need to be handled here (can you add tests for all these as well?)
When adding tests, could you add them to the |
Author
|
@alexcrichton I can do all of these. Probably not in the most timely manor, but I can get them done. |
Member
|
Ok, thanks @natepisarski! |
Member
|
Closing due to inactivity, but feel free to reopen with comments addressed! |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Sep 25, 2024
…ibektas Recategorize config classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit prevents the compiler from overwriting certain extensionless source files with a binary.
As it stands, if you have /home/joe/file1:
and compile it
It will replace the source (file1) with a binary called file1, destroying the source without warning or error.
This commit completely disallows compiling without a file extension, but still allows compiling with an inccorect (i.e not .rs) extension.