Skip to content

delegation: map return even if there is no target expression - #164361

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:delegation-map-return-when-no-target-expr
Oct 16, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:delegation-map-return-when-no-target-expr

Conversation

@aerooneqq

@aerooneqq aerooneqq commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

When we can perform Self mapping and there is no target expression we still should map the return value.

Part of #118212.
r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 15, 2026
@rust-log-analyzer

This comment has been minimized.

@petrochenkov petrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Oct 15, 2026
@aerooneqq
aerooneqq force-pushed the delegation-map-return-when-no-target-expr branch from 900fd45 to 8e840fe Compare October 15, 2026 14:52
@petrochenkov

Copy link
Copy Markdown
Contributor

I've just seen this issue today when testing whether #164208 was already on nightly or not.
@bors r+

@rust-bors

rust-bors Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8e840fe has been tentatively approved by petrochenkov

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 15, 2026
…en-no-target-expr, r=petrochenkov

delegation: map return even if there is no target expression

When we can perform `Self` mapping and there is no target expression we still should map the return value.

Part of rust-lang#118212.
r? @petrochenkov
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 15, 2026
…en-no-target-expr, r=petrochenkov

delegation: map return even if there is no target expression

When we can perform `Self` mapping and there is no target expression we still should map the return value.

Part of rust-lang#118212.
r? @petrochenkov
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 15, 2026
…en-no-target-expr, r=petrochenkov

delegation: map return even if there is no target expression

When we can perform `Self` mapping and there is no target expression we still should map the return value.

Part of rust-lang#118212.
r? @petrochenkov
rust-bors Bot pushed a commit that referenced this pull request Oct 15, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #164271 (Add release notes for 1.99.1)
 - #164361 (delegation: map return even if there is no target expression)
 - #162778 (rustdoc: add disambiguators for identically named method in sidebar)
 - #163224 ([rustdoc] Add tabs to settings popover)
 - #164220 (Test the interaction between `--remap-path-prefix` and doctests)
 - #164279 (Make the `documentation` scope a sub-scope of the `object` scope)
 - #164318 (Fix check with `is_impl_trait_in_trait()` before expecting local id)
 - #164360 (Fix(lib/sys): Restore Win7 compilation)
rust-bors Bot pushed a commit that referenced this pull request Oct 16, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #164175 (Drop WC_ERR_INVALID_CHARS from Windows stdio)
 - #164361 (delegation: map return even if there is no target expression)
 - #162778 (rustdoc: add disambiguators for identically named method in sidebar)
 - #163224 ([rustdoc] Add tabs to settings popover)
 - #164220 (Test the interaction between `--remap-path-prefix` and doctests)
 - #164318 (Fix check with `is_impl_trait_in_trait()` before expecting local id)
 - #164360 (Fix(lib/sys): Restore Win7 compilation)
@rust-bors
rust-bors Bot merged commit ef2d081 into rust-lang:main Oct 16, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 16, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 16, 2026
Rollup merge of #164361 - aerooneqq:delegation-map-return-when-no-target-expr, r=petrochenkov

delegation: map return even if there is no target expression

When we can perform `Self` mapping and there is no target expression we still should map the return value.

Part of #118212.
r? @petrochenkov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-fn_delegation `#![feature(fn_delegation)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants