Skip to content

explicitly mark next-solver ICE in test suite - #164204

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lcnr:uwu
Oct 13, 2026
Merged

explicitly mark next-solver ICE in test suite#164204
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lcnr:uwu

Conversation

@lcnr

@lcnr lcnr commented Oct 12, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 12, 2026
@rustbot

rustbot commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 20 candidates

@lqd

lqd commented Oct 12, 2026

Copy link
Copy Markdown
Member

r? me @bors r+ rollup

@rust-bors

rust-bors Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 65bae8b has been tentatively approved by lqd

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 12, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 12, 2026
@rust-bors

rust-bors Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

❌ Commit 65bae8b has been unapproved due to PR CI failure. Reapprove it with @bors r+ force if you want to ignore the failure.

@lcnr lcnr mentioned this pull request Oct 12, 2026
Open
@lqd

lqd commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@lcnr did this work locally? mixing a check-pass a build-pass and an ICE in the same test doesn't seem like it can work. this probably needs a check-pass on the new solver revision or something?

@rustbot

rustbot commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@lcnr

lcnr commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

relies on debug assertions, no clue why

@bors r=lqd

@rust-bors

rust-bors Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ef56e79 has been tentatively approved by lqd

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 13, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 13, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 13, 2026
@bors
Auto merge of #164256 - JonathanBrouwer:rollup-bObd0BT, r=JonathanBro…
dc4a7c1 
…uwer

Rollup of 8 pull requests

Successful merges:

 - #163258 (Move `rustc_middle::ty::Const` to `rustc_type_ir` Part 2)
 - #164173 (don't drop `AnyOpaqueHasInferAsHidden` when merging with `OpaqueInStorageOrAnyOpaqueHasInferAsHidden`)
 - #160230 (CFI: Cover each InstanceKind explicitly)
 - #163713 (codegen Propagate reported errors from ABI checks)
 - #164205 (cg_llvm: Assorted cleanups to LLVM diagnostic handling)
 - #164114 (restore the old behavior for `derive(Default)` on fieldless types)
 - #164127 (core: Ignore explicit_tail_calls doc tests on PowerPC)
 - #164204 (explicitly mark next-solver ICE in test suite)
@rust-bors
rust-bors Bot merged commit 6f8ffb1 into rust-lang:main Oct 13, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 13, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 13, 2026
@bors
Unrolled build for #164204 in rollup 164256
e447c13 
Rollup merge of #164204 - lcnr:uwu, r=lqd

explicitly mark next-solver ICE in test suite

cc #163817 https://rust-lang.zulipchat.com/#narrow/channel/618216-t-types.2Fcall-for-participation/topic/unnormalized.20aliases.20after.20normalizatoon/with/630957987
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Oct 14, 2026
@bors
Auto merge of #164256 - JonathanBrouwer:rollup-bObd0BT, r=JonathanBro…
5ce1205 
…uwer

Rollup of 8 pull requests

Successful merges:

 - rust-lang/rust#163258 (Move `rustc_middle::ty::Const` to `rustc_type_ir` Part 2)
 - rust-lang/rust#164173 (don't drop `AnyOpaqueHasInferAsHidden` when merging with `OpaqueInStorageOrAnyOpaqueHasInferAsHidden`)
 - rust-lang/rust#160230 (CFI: Cover each InstanceKind explicitly)
 - rust-lang/rust#163713 (codegen Propagate reported errors from ABI checks)
 - rust-lang/rust#164205 (cg_llvm: Assorted cleanups to LLVM diagnostic handling)
 - rust-lang/rust#164114 (restore the old behavior for `derive(Default)` on fieldless types)
 - rust-lang/rust#164127 (core: Ignore explicit_tail_calls doc tests on PowerPC)
 - rust-lang/rust#164204 (explicitly mark next-solver ICE in test suite)
@github-actions github-actions Bot mentioned this pull request Oct 15, 2026
Merged
antoyo pushed a commit to rust-lang/rustc_codegen_gcc that referenced this pull request Oct 19, 2026
@bors
Auto merge of #164256 - JonathanBrouwer:rollup-bObd0BT, r=JonathanBro…
1e4465d 
…uwer

Rollup of 8 pull requests

Successful merges:

 - rust-lang/rust#163258 (Move `rustc_middle::ty::Const` to `rustc_type_ir` Part 2)
 - rust-lang/rust#164173 (don't drop `AnyOpaqueHasInferAsHidden` when merging with `OpaqueInStorageOrAnyOpaqueHasInferAsHidden`)
 - rust-lang/rust#160230 (CFI: Cover each InstanceKind explicitly)
 - rust-lang/rust#163713 (codegen Propagate reported errors from ABI checks)
 - rust-lang/rust#164205 (cg_llvm: Assorted cleanups to LLVM diagnostic handling)
 - rust-lang/rust#164114 (restore the old behavior for `derive(Default)` on fieldless types)
 - rust-lang/rust#164127 (core: Ignore explicit_tail_calls doc tests on PowerPC)
 - rust-lang/rust#164204 (explicitly mark next-solver ICE in test suite)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lqd lqd

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lcnr @rustbot @lqd @rust-log-analyzer @jieyouxu