Skip to content

Use verbose suggestion for method written as function - #163054

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
estebank:method-as-fn
Sep 21, 2026
Merged

Use verbose suggestion for method written as function#163054
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
estebank:method-as-fn

Conversation

@estebank

@estebank estebank commented Sep 20, 2026

Copy link
Copy Markdown
Contributor 
error[E0425]: cannot find function `bar` in this scope
  --> $DIR/suggest-self-2.rs:9:9
   |
LL |         bar(&&self, 102);
   |         ^^^
   |
help: try calling `bar` as a method
   |
LL -         bar(&&self, 102);
LL +         self.bar(102);
   |

@estebank
Use verbose suggestion for method written as function
19c656c 
```
error[E0425]: cannot find function `bar` in this scope
  --> $DIR/suggest-self-2.rs:9:9
   |
LL |         bar(&&self, 102);
   |         ^^^
   |
help: try calling `bar` as a method
   |
LL -         bar(&&self, 102);
LL +         self.bar(102);
   |
```
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 20, 2026
@rustbot

rustbot commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 17 candidates

@estebank estebank mentioned this pull request Sep 20, 2026
Open
3 tasks
oli-obk
oli-obk approved these changes Sep 21, 2026
View reviewed changes

@oli-obk oli-obk left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 19c656c has been approved by oli-obk

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

Reason for tree closure: babysitting some spurious failures

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 21, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Sep 21, 2026
@bors
Auto merge of #163119 - JonathanBrouwer:rollup-YdZQI8k, r=JonathanBro…
2699985 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #162948 (Set target-abi module flag for LoongArch targets)
 - #162600 (Make the last non-breaking box impl generalizations)
 - #163031 (Use newer `make` version when building GCC)
 - #163054 (Use verbose suggestion for method written as function)
 - #163073 (Expand docs on `rustc_abi::Variants`)
@rust-bors
rust-bors Bot merged commit 4da19f3 into rust-lang:main Sep 21, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 21, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 21, 2026
@bors
Unrolled build for #163054 in rollup 163119
ccb6587 
Rollup merge of #163054 - estebank:method-as-fn, r=oli-obk

Use verbose suggestion for method written as function

```
error[E0425]: cannot find function `bar` in this scope
  --> $DIR/suggest-self-2.rs:9:9
   |
LL |         bar(&&self, 102);
   |         ^^^
   |
help: try calling `bar` as a method
   |
LL -         bar(&&self, 102);
LL +         self.bar(102);
   |
```
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Sep 22, 2026
@bors
Auto merge of #163119 - JonathanBrouwer:rollup-YdZQI8k, r=JonathanBro…
f758325 
…uwer

Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#162948 (Set target-abi module flag for LoongArch targets)
 - rust-lang/rust#162600 (Make the last non-breaking box impl generalizations)
 - rust-lang/rust#163031 (Use newer `make` version when building GCC)
 - rust-lang/rust#163054 (Use verbose suggestion for method written as function)
 - rust-lang/rust#163073 (Expand docs on `rustc_abi::Variants`)
pull Bot pushed a commit to xtqqczze/rust-lang-rustc-dev-guide that referenced this pull request Sep 30, 2026
@bors
Auto merge of #163119 - JonathanBrouwer:rollup-YdZQI8k, r=JonathanBro…
dde9a10 
…uwer

Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#162948 (Set target-abi module flag for LoongArch targets)
 - rust-lang/rust#162600 (Make the last non-breaking box impl generalizations)
 - rust-lang/rust#163031 (Use newer `make` version when building GCC)
 - rust-lang/rust#163054 (Use verbose suggestion for method written as function)
 - rust-lang/rust#163073 (Expand docs on `rustc_abi::Variants`)
@github-actions github-actions Bot mentioned this pull request Oct 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

3 participants

@estebank @rustbot @oli-obk