Remove some code duplication in coerce_shared.rs by Jules-Bertholet · Pull Request #162672 · rust-lang/rust

Jules-Bertholet · 2026-09-12T04:19:39Z

Saw this while working on something else.

rustbot · 2026-09-12T04:19:45Z

rustbot has assigned @tiif.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler, types
compiler, types expanded to 76 candidates
Random selection from 20 candidates

tiif · 2026-09-27T09:27:21Z

Thanks!

@bors r+ rollup

rust-bors · 2026-09-27T09:27:25Z

📌 Commit 3e8ba94 has been approved by tiif

It is now in the queue for this repository.

Remove some code duplication in coerce_shared.rs Saw this while working on something else.

rust-log-analyzer · 2026-09-27T11:00:24Z

The job test-aarch64-msvc-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [debuginfo-cdb] tests\debuginfo\basic-stepping.rs#maximally-steppable stdout ----

error in revision `maximally-steppable`: check directive(s) from `C:\a\rust\rust\tests\debuginfo\basic-stepping.rs#maximally-steppable` not found in debugger output. errors:
    (basic-stepping.rs:130) `   [...]:     let i = [1,2,3,4];`
    (basic-stepping.rs:132) `   [...]:     let j = (23, "hi");`
    (basic-stepping.rs:134) `   [...]:     let k = 2..3;`
    (basic-stepping.rs:136) `   [...]:     let l = &i[k];`
    (basic-stepping.rs:138) `   [...]:     let m: *const() = &a;`
the following subset of check directive(s) was found successfully:
    (basic-stepping.rs:118) `>  147:     let mut c = 27;`
    (basic-stepping.rs:120) `>  148:     let d = c = 99;`
    (basic-stepping.rs:122) `>  149:     let e = "hi bob";`
    (basic-stepping.rs:124) `>  150:     let f = b"hi bob";`
    (basic-stepping.rs:126) `>  151:     let g = b'9';`
    (basic-stepping.rs:128) `>  152:     let h = ["whatever"; 8];`
status: exit code: 0
command: PATH="C:\a\rust\rust\build\aarch64-pc-windows-msvc\stage2\lib\rustlib\aarch64-pc-windows-msvc\lib;C:\Program Files\Microsoft Visual Studio\18\Enterprise\VC\Tools\MSVC\14.51.36231\bin\HostARM64\arm64;C:\Program Files\Microsoft Visual Studio\18\Enterprise\VC\Tools\MSVC\14.51.36231\bin\HostARM64\arm64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\arm64;C:\Program Files (x86)\Windows Kits\10\bin\arm64;C:\Program Files\Git\clangarm64\bin;C:\Program Files\Git\usr\bin;C:\Users\runneradmin\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\citools\clang-rust\bin;C:\a\rust\rust\sccache;C:\aliyun-cli;C:\vcpkg;C:\tools\zstd;C:\Program Files (x86)\NSIS;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.11.1\x64;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files (x86)\R\R-4.6.1\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\usr\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.24.13\arm64\bin;C:\hostedtoolcache\windows\Python\3.13.15\arm64\Scripts;C:\hostedtoolcache\windows\Python\3.13.15\arm64;C:\hostedtoolcache\windows\Ruby\3.4.10\aarch64\bin;C:\Program Files\LLVM\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\21.0.12-101.0\aarch64\bin;C:\Tools\Ninja;C:\Program Files (x86)\ImageMagick-7.1.2-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\Microsoft SQL Server\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\dotnet;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Program Files\Microsoft SQL Server\170\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.16\bin;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\clangarm64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "C:\\Program Files (x86)\\Windows Kits\\10\\Debuggers\\arm64\\cdb.exe" "-lines" "-cf" "C:\\a\\rust\\rust\\build\\aarch64-pc-windows-msvc\\test\\debuginfo\\basic-stepping.maximally-steppable.cdb\\basic-stepping.debugger.script" "C:\\a\\rust\\rust\\build\\aarch64-pc-windows-msvc\\test\\debuginfo\\basic-stepping.maximally-steppable.cdb\\a.exe"
--- stdout -------------------------------

************* Preparing the environment for Debugger Extensions Gallery repositories **************
   ExtensionRepository : Implicit
   UseExperimentalFeatureForNugetShare : true
   AllowNugetExeUpdate : true
   NonInteractiveNuget : true
   AllowNugetMSCredentialProviderInstall : true
   AllowParallelInitializationOfLocalRepositories : true

   EnableRedirectToV8JsProvider : false

   -- Configuring repositories
      ----> Repository : LocalInstalled, Enabled: true
      ----> Repository : UserExtensions, Enabled: true

>>>>>>>>>>>>> Preparing the environment for Debugger Extensions Gallery repositories completed, duration 0.000 seconds

************* Waiting for Debugger Extensions Gallery to Initialize **************

>>>>>>>>>>>>> Waiting for Debugger Extensions Gallery to Initialize completed, duration 0.203 seconds
   ----> Repository : UserExtensions, Enabled: true, Packages count: 0
   ----> Repository : LocalInstalled, Enabled: true, Packages count: 27

Microsoft (R) Windows Debugger Version 10.0.26100.6584 ARM64
Copyright (c) Microsoft Corporation. All rights reserved.

CommandLine: C:\a\rust\rust\build\aarch64-pc-windows-msvc\test\debuginfo\basic-stepping.maximally-steppable.cdb\a.exe

************* Path validation summary **************
Response                         Time (ms)     Location
Deferred                                       srv*
Symbol search path is: srv*
Executable search path is: 
ModLoad: 00007ff7`ef370000 00007ff7`ef377000   a.exe   
ModLoad: 00007ff8`8e890000 00007ff8`8ecc7000   ntdll.dll
ModLoad: 00007ff8`8daf0000 00007ff8`8dc5b000   C:\Windows\System32\KERNEL32.DLL
ModLoad: 00007ff8`8a250000 00007ff8`8a930000   C:\Windows\System32\KERNELBASE.dll
ModLoad: 00007ff8`896f0000 00007ff8`897f6000   C:\Windows\SYSTEM32\apphelp.dll
ModLoad: 00007ff8`8a020000 00007ff8`8a249000   C:\Windows\System32\ucrtbase.dll
ModLoad: 00007ff8`71f90000 00007ff8`72083000   C:\a\rust\rust\build\aarch64-pc-windows-msvc\stage2\lib\rustlib\aarch64-pc-windows-msvc\lib\std-89fdf05d35a1e5ee.dll
ModLoad: 00007ff8`8d040000 00007ff8`8d116000   C:\Windows\System32\WS2_32.dll
ModLoad: 00007ff8`735a0000 00007ff8`735df000   C:\Windows\SYSTEM32\VCRUNTIME140.dll
ModLoad: 00007ff8`8de20000 00007ff8`8e023000   C:\Windows\System32\RPCRT4.dll
ModLoad: 00007ff8`89f10000 00007ff8`8a00f000   C:\Windows\System32\bcryptprimitives.dll
ModLoad: 00007ff8`88260000 00007ff8`882c1000   C:\Windows\SYSTEM32\USERENV.dll
(11c4.240c): Break instruction exception - code 80000003 (first chance)
ntdll!LdrpDoDebuggerBreak+0x34:
00007ff8`8e9ee54c d43e0000 brk         #0xF000
0:000> version
Windows 10 Version 26200 MP (4 procs) Free ARM 64-bit (AArch64)
Product: WinNt, suite: SingleUserTS
Edition build lab: 26100.1.arm64fre.ge_release.240331-1435
Build layer: DesktopEditions -> 26100.1.arm64fre.ge_release.240331-1435
Build layer: OnecoreUAP -> 26100.1.arm64fre.ge_release.240331-1435
Build layer: ShellCommon -> 26100.9457.arm64fre.ge_release_svc_im.260912-0409
Build layer: OSClient   -> 26100.9457.arm64fre.ge_release_svc_im.260912-0409
Debug session time: Sun Sep 27 03:59:29.560 2026 (UTC - 7:00)
System Uptime: 0 days 1:33:53.132
Process Uptime: 0 days 0:00:01.243
  Kernel time: 0 days 0:00:00.000
  User time: 0 days 0:00:00.000
Live user mode: <Local>

Microsoft (R) Windows Debugger Version 10.0.26100.6584 ARM64
Copyright (c) Microsoft Corporation. All rights reserved.

command line: '"C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\cdb.exe" -lines -cf C:\a\rust\rust\build\aarch64-pc-windows-msvc\test\debuginfo\basic-stepping.maximally-steppable.cdb\basic-stepping.debugger.script C:\a\rust\rust\build\aarch64-pc-windows-msvc\test\debuginfo\basic-stepping.maximally-steppable.cdb\a.exe'  Debugger Process 0x2A78 
dbgeng:  image 10.0.26100.6584, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\dbgeng.dll]
dbghelp: image 10.0.26100.8249, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\dbghelp.dll]
        DIA version: 33145
Extension DLL search Path:
    C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\WINXP;C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\winext;C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\winext\arcade;C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\pri;C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64;C:\Users\runneradmin\AppData\Local\Dbg\EngineExtensions;C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64;C:\a\rust\rust\build\aarch64-pc-windows-msvc\stage2\lib\rustlib\aarch64-pc-windows-msvc\lib;C:\Program Files\Microsoft Visual Studio\18\Enterprise\VC\Tools\MSVC\14.51.36231\bin\HostARM64\arm64;C:\Program Files\Microsoft Visual Studio\18\Enterprise\VC\Tools\MSVC\14.51.36231\bin\HostARM64\arm64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\arm64;C:\Program Files (x86)\Windows Kits\10\bin\arm64;C:\Program Files\Git\clangarm64\bin;C:\Program Files\Git\usr\bin;C:\Users\runneradmin\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\citools\clang-rust\bin;C:\a\rust\rust\sccache;C:\aliyun-cli;C:\vcpkg;C:\tools\zstd;C:\Program Files (x86)\NSIS;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.11.1\x64;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files (x86)\R\R-4.6.1\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\usr\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.24.13\arm64\bin;C:\hostedtoolcache\windows\Python\3.13.15\arm64\Scripts;C:\hostedtoolcache\windows\Python\3.13.15\arm64;C:\hostedtoolcache\windows\Ruby\3.4.10\aarch64\bin;C:\Program Files\LLVM\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\21.0.12-101.0\aarch64\bin;C:\Tools\Ninja;C:\Program Files (x86)\ImageMagick-7.1.2-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\Microsoft SQL Server\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\dotnet;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Program Files\Microsoft SQL Server\170\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.16\bin;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\clangarm64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps
Extension DLL chain:
    dbghelp: image 10.0.26100.8249, API 10.0.6, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\dbghelp.dll]
    exts: image 10.0.26100.6584, API 1.0.0, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\WINXP\exts.dll]
    uext: image 10.0.26100.6584, API 1.0.0, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\winext\uext.dll]
    ntsdexts: image 10.0.26100.6584, API 1.0.0, 
        [path: C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\WINXP\ntsdexts.dll]
0:000> .nvlist
Loaded NatVis Files:
    <None Loaded>
0:000> bp `basic-stepping.rs:143`
*** WARNING: Unable to verify checksum for a.exe
*** WARNING: Unable to verify checksum for C:\a\rust\rust\build\aarch64-pc-windows-msvc\stage2\lib\rustlib\aarch64-pc-windows-msvc\lib\std-89fdf05d35a1e5ee.dll
0:000>  .lines -e
Line number information will be loaded
0:000>  l+s
Source options are 4:
     4/s - List source code at prompt
0:000>  l+t
Source options are 5:
     1/t - Step/trace by source line
     4/s - List source code at prompt
0:000>  g
Breakpoint 0 hit
>  147:     let mut c = 27;
a!basic_stepping::main+0x10:
00007ff7`ef3710ec d10203a9 sub         x9,fp,#0x80
0:000>  p
>  148:     let d = c = 99;
a!basic_stepping::main+0x20:
00007ff7`ef3710fc 52800c68 mov         w8,#0x63
0:000>  p
>  149:     let e = "hi bob";
a!basic_stepping::main+0x30:
00007ff7`ef37110c aa0803ea mov         x10,x8
0:000>  p
>  150:     let f = b"hi bob";
a!basic_stepping::main+0x40:
00007ff7`ef37111c f9002128 str         x8,[x9,#0x40]
0:000>  p
>  151:     let g = b'9';
a!basic_stepping::main+0x44:
00007ff7`ef371120 52800728 mov         w8,#0x39
0:000>  p
>  152:     let h = ["whatever"; 8];
a!basic_stepping::main+0x4c:
00007ff7`ef371128 9100a3e8 add         x8,sp,#0x28
0:000>  p
ModLoad: 00007ff8`878c0000 00007ff8`878f1000   C:\Windows\SYSTEM32\kernel.appcore.dll
ModLoad: 00007ff8`8e100000 00007ff8`8e248000   C:\Windows\System32\msvcrt.dll
ntdll!NtTerminateProcess+0x4:
00007ff8`8e891304 d65f03c0 ret
0:000>  p
        ^ No runnable debuggees error in ' p'
0:000>  p
        ^ No runnable debuggees error in ' p'
0:000>  p
        ^ No runnable debuggees error in ' p'
0:000>  p
        ^ No runnable debuggees error in ' p'
0:000>  p
        ^ No runnable debuggees error in ' p'
0:000> qq
quit:
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\atlmfc.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\ObjectiveC.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\concurrency.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\cpp_rest.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\stl.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\Windows.Data.Json.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\Windows.Devices.Geolocation.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\Windows.Devices.Sensors.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\Windows.Media.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\windows.natvis'
NatVis script unloaded from 'C:\Program Files (x86)\Windows Kits\10\Debuggers\arm64\Visualizers\winrt.natvis'
------------------------------------------
stderr: none

---- [debuginfo-cdb] tests\debuginfo\basic-stepping.rs#maximally-steppable stdout end ----

---
Currently active steps:
test::Debuginfo { test_compiler: Compiler { stage: 2, host: aarch64-pc-windows-msvc, forced_compiler: false }, target: aarch64-pc-windows-msvc } at src\bootstrap\src\core\build_steps\test.rs:1977
test::Compiletest { test_compiler: Compiler { stage: 2, host: aarch64-pc-windows-msvc, forced_compiler: false }, target: aarch64-pc-windows-msvc, mode: debuginfo, suite: "debuginfo", path: "tests/debuginfo", compare_mode: Some("split-dwarf") } at src\bootstrap\src\core\build_steps\test.rs:1977
Build completed unsuccessfully in 1:20:13
make: *** [Makefile:115: ci-msvc-py] Error 1
  local time: Sun Sep 27 04:00:01 PDT 2026
  network time: Sun, 27 Sep 2026 11:00:01 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

rust-bors · 2026-09-27T11:00:48Z

💔 Test for 70efc34 failed: CI. Failed job:

auto - test-aarch64-msvc-1 (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-09-27T13:33:22Z

@bors retry

…uwer Rollup of 3 pull requests Successful merges: - #162714 (compiletest: stream output of executor process when --no-capture is set) - #163394 (Use StaticAllocator in more places) - #162672 (Remove some code duplication in coerce_shared.rs)

Rollup merge of #162672 - Jules-Bertholet:mini-refactor, r=tiif Remove some code duplication in coerce_shared.rs Saw this while working on something else.

Remove some code duplication in coerce_shared.rs

3e8ba94

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 12, 2026

rustbot assigned tiif Sep 12, 2026

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 12, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 27, 2026

Auto merge of #162672 - Jules-Bertholet:mini-refactor, r=tiif

70efc34

Remove some code duplication in coerce_shared.rs Saw this while working on something else.

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 27, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2026

JonathanBrouwer mentioned this pull request Sep 27, 2026

Rollup of 3 pull requests #163404

Merged

rust-bors Bot merged commit 961368b into rust-lang:main Sep 27, 2026
13 of 14 checks passed

rustbot added this to the 1.101.0 milestone Sep 27, 2026

rust-bors Bot pushed a commit that referenced this pull request Sep 27, 2026

Unrolled build for #162672 in rollup 163404

ae6dd2c

Rollup merge of #162672 - Jules-Bertholet:mini-refactor, r=tiif Remove some code duplication in coerce_shared.rs Saw this while working on something else.

Jules-Bertholet deleted the mini-refactor branch September 27, 2026 17:59

github-actions Bot mentioned this pull request Oct 3, 2026

Toolchain upgrade to nightly-2026-10-09 flux-rs/flux#1811

Draft

Navigation Menu

Repository navigation

Remove some code duplication in coerce_shared.rs - #162672

Remove some code duplication in coerce_shared.rs#162672
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Jules-Bertholet:mini-refactor

Jules-Bertholet commented Sep 12, 2026

Uh oh!

rustbot commented Sep 12, 2026

Uh oh!

tiif commented Sep 27, 2026

Uh oh!

rust-bors Bot commented Sep 27, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Sep 27, 2026

Uh oh!

rust-bors Bot commented Sep 27, 2026

Uh oh!

JonathanBrouwer commented Sep 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Jules-Bertholet commented Sep 12, 2026

Uh oh!

rustbot commented Sep 12, 2026

Uh oh!

tiif commented Sep 27, 2026

Uh oh!

rust-bors Bot commented Sep 27, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Sep 27, 2026

Uh oh!

rust-bors Bot commented Sep 27, 2026

Uh oh!

JonathanBrouwer commented Sep 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants