Skip to content

chore: fix cargo lints - #161842

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
weihanglo:cargo-lints
Aug 27, 2026
Merged

chore: fix cargo lints#161842
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
weihanglo:cargo-lints

Conversation

@weihanglo

Copy link
Copy Markdown
Member

Fixes two cargo lint erros found during #161789 (comment).

See each commit message respectively for details.

```
warning: explicit `package.readme` can be inferred
  --> compiler/rustc_thread_pool/Cargo.toml:11:1
   |
11 | readme = "README.md"
   | ^^^^^^^^^^^^^^^^^^^^
   |
   = note: `cargo::manual_readme` is set to `warn` by default
help: consider removing `package.readme`
warning: `rustc_thread_pool` (manifest) generated 1 warning
```

See
<https://triage.rust-lang.org/gha-logs/rust-lang/rust/98030530980#L2026-08-26T03:05:00.5401170Z-L2026-08-26T03:05:00.5402963Z>
```
warning: unused dependency `unified-diff`
  --> src/tools/compiletest/Cargo.toml:37:1
   |
37 | unified-diff = "0.2.1"
   | ^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `cargo::unused_dependencies` is set to `warn` by default
help: consider removing the dependency on `unified-diff`
warning: `compiletest` (manifest) generated 1 warning
```

See
<https://triage.rust-lang.org/gha-logs/rust-lang/rust/98030530980#L2026-08-26T03:05:07.8912904Z-L2026-08-26T03:05:07.8915112Z>
@rustbot

rustbot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/compiletest

cc @jieyouxu

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc labels Aug 27, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 27, 2026
@rustbot

rustbot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Mark-Simulacrum

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me after PR CI green
r? me

View changes since this review

@rustbot rustbot assigned jieyouxu and unassigned Mark-Simulacrum Aug 27, 2026
@jieyouxu

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

📌 Commit e3af0b6 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 27, 2026
chore: fix cargo lints

Fixes two cargo lint erros found during <rust-lang#161789 (comment)>.

See each commit message respectively for details.
rust-bors Bot pushed a commit that referenced this pull request Aug 27, 2026
Rollup of 7 pull requests

Successful merges:

 - #150075 (Implement clamp_to)
 - #161034 (Add SVE-accelerated Vec::retain_mut for aarch64)
 - #161628 (interpret: ensure that calls via no-unwind ABIs do not unwind)
 - #161012 (borrowck: Normalize non-rigid aliases in NLL type relating)
 - #161702 (Use `drop_guard` in some places in {core,alloc,std})
 - #161813 (Change `is_eligible_for_coverage` from a hook to a query)
 - #161842 (chore: fix cargo lints)
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 27, 2026
chore: fix cargo lints

Fixes two cargo lint erros found during <rust-lang#161789 (comment)>.

See each commit message respectively for details.
rust-bors Bot pushed a commit that referenced this pull request Aug 27, 2026
Rollup of 6 pull requests

Successful merges:

 - #161034 (Add SVE-accelerated Vec::retain_mut for aarch64)
 - #161628 (interpret: ensure that calls via no-unwind ABIs do not unwind)
 - #161012 (borrowck: Normalize non-rigid aliases in NLL type relating)
 - #161702 (Use `drop_guard` in some places in {core,alloc,std})
 - #161813 (Change `is_eligible_for_coverage` from a hook to a query)
 - #161842 (chore: fix cargo lints)
rust-bors Bot pushed a commit that referenced this pull request Aug 27, 2026
Rollup of 7 pull requests

Successful merges:

 - #161034 (Add SVE-accelerated Vec::retain_mut for aarch64)
 - #161628 (interpret: ensure that calls via no-unwind ABIs do not unwind)
 - #161012 (borrowck: Normalize non-rigid aliases in NLL type relating)
 - #161691 (Assorted bootstrap config refactors (part 1/N))
 - #161813 (Change `is_eligible_for_coverage` from a hook to a query)
 - #161842 (chore: fix cargo lints)
 - #161843 (rustdoc: fix lint `cargo::non_kebab_case_bins`)
@rust-bors
rust-bors Bot merged commit 5e67e2e into rust-lang:main Aug 27, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Aug 27, 2026
rust-bors Bot pushed a commit that referenced this pull request Aug 27, 2026
Rollup merge of #161842 - weihanglo:cargo-lints, r=jieyouxu

chore: fix cargo lints

Fixes two cargo lint erros found during <#161789 (comment)>.

See each commit message respectively for details.
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Aug 28, 2026
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#161034 (Add SVE-accelerated Vec::retain_mut for aarch64)
 - rust-lang/rust#161628 (interpret: ensure that calls via no-unwind ABIs do not unwind)
 - rust-lang/rust#161012 (borrowck: Normalize non-rigid aliases in NLL type relating)
 - rust-lang/rust#161691 (Assorted bootstrap config refactors (part 1/N))
 - rust-lang/rust#161813 (Change `is_eligible_for_coverage` from a hook to a query)
 - rust-lang/rust#161842 (chore: fix cargo lints)
 - rust-lang/rust#161843 (rustdoc: fix lint `cargo::non_kebab_case_bins`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants