make trivial ABI check resilient against new repr - #161745
Merged
Merged
Conversation
Collaborator
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 25, 2026
make trivial ABI check resilient against new repr There's currently no way to exhaustively match on "what basic `repr` is this", which is kind of fragile as it means a new repr will get whatever the `else` branch happens to be everywhere. Changing this would be a major refactor, but let's at least make it possible to `assert!` that we covered all the cases by adding an explicit way to check for `repr(Rust)`.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 25, 2026
make trivial ABI check resilient against new repr There's currently no way to exhaustively match on "what basic `repr` is this", which is kind of fragile as it means a new repr will get whatever the `else` branch happens to be everywhere. Changing this would be a major refactor, but let's at least make it possible to `assert!` that we covered all the cases by adding an explicit way to check for `repr(Rust)`.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 25, 2026
make trivial ABI check resilient against new repr There's currently no way to exhaustively match on "what basic `repr` is this", which is kind of fragile as it means a new repr will get whatever the `else` branch happens to be everywhere. Changing this would be a major refactor, but let's at least make it possible to `assert!` that we covered all the cases by adding an explicit way to check for `repr(Rust)`.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 25, 2026
make trivial ABI check resilient against new repr There's currently no way to exhaustively match on "what basic `repr` is this", which is kind of fragile as it means a new repr will get whatever the `else` branch happens to be everywhere. Changing this would be a major refactor, but let's at least make it possible to `assert!` that we covered all the cases by adding an explicit way to check for `repr(Rust)`.
This was referenced Aug 25, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 25, 2026
…uwer Rollup of 13 pull requests Successful merges: - #158874 (hir_ty_lowering: fix anon const type recovery) - #161443 (add internal DSL for testing binders) - #161617 (Add custom allocators to `(try_)map` on `Box`, `Rc`, `Arc`) - #161726 (Fix debugger visualizer tuple child ordering w/ PDB debug info) - #161729 (miri subtree update) - #161745 (make trivial ABI check resilient against new repr) - #160871 (Remove `#[rustc_reservation_impl]`) - #161180 (Detect missing binding available: add a MaybeIncorrect suggestion) - #161522 (test `f16::mul_add` not double-rounding the result) - #161631 (Add two comments relating to new-solver performance) - #161724 (Add codegen test for static table search loop unrolling) - #161740 (do not compress debuginfo for Cygwin) - #161750 (vector ABI check: reword so it makes more sense for non-obviously-vector types)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 25, 2026
Rollup merge of #161745 - RalfJung:repr-exhaustive, r=mati865 make trivial ABI check resilient against new repr There's currently no way to exhaustively match on "what basic `repr` is this", which is kind of fragile as it means a new repr will get whatever the `else` branch happens to be everywhere. Changing this would be a major refactor, but let's at least make it possible to `assert!` that we covered all the cases by adding an explicit way to check for `repr(Rust)`.
pull Bot
pushed a commit
to LeeeeeeM/miri
that referenced
this pull request
Aug 26, 2026
…uwer Rollup of 13 pull requests Successful merges: - rust-lang/rust#158874 (hir_ty_lowering: fix anon const type recovery) - rust-lang/rust#161443 (add internal DSL for testing binders) - rust-lang/rust#161617 (Add custom allocators to `(try_)map` on `Box`, `Rc`, `Arc`) - rust-lang/rust#161726 (Fix debugger visualizer tuple child ordering w/ PDB debug info) - rust-lang/rust#161729 (miri subtree update) - rust-lang/rust#161745 (make trivial ABI check resilient against new repr) - rust-lang/rust#160871 (Remove `#[rustc_reservation_impl]`) - rust-lang/rust#161180 (Detect missing binding available: add a MaybeIncorrect suggestion) - rust-lang/rust#161522 (test `f16::mul_add` not double-rounding the result) - rust-lang/rust#161631 (Add two comments relating to new-solver performance) - rust-lang/rust#161724 (Add codegen test for static table search loop unrolling) - rust-lang/rust#161740 (do not compress debuginfo for Cygwin) - rust-lang/rust#161750 (vector ABI check: reword so it makes more sense for non-obviously-vector types)
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 28, 2026
…uwer Rollup of 13 pull requests Successful merges: - rust-lang/rust#158874 (hir_ty_lowering: fix anon const type recovery) - rust-lang/rust#161443 (add internal DSL for testing binders) - rust-lang/rust#161617 (Add custom allocators to `(try_)map` on `Box`, `Rc`, `Arc`) - rust-lang/rust#161726 (Fix debugger visualizer tuple child ordering w/ PDB debug info) - rust-lang/rust#161729 (miri subtree update) - rust-lang/rust#161745 (make trivial ABI check resilient against new repr) - rust-lang/rust#160871 (Remove `#[rustc_reservation_impl]`) - rust-lang/rust#161180 (Detect missing binding available: add a MaybeIncorrect suggestion) - rust-lang/rust#161522 (test `f16::mul_add` not double-rounding the result) - rust-lang/rust#161631 (Add two comments relating to new-solver performance) - rust-lang/rust#161724 (Add codegen test for static table search loop unrolling) - rust-lang/rust#161740 (do not compress debuginfo for Cygwin) - rust-lang/rust#161750 (vector ABI check: reword so it makes more sense for non-obviously-vector types)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's currently no way to exhaustively match on "what basic
repris this", which is kind of fragile as it means a new repr will get whatever theelsebranch happens to be everywhere. Changing this would be a major refactor, but let's at least make it possible toassert!that we covered all the cases by adding an explicit way to check forrepr(Rust).