Rollup of 3 pull requests - #161737
Closed
JonathanBrouwer wants to merge 26 commits into
Closed
Conversation
update dependencies
…when-reliable run `f16` and `f128` tests natively when reliable
port all variadic functions to strict signature checking
run _Unwind_RaiseException test on Windows
unify shim_sig and shim_sig_variadic macros
Custom allocators do not get noalias after all
This updates the rust-version file to 9bb55c8.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@9bb55c8 Filtered ref: rust-lang/miri@89242b0 Upstream diff: rust-lang/rust@c656540...9bb55c8 This merge was created using https://github.com/rust-lang/josh-sync.
Fix debugger visualizer tuple child ordering w/ PDB debug info see: llvm/llvm-project#218613 for an explanation of the issue. tl;dr, PDB fields reflect rustc's reordering, whereas DWARF fields are in source-code-order. This causes issues with `GetChildAtIndex` in cases where both DWARF- and PDB-based types can interact with them. This PR uses field names to retrieve field indexes, rather than blindly indexing into the field array. I did a quick scan over the rest of the `GetChildAtIndex` calls, and they all fall under a few safe cases 1. in DWARF or PDB specific providers (mainly enum discriminants, which can't be reordered anyway) 2. used to get field `0` of a struct with only 1 field 3. in the summary provider where we're typically already interacting with the synthetic value and synthetic children anyway cc rust-lang#161657, fixes `tests/debuginfo/tuple-struct.rs` on `windows-msvc` <details><summary>`windows-msvc` `tests/debuginfo` results with this change</summary> ``` failures: [debuginfo-lldb] tests\debuginfo\associated-types.rs [debuginfo-lldb] tests\debuginfo\borrowed-basic.rs [debuginfo-lldb] tests\debuginfo\borrowed-unique-basic.rs [debuginfo-lldb] tests\debuginfo\basic-types-globals.rs#no-lto [debuginfo-lldb] tests\debuginfo\borrowed-tuple.rs [debuginfo-lldb] tests\debuginfo\boxed-struct.rs [debuginfo-lldb] tests\debuginfo\captured-fields-2.rs [debuginfo-lldb] tests\debuginfo\cross-crate-spans.rs [debuginfo-lldb] tests\debuginfo\coroutine-locals.rs [debuginfo-lldb] tests\debuginfo\box.rs [debuginfo-lldb] tests\debuginfo\captured-fields-1.rs [debuginfo-lldb] tests\debuginfo\c-style-enum-in-composite.rs [debuginfo-lldb] tests\debuginfo\by-value-self-argument-in-trait-impl.rs [debuginfo-lldb] tests\debuginfo\destructured-for-loop-variable.rs [debuginfo-lldb] tests\debuginfo\dummy_span.rs [debuginfo-lldb] tests\debuginfo\evec-in-struct.rs [debuginfo-lldb] tests\debuginfo\destructured-fn-argument.rs [debuginfo-lldb] tests\debuginfo\destructured-local.rs [debuginfo-lldb] tests\debuginfo\generic-struct.rs [debuginfo-lldb] tests\debuginfo\issue-22656.rs [debuginfo-lldb] tests\debuginfo\basic-types-globals.rs#lto [debuginfo-lldb] tests\debuginfo\lexical-scope-in-if.rs [debuginfo-lldb] tests\debuginfo\lexical-scope-in-stack-closure.rs [debuginfo-lldb] tests\debuginfo\lexical-scope-in-unconditional-loop.rs [debuginfo-lldb] tests\debuginfo\lexical-scope-with-macro.rs [debuginfo-lldb] tests\debuginfo\lexical-scope-in-unique-closure.rs [debuginfo-lldb] tests\debuginfo\lexical-scope-in-if-let.rs [debuginfo-lldb] tests\debuginfo\lexical-scopes-in-block-expression.rs [debuginfo-lldb] tests\debuginfo\method-on-generic-struct.rs [debuginfo-lldb] tests\debuginfo\lexical-scope-in-while.rs [debuginfo-lldb] tests\debuginfo\lexical-scope-in-for-loop.rs [debuginfo-lldb] tests\debuginfo\name-shadowing-and-scope-nesting.rs [debuginfo-lldb] tests\debuginfo\no_mangle-info.rs [debuginfo-lldb] tests\debuginfo\packed-struct-with-destructor.rs [debuginfo-lldb] tests\debuginfo\pretty-slices.rs [debuginfo-lldb] tests\debuginfo\packed-struct.rs [debuginfo-lldb] tests\debuginfo\reference-debuginfo.rs [debuginfo-lldb] tests\debuginfo\simple-struct.rs [debuginfo-lldb] tests\debuginfo\simple-lexical-scope.rs [debuginfo-lldb] tests\debuginfo\shadowed-variable.rs [debuginfo-lldb] tests\debuginfo\simple-tuple.rs [debuginfo-lldb] tests\debuginfo\shadowed-argument.rs [debuginfo-lldb] tests\debuginfo\struct-with-destructor.rs [debuginfo-lldb] tests\debuginfo\strings-and-strs.rs [debuginfo-lldb] tests\debuginfo\struct-in-struct.rs [debuginfo-lldb] tests\debuginfo\pretty-std-collections.rs [debuginfo-lldb] tests\debuginfo\tuple-in-tuple.rs [debuginfo-lldb] tests\debuginfo\thread-names.rs#win [debuginfo-lldb] tests\debuginfo\vec-slices.rs [debuginfo-lldb] tests\debuginfo\var-captured-in-sendable-closure.rs [debuginfo-lldb] tests\debuginfo\var-captured-in-stack-closure.rs [debuginfo-lldb] tests\debuginfo\var-captured-in-nested-closure.rs test result: FAILED. 244 passed; 52 failed; 223 ignored; 0 measured; 0 filtered out; finished in 13.22s ``` </details>
miri subtree update I want to add proper vararg checks for Miri's shims but it turns out I'll have to adjust the rustc side for this. It'll be easier to just do the entire thing as a rustc patch, but that needs a sync first. --- Subtree update of `miri` to rust-lang/miri@40000c5. Created using https://github.com/rust-lang/josh-sync. r? @ghost
Add codegen test for static table search loop unrolling Adds a test for reported case in rust-lang#44041. The follow up case in that issue is still open so this does not close it
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
r? @ghost
Create a similar rollup