Print vendor instructions in `x vendor` by Kobzol · Pull Request #161666 · rust-lang/rust

Kobzol · 2026-08-24T11:58:49Z

When the user manually runs x vendor, we should tell them what to put into their .cargo/config.toml file. This regressed some time ago when the Vendor step was refactored in bootstrap, I think.

Before this PR, the part after "this project" was blank:

To use vendored sources, add this to your .cargo/config.toml for this project:

[source.crates-io]
replace-with = "vendored-sources"

[source."git+https://github.com/rust-lang/team"]
git = "https://github.com/rust-lang/team"
replace-with = "vendored-sources"

[source.vendored-sources]
directory = "vendor"

r? bjorn3

rustbot · 2026-08-24T11:58:54Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: bootstrap
bootstrap expanded to 6 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu

bjorn3 · 2026-08-24T12:37:51Z

The library/.cargo/config.toml also needs to be created, right?

Kobzol · 2026-08-24T12:42:47Z

Hmm, I guess so, depends on what the user intends to do. But if we also print that, then the To use vendored sources, add this to your .cargo/config.toml for this project: message won't make much sense. So we'd have to recreate it ourselves and print both of the config paths and contents to be created.

bjorn3 · 2026-08-27T13:40:22Z

I'm not sure if building rust-src offline will work if library/.cargo/config.toml is missing.

Kobzol · 2026-08-27T14:52:58Z

Ok, makes sense. We won't "reuse" Cargo's output, but that doesn't really matter, I added our own. The current output is this:

Put the following config into .cargo/config.toml:
[source.crates-io]
replace-with = "vendored-sources"

[source."git+https://github.com/rust-lang/team"]
git = "https://github.com/rust-lang/team"
replace-with = "vendored-sources"

[source.vendored-sources]
directory = "vendor"


Put the following config into library/.cargo/config.toml:
[source.crates-io]
replace-with = "vendored-sources"

[source.vendored-sources]
directory = "vendor"

@rustbot ready

bjorn3 · 2026-08-27T14:57:04Z

@bors r+

rust-bors · 2026-08-27T14:57:08Z

📌 Commit 4ccc259 has been approved by bjorn3

It is now in the queue for this repository.

bjorn3 · 2026-08-27T14:57:19Z

@bors rollup

Print vendor instructions in `x vendor` When the user manually runs `x vendor`, we should tell them what to put into their `.cargo/config.toml` file. This regressed some time ago when the Vendor step was refactored in bootstrap, I think. Before this PR, the part after "this project" was blank: ``` To use vendored sources, add this to your .cargo/config.toml for this project: [source.crates-io] replace-with = "vendored-sources" [source."git+https://github.com/rust-lang/team"] git = "https://github.com/rust-lang/team" replace-with = "vendored-sources" [source.vendored-sources] directory = "vendor" ``` r? bjorn3

Rollup of 14 pull requests Successful merges: - #150075 (Implement clamp_to) - #159103 (fix(reborrow): recursive implementation) - #160848 (std: avoid aliasing violations when wrapping opaque C types) - #161421 (Include startup crt objects on WASI for more outputs) - #161805 (Prefer ambiguous candidates when deduplicating traits in scope, so `ambiguous_glob_imported_traits` doesn't depend on import order) - #161862 (Put data segment in specified section with link_section on wasm) - #161866 (delegation: add tests fixating behavior of delegating to default trait implementations) - #161456 (reduce perf impact of scalar size checks) - #161666 (Print vendor instructions in `x vendor`) - #161730 (Improve type mismatch annotation for lets with block-wrapped initializers) - #161828 (Never type after-stabilization cleanup) - #161860 (atomicptr.rs test: remove unused import) - #161870 (bind to [::1] instead of 127.0.0.1 in documentation examples for v6 UDP methods) - #161876 (rustdoc: Correctly handle when a macro generates multiple items in `--generate-macro-expansion`)

Print vendor instructions in `x vendor` When the user manually runs `x vendor`, we should tell them what to put into their `.cargo/config.toml` file. This regressed some time ago when the Vendor step was refactored in bootstrap, I think. Before this PR, the part after "this project" was blank: ``` To use vendored sources, add this to your .cargo/config.toml for this project: [source.crates-io] replace-with = "vendored-sources" [source."git+https://github.com/rust-lang/team"] git = "https://github.com/rust-lang/team" replace-with = "vendored-sources" [source.vendored-sources] directory = "vendor" ``` r? bjorn3

…uwer Rollup of 21 pull requests Successful merges: - #158609 (Update sccache to 0.16.0) - #150075 (Implement clamp_to) - #159103 (fix(reborrow): recursive implementation) - #160562 (add target feature ABI checks for SPARC) - #160848 (std: avoid aliasing violations when wrapping opaque C types) - #161421 (Include startup crt objects on WASI for more outputs) - #161805 (Prefer ambiguous candidates when deduplicating traits in scope, so `ambiguous_glob_imported_traits` doesn't depend on import order) - #161862 (Put data segment in specified section with link_section on wasm) - #161866 (delegation: add tests fixating behavior of delegating to default trait implementations) - #161456 (reduce perf impact of scalar size checks) - #161528 (Add regression test to ensure optimal compilation) - #161666 (Print vendor instructions in `x vendor`) - #161730 (Improve type mismatch annotation for lets with block-wrapped initializers) - #161828 (Never type after-stabilization cleanup) - #161859 (Do not optimize MIR for comptime ConstFns) - #161860 (atomicptr.rs test: remove unused import) - #161870 (bind to [::1] instead of 127.0.0.1 in documentation examples for v6 UDP methods) - #161876 (rustdoc: Correctly handle when a macro generates multiple items in `--generate-macro-expansion`) - #161889 (Add link to ownership section in ptr::read docs) - #161890 (rustdoc: some clarifying comments) - #161891 (Mark `extern_item_impls` feature as incomplete) Failed merges: - #161702 (Use `drop_guard` in some places in {core,alloc,std})

…uwer Rollup of 21 pull requests Successful merges: - #150075 (Implement clamp_to) - #159103 (fix(reborrow): recursive implementation) - #160562 (add target feature ABI checks for SPARC) - #160848 (std: avoid aliasing violations when wrapping opaque C types) - #161421 (Include startup crt objects on WASI for more outputs) - #161805 (Prefer ambiguous candidates when deduplicating traits in scope, so `ambiguous_glob_imported_traits` doesn't depend on import order) - #161862 (Put data segment in specified section with link_section on wasm) - #161866 (delegation: add tests fixating behavior of delegating to default trait implementations) - #157218 (Track items behind `cfg_select` in the same way we do for `cfg`) - #161456 (reduce perf impact of scalar size checks) - #161528 (Add regression test to ensure optimal compilation) - #161666 (Print vendor instructions in `x vendor`) - #161730 (Improve type mismatch annotation for lets with block-wrapped initializers) - #161828 (Never type after-stabilization cleanup) - #161859 (Do not optimize MIR for comptime ConstFns) - #161860 (atomicptr.rs test: remove unused import) - #161870 (bind to [::1] instead of 127.0.0.1 in documentation examples for v6 UDP methods) - #161876 (rustdoc: Correctly handle when a macro generates multiple items in `--generate-macro-expansion`) - #161889 (Add link to ownership section in ptr::read docs) - #161890 (rustdoc: some clarifying comments) - #161891 (Mark `extern_item_impls` feature as incomplete) Failed merges: - #161702 (Use `drop_guard` in some places in {core,alloc,std})

Rollup merge of #161666 - Kobzol:vendor-print, r=bjorn3 Print vendor instructions in `x vendor` When the user manually runs `x vendor`, we should tell them what to put into their `.cargo/config.toml` file. This regressed some time ago when the Vendor step was refactored in bootstrap, I think. Before this PR, the part after "this project" was blank: ``` To use vendored sources, add this to your .cargo/config.toml for this project: [source.crates-io] replace-with = "vendored-sources" [source."git+https://github.com/rust-lang/team"] git = "https://github.com/rust-lang/team" replace-with = "vendored-sources" [source.vendored-sources] directory = "vendor" ``` r? bjorn3

rustbot assigned Mark-Simulacrum Aug 24, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 24, 2026

rustbot assigned bjorn3 and unassigned Mark-Simulacrum Aug 24, 2026

This comment was marked as outdated.

Sign in to view

bjorn3 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2026

Print vendor instructions in x vendor

4ccc259

Kobzol force-pushed the vendor-print branch from df31415 to 4ccc259 Compare August 27, 2026 14:52

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 27, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2026

matthiaskrgr mentioned this pull request Aug 27, 2026

Rollup of 12 pull requests #161874

Closed

JonathanBrouwer mentioned this pull request Aug 27, 2026

Rollup of 11 pull requests #161875

Closed

JonathanBrouwer mentioned this pull request Aug 27, 2026

Rollup of 11 pull requests #161878

Closed

GuillaumeGomez mentioned this pull request Aug 27, 2026

Rollup of 14 pull requests #161884

Closed

JonathanBrouwer mentioned this pull request Aug 28, 2026

Rollup of 18 pull requests #161901

Closed

JonathanBrouwer mentioned this pull request Aug 28, 2026

Rollup of 21 pull requests #161905

Closed

JonathanBrouwer mentioned this pull request Aug 28, 2026

Rollup of 21 pull requests #161906

Merged

rust-bors Bot merged commit d288793 into rust-lang:main Aug 28, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Aug 28, 2026

Kobzol deleted the vendor-print branch August 28, 2026 15:05

Navigation Menu

Uh oh!

Uh oh!

Print vendor instructions in `x vendor` - #161666

Print vendor instructions in `x vendor`#161666
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Kobzol:vendor-print

Kobzol commented Aug 24, 2026 •

edited

Loading

Uh oh!

rustbot commented Aug 24, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

bjorn3 commented Aug 24, 2026

Uh oh!

Kobzol commented Aug 24, 2026

Uh oh!

bjorn3 commented Aug 27, 2026

Uh oh!

Kobzol commented Aug 27, 2026

Uh oh!

bjorn3 commented Aug 27, 2026

Uh oh!

rust-bors Bot commented Aug 27, 2026

Uh oh!

bjorn3 commented Aug 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Kobzol commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 24, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

bjorn3 commented Aug 24, 2026

Uh oh!

Kobzol commented Aug 24, 2026

Uh oh!

bjorn3 commented Aug 27, 2026

Uh oh!

Kobzol commented Aug 27, 2026

Uh oh!

bjorn3 commented Aug 27, 2026

Uh oh!

rust-bors Bot commented Aug 27, 2026

Uh oh!

bjorn3 commented Aug 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kobzol commented Aug 24, 2026 •

edited

Loading