Skip to content

Rollup of 14 pull requests - #160948

Closed
JonathanBrouwer wants to merge 37 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-fyMZkZ4
Closed

Rollup of 14 pull requests#160948
JonathanBrouwer wants to merge 37 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-fyMZkZ4

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

mati865 and others added 30 commits August 6, 2026 11:47
This commit adjusts the changes made in 159733. A wasi-libc bug was
discovered in 160828 which is present in certain situations which means
that the changes in 159733 expose this bug. The purpose of this PR is
to get wasip1/wasip2 targets fixed again while preserving a working
implementation for wasip3. This upstream bug is already fixed in
wasi-libc meaning that this PR won't be necessary once wasi-sdk-34 is
published and used in rust-lang/rust. Until that time, however, this
effectively reverts 159733 for wasip1/wasip2. The wasip3 target is Tier
3 still and requires wasi-sdk-34 anyway which is why that's left
unchanged.

Closes 160828
the previous version, v0.5.0 (from 2018), does not include a
Cargo lockfile which makes the test brittle as bugs and unintentional
breaking changes in any new release of a dependency can make the test fail

the newly chosen version, v0.7.7, includes a Cargo lockfile
This is currently not really implemented, but partial support for it is
added in various places across the tree. This is a patch extracted from
the wider set of work to make review easier, which wires up:

* Unstable flag in rustc
* Bootstrap flag to enable using wasm-proc-macros (this needs an extra
  std compilation, wiring into compiletest)
* Partial compiletest support for the flag (mostly just CLI side of things)
Do not pass `-no-pie` on Windows

The warning can be seen with a simple example:
```
❯ cargo new /tmp/hello -q
❯ cargo rustc --target x86_64-pc-windows-gnullvm -q -- -C target-feature=+crt-static
warning: linker stderr: clang: argument unused during compilation: '-no-pie' [-Wunused-command-line-argument]
  |
  = note: `#[warn(linker_messages)]` on by default
```
…oboet

Arc: Remove unnecessary fmt::Display use for overflow assertion

- [x] I did not use an LLM to create a change in this PR.
- [ ] I used an LLM to create a change in this PR, and I have explained below how it was used.

This PR removes unnecessary `fmt::Display` generated assembly because of use of formatting in the overflow check assertion(`assert!(n <= MAX_REFCOUNT, "{}", INTERNAL_OVERFLOW_ERROR);`).

This reduces generated x64 assembly for counter increment(simplified) from:
```asm
increase_counter:
        test    rdi, rdi
        js      .LBB1_2
        inc     rdi
        mov     rax, rdi
        ret
.LBB1_2:
        sub     rsp, 24
        lea     rax, [rip + .Lanon.642d46026bcfa00bfed8baf8cdbf502d.2]
        mov     qword ptr [rsp + 8], rax
        lea     rax, [rip + <&str as core[4e7ceada952a6ea0]::fmt::Display>::fmt]
        mov     qword ptr [rsp + 16], rax
        lea     rdi, [rip + .Lanon.642d46026bcfa00bfed8baf8cdbf502d.0]
        lea     rdx, [rip + .Lanon.642d46026bcfa00bfed8baf8cdbf502d.4]
        lea     rsi, [rsp + 8]
        call    qword ptr [rip + core[4e7ceada952a6ea0]::panicking::panic_fmt@GOTPCREL]

.Lanon.642d46026bcfa00bfed8baf8cdbf502d.0:
        .asciz  "\300"

.Lanon.642d46026bcfa00bfed8baf8cdbf502d.1:
        .ascii  "Arc counter overflow"
```

To:
```asm
increase_counter:
        test    rdi, rdi
        js      .LBB0_2
        inc     rdi
        mov     rax, rdi
        ret
.LBB0_2:
        push    rax
        lea     rdi, [rip + .Lanon.642d46026bcfa00bfed8baf8cdbf502d.0]
        lea     rdx, [rip + .Lanon.642d46026bcfa00bfed8baf8cdbf502d.2]
        mov     esi, 41
        call    qword ptr [rip + core[4e7ceada952a6ea0]::panicking::panic_fmt@GOTPCREL]

.Lanon.642d46026bcfa00bfed8baf8cdbf502d.0:
        .ascii  "Arc counter overflow"
```

Godbolt link:
https://godbolt.org/z/3qjxooYWM

I expect bors to report a binary size reduction for all programs using Arc. There might also be performance improvements as a byproduct of CPU cache hit increase.
Miri: give the incremental session a chance to finish

This helps with rust-lang/miri#5013. Reruns still aren't as fast as I'd like, but using nextest to run libcore tests shows a big difference:
```
before:
 Nextest run ID 56b7b355-6225-4083-96e3-aeeabbe80523 with nextest profile: default-miri
    Starting 10 tests across 2 binaries (2760 tests skipped)
        PASS [  31.264s] coretests::coretests any::any_downcast_mut
        PASS [  31.287s] coretests::coretests any::distinct_type_names
        PASS [  32.747s] coretests::coretests iter::traits::iterator::test_any
        PASS [  32.758s] coretests::coretests any::any_owning
        PASS [  32.864s] coretests::coretests any::dyn_type_name
        PASS [  32.973s] coretests::coretests any::any_downcast_ref
        PASS [  33.139s] coretests::coretests any::any_unsized
        PASS [  33.719s] coretests::coretests any::any_referenced
        PASS [  35.786s] coretests::coretests any::any_fixed_vec
        PASS [  38.951s] coretests::coretests num::dec2flt::parse::many_digits
────────────
     Summary [  38.955s] 10 tests run: 10 passed, 2760 skipped

after:
 Nextest run ID af603971-e41e-466d-8469-0425057fa325 with nextest profile: default-miri
    Starting 10 tests across 2 binaries (2761 tests skipped)
        PASS [  15.063s] coretests::coretests any::any_unsized
        PASS [  15.176s] coretests::coretests any::distinct_type_names
        PASS [  15.200s] coretests::coretests any::any_referenced
        PASS [  15.550s] coretests::coretests iter::traits::iterator::test_any
        PASS [  15.993s] coretests::coretests any::any_fixed_vec
        PASS [  17.506s] coretests::coretests num::dec2flt::parse::many_digits
        PASS [  17.902s] coretests::coretests any::any_downcast_ref
        PASS [  18.188s] coretests::coretests any::any_owning
        PASS [  19.270s] coretests::coretests any::dyn_type_name
        PASS [  19.702s] coretests::coretests any::any_downcast_mut
────────────
     Summary [  19.705s] 10 tests run: 10 passed, 2761 skipped
```
It still seems to spend at least 10s building the crate before Miri even begins running, no idea what it is doing in that time. But it's 15s less than before so that's good. :)
…, r=bjorn3,jieyouxu

Add -Zwasm-proc-macros flag

This is currently not really implemented, but partial support for it is added in various places across the tree. This is a patch extracted from the wider set of work to make review easier, which wires up:

* Unstable flag in rustc
* Bootstrap flag to enable using wasm-proc-macros (this needs an extra std compilation, wiring into compiletest)
* Partial compiletest support for the flag (mostly just CLI side of things)
  * I suspect this will not work across all platforms but based on success with the full patch it should be enough for Linux, I think. I'd rather get them working on at least one platform and then iterate from there, unless we have clear ideas for improvements now.

cc rust-lang#160389 (tracking issue)
cc rust-lang#157590 (more complete implementation)

r? @bjorn3
…, r=clarfonthey

std: Adjust cfgs again for TLS on WASI

This commit adjusts the changes made in rust-lang#159733. A wasi-libc bug was discovered in rust-lang#160828 which is present in certain situations which means that the changes in rust-lang#159733 expose this bug. The purpose of this PR is to get wasip1/wasip2 targets fixed again while preserving a working implementation for wasip3. This upstream bug is already fixed in wasi-libc meaning that this PR won't be necessary once wasi-sdk-34 is published and used in rust-lang/rust. Until that time, however, this effectively reverts rust-lang#159733 for wasip1/wasip2. The wasip3 target is Tier 3 still and requires wasi-sdk-34 anyway which is why that's left unchanged.

Closes rust-lang#160828
rustc-book: update sys-v abi link

Upstream has moved to a new location and the current link is 6 years out of date. See https://github.com/hjl-tools/x86-psABI/
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. labels Aug 11, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-1,aarch64-apple-2,x86_64-mingw-1,i686-msvc-1,i686-msvc-2

@rust-bors

rust-bors Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 77ecff3 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026
@rust-bors

rust-bors Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

⌛ Trying commit 77ecff3 with merge 667bde5

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/31540209101

rust-bors Bot pushed a commit that referenced this pull request Aug 11, 2026
Rollup of 14 pull requests


try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-1
try-job: aarch64-apple-2
try-job: x86_64-mingw-1
try-job: i686-msvc-1
try-job: i686-msvc-2
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 11, 2026
…uwer

Rollup of 14 pull requests

Successful merges:

 - #160620 (Do not pass `-no-pie` on Windows)
 - #160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion)
 - #160760 (Miri: give the incremental session a chance to finish)
 - #160854 (Add -Zwasm-proc-macros flag)
 - #160868 (std: Adjust cfgs again for TLS on WASI)
 - #160894 (Allow running an arbitrary number of try jobs per PR)
 - #160790 (rustc-book: update sys-v abi link)
 - #160878 (Add rust_analyzer to check-cfg names)
 - #160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency)
 - #160920 (No longer mention the removed generic)
 - #160921 (rustdoc: Fix invalid CSS classes generated for notable items)
 - #160924 (split up `rustc_session`)
 - #160934 (Ensure TLS accesses don't call the global allocator through panic)
 - #160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job x86_64-msvc-ext2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
tests/pass-dep/shims/gettid.rs (revision `without_isolation`) ... ok
tests/pass-dep/libc/mmap.rs ... ok

FAILED TEST: tests/pass-dep/libc/libc-socket-no-blocking.rs (revision `windows_host`)
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\miri.exe" "--error-format=json" "-Dwarnings" "-Dunused" "-Ainternal_features" "-Zui-testing" "--sysroot=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\miri-sysroot" "--out-dir" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\tmp\\miri_ui\\0\\tests\\pass-dep\\libc" "tests/pass-dep\\libc\\libc-socket-no-blocking.rs" "-Zmiri-disable-isolation" "--extern" "cross_crate_items=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\cross-crate-items/7faa906f45515d3a\\out\\libcross_crate_items-7faa906f45515d3a.rlib" "--extern" "cross_crate_items=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\cross-crate-items/7faa906f45515d3a\\out\\libcross_crate_items-7faa906f45515d3a.rmeta" "--extern" "getrandom_01=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\getrandom/71c002d6493443f5\\out\\libgetrandom-71c002d6493443f5.rlib" "--extern" "getrandom_01=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\getrandom/71c002d6493443f5\\out\\libgetrandom-71c002d6493443f5.rmeta" "--extern" "getrandom_02=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\getrandom/88f16e240a5649c7\\out\\libgetrandom-88f16e240a5649c7.rlib" "--extern" "getrandom_02=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\getrandom/88f16e240a5649c7\\out\\libgetrandom-88f16e240a5649c7.rmeta" "--extern" "getrandom_03=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\getrandom/294796e45a99cfe8\\out\\libgetrandom-294796e45a99cfe8.rlib" "--extern" "getrandom_03=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\getrandom/294796e45a99cfe8\\out\\libgetrandom-294796e45a99cfe8.rmeta" "--extern" "libc=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\libc/f4151c7ca73df05d\\out\\liblibc-f4151c7ca73df05d.rlib" "--extern" "libc=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\libc/f4151c7ca73df05d\\out\\liblibc-f4151c7ca73df05d.rmeta" "--extern" "num_cpus=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\num_cpus/3cccb41672204ecb\\out\\libnum_cpus-3cccb41672204ecb.rlib" "--extern" "num_cpus=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\num_cpus/3cccb41672204ecb\\out\\libnum_cpus-3cccb41672204ecb.rmeta" "--extern" "futures=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\futures/9f43a5ece22b1625\\out\\libfutures-9f43a5ece22b1625.rlib" "--extern" "futures=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\futures/9f43a5ece22b1625\\out\\libfutures-9f43a5ece22b1625.rmeta" "--extern" "page_size=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\page_size/705cd4a871187f1b\\out\\libpage_size-705cd4a871187f1b.rlib" "--extern" "page_size=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\page_size/705cd4a871187f1b\\out\\libpage_size-705cd4a871187f1b.rmeta" "--extern" "tempfile=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\tempfile/de217547c8b5a64f\\out\\libtempfile-de217547c8b5a64f.rlib" "--extern" "tempfile=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\tempfile/de217547c8b5a64f\\out\\libtempfile-de217547c8b5a64f.rmeta" "--extern" "tokio=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\tokio/d922b17a9a619cbb\\out\\libtokio-d922b17a9a619cbb.rlib" "--extern" "tokio=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\tokio/d922b17a9a619cbb\\out\\libtokio-d922b17a9a619cbb.rmeta" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\pin-project-lite/6b41018a7602c3f3\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\page_size/705cd4a871187f1b\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\futures-channel/2b080fed1eadc629\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\futures-core/40b2762ae7b112c3\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\mio/7638b00d8cfe3dd5\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\getrandom/71c002d6493443f5\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\futures/9f43a5ece22b1625\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\debug\\build\\futures-macro/3b9633278040e509\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\futures-io/b52944cd2d3c25c0\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\rustix/d960084eb140f893\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\debug\\build\\tokio-macros/4ac8a51521a8af4f\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\signal-hook-registry/ce2cdd8e72d91d89\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\libc/f4151c7ca73df05d\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\fastrand/2207f1256bb56b37\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\getrandom/294796e45a99cfe8\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\futures-util/54999ce6f8657050\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\num_cpus/3cccb41672204ecb\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\cross-crate-items/7faa906f45515d3a\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\socket2/d6abacd07a96c939\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\bytes/45c5dd060f1aebcb\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\getrandom/e795907d3510ffa8\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\once_cell/1db7a000be30867f\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\tempfile/de217547c8b5a64f\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\bitflags/443cc8850b380f3c\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\errno/958e545f14f9e39b\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\cfg-if/d2cce47605fd3ccc\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\tokio/d922b17a9a619cbb\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\futures-task/074e16dc8ab88279\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\slab/3e35f95e60cabe09\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\getrandom/88f16e240a5649c7\\out" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-apple-darwin\\debug\\build\\futures-sink/af737b6acbbf3051\\out" "--edition" "2021" "--cfg=windows_host" "-Cextra-filename=windows_host" "--target" "x86_64-apple-darwin"

error: actual output differed from expected
Execute `./miri test --bless` to update `tests/pass-dep/libc/libc-socket-no-blocking.windows_host.stderr` to the actual output
--- tests/pass-dep/libc/libc-socket-no-blocking.windows_host.stderr
+++ <stderr output>
---
   |
LL |         libc::getsockname(client_sockfd, storage, len)
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Called `getsockname` on connecting socket
   |
   = note: Windows hosts do not provide `local_addr` information while the socket is still connecting, which might break the assumptions of code compiled for Unix targets
   = note: an unspecified socket address (e.g. `0.0.0.0:0`) will be returned instead
   = note: this is on thread `main`
   = note: stack backtrace:
           0: test_getsockname_ipv4_connect_nonblock::{closure#0}
               at tests/pass-dep\libc\libc-socket-no-blocking.rs:675:9: 675:55
           1: libc_utils::net::sockname::<{closure@tests/pass-dep\libc\libc-socket-no-blocking.rs:674:45: 674:59}>
               at tests/pass-dep\libc\..\..\utils\libc.rs:472:34: 472:74
           2: libc_utils::net::sockname_ipv4::<{closure@tests/pass-dep\libc\libc-socket-no-blocking.rs:674:45: 674:59}>
               at tests/pass-dep\libc\..\..\utils\libc.rs:437:30: 437:41
           3: test_getsockname_ipv4_connect_nonblock
               at tests/pass-dep\libc\libc-socket-no-blocking.rs:674:26: 676:7
           4: main
               at tests/pass-dep\libc\libc-socket-no-blocking.rs:57:5: 57:45

warning: 1 warning emitted
---
   |
LL |         libc::getsockname(client_sockfd, storage, len)
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Called `getsockname` on connecting socket
   |
   = note: Windows hosts do not provide `local_addr` information while the socket is still connecting, which might break the assumptions of code compiled for Unix targets
   = note: an unspecified socket address (e.g. `0.0.0.0:0`) will be returned instead
   = note: this is on thread `main`
   = note: stack backtrace:
           0: test_getsockname_ipv4_connect_nonblock::{closure#0}
               at tests/pass-dep\libc\libc-socket-no-blocking.rs:675:9: 675:55
           1: libc_utils::net::sockname::<{closure@tests/pass-dep\libc\libc-socket-no-blocking.rs:674:45: 674:59}>
               at tests/pass-dep\libc\..\..\utils\libc.rs:472:34: 472:74
           2: libc_utils::net::sockname_ipv4::<{closure@tests/pass-dep\libc\libc-socket-no-blocking.rs:674:45: 674:59}>
               at tests/pass-dep\libc\..\..\utils\libc.rs:437:30: 437:41
           3: test_getsockname_ipv4_connect_nonblock
               at tests/pass-dep\libc\libc-socket-no-blocking.rs:674:26: 676:7
           4: main
               at tests/pass-dep\libc\libc-socket-no-blocking.rs:57:5: 57:45

warning: 1 warning emitted
---

Location:
   C:\Users\runneradmin\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\ui_test-0.30.7\src\lib.rs:365

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
error: test failed, to rerun pass `--test ui`

Caused by:
  process didn't exit successfully: `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\build\miri/f9f9d02594f44fd6\out\ui-f9f9d02594f44fd6.exe pass` (exit code: 1)
Command `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin\cargo.exe test --target x86_64-pc-windows-msvc -Zbinary-dep-depinfo -j 4 -Zroot-dir=D:\a\rust\rust --locked --color=always --profile=release --manifest-path D:\a\rust\rust\src/tools/miri\Cargo.toml -- pass [workdir=D:\a\rust\rust]` failed with exit code 1
Created at: src\bootstrap\src\core\build_steps\tool.rs:197:21
Executed at: src\bootstrap\src\core\build_steps\test.rs:771:19

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test --stage 2 miri --target x86_64-apple-darwin --test-args pass`
Currently active steps:
test::Miri { target: x86_64-apple-darwin } at src\bootstrap\src\core\build_steps\test.rs:697
Build completed unsuccessfully in 1:24:49
  local time: Tue Aug 11 23:51:44 CUT 2026

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2026
@rust-bors

rust-bors Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 7b8bbff failed: CI. Failed job:

@jhpratt jhpratt closed this Aug 12, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 12, 2026
@rust-bors

rust-bors Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

PR #160760, which is a member of this rollup, was unapproved.

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 12, 2026
@rust-bors

rust-bors Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

💥 Test timed out after 21600s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.