Skip to content

Add MSA and f16 inline ASM support for MIPS - #160851

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
beetrees:f16-inline-asm-mips
Aug 29, 2026
Merged

Add MSA and f16 inline ASM support for MIPS#160851
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
beetrees:f16-inline-asm-mips

Conversation

@beetrees

@beetrees beetrees commented Aug 10, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

This PR adds vector register support for MIPS inline ASM when using the MSA extension (MSA specification), as well as adding support for the f16 type.

Ping target maintainers of MIPS targets: @Itus-Shield @Gelbpunkt @ayrtonm @LukasWoodtli @wzssyqa @chenx97 @709924470 @Cyanoxygen @Fearyncess

Tracking issues:
f16 inline ASM: #125398 (part of #116909)
MIPS inline ASM: #93335
MIPS target features: #150253

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 10, 2026
@rustbot

rustbot commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 18 candidates

@beetrees beetrees mentioned this pull request Aug 10, 2026
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@beetrees
beetrees force-pushed the f16-inline-asm-mips branch from ce8eb57 to 592a2ea Compare August 10, 2026 12:14
@rustbot

rustbot commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@beetrees
beetrees force-pushed the f16-inline-asm-mips branch from 592a2ea to f8f3913 Compare August 10, 2026 14:38
@folkertdev folkertdev mentioned this pull request Aug 11, 2026
Open
96 tasks
folkertdev
folkertdev requested changes Aug 12, 2026
View reviewed changes

@folkertdev folkertdev left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? me

Looks good overall, some small things. I'd like to hear from the target maintainers too.

View changes since this review

Comment thread compiler/rustc_target/src/asm/mips.rs Outdated
}
$(Self::$field)|* => {
cb(Self::$full);
cb(self);

@folkertdev folkertdev Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do? it seems to say that a register overlaps with itself?

@folkertdev folkertdev Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm apparently we're a bit inconsistent here, some of the macros do include the field itself, others don't seem to.

@beetrees beetrees Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having the cb(self) separate from the macro is more readable, so I've changed it to use that here.

Comment thread compiler/rustc_target/src/asm/mips.rs
Comment thread tests/assembly-llvm/asm/mips-types.rs
Comment thread tests/assembly-llvm/asm/mips-types.rs
@rustbot rustbot assigned folkertdev and unassigned JohnTitor Aug 12, 2026
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2026
@rustbot

rustbot commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@beetrees
beetrees force-pushed the f16-inline-asm-mips branch from f8f3913 to 5113ee9 Compare August 13, 2026 17:48
@beetrees

beetrees commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 13, 2026
@folkertdev folkertdev mentioned this pull request Aug 28, 2026
Open
Gelbpunkt
Gelbpunkt approved these changes Aug 28, 2026
View reviewed changes

@Gelbpunkt Gelbpunkt left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell from the MSA specification, this PR looks correct.

View changes since this review

folkertdev
folkertdev approved these changes Aug 29, 2026
View reviewed changes

@folkertdev folkertdev left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+

View changes since this review

Comment thread compiler/rustc_target/src/target_features.rs
const MIPS_FEATURES: &[(&str, Stability, ImpliedFeatures)] = &[
// tidy-alphabetical-start
("fp64", Unstable(sym::mips_target_feature), &[]),
// FIXME(#150253): msa requires either fp64 or no hard float support at all: LLVM requires fp64

@folkertdev folkertdev Aug 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And clang injects +fp64 when msa is enabled, though there is no implication in LLVM between fp64 and msa.

https://github.com/llvm/llvm-project/blob/d156987d1040717af8e09c21100cec04898ede72/clang/lib/Driver/ToolChains/Arch/Mips.cpp#L375-L378

  } else if (Arg *A = Args.getLastArg(options::OPT_mmsa)) {
    if (A->getOption().matches(options::OPT_mmsa))
      Features.push_back("+fp64");
  }

@rust-bors

rust-bors Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 5113ee9 has been approved by folkertdev

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 29, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Aug 29, 2026
@bors
Auto merge of #161979 - JonathanBrouwer:rollup-IymjmDu, r=JonathanBro…
bdf8733 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #160851 (Add MSA and `f16` inline ASM support for MIPS)
 - #161960 (std::sys::sgx::tls: fix TLS destructor pointer provenance)
 - #161976 (Improve rustdoc macro expansion code)
@rust-bors
rust-bors Bot merged commit 9dd88ff into rust-lang:main Aug 29, 2026
13 checks passed
rust-bors Bot pushed a commit that referenced this pull request Aug 29, 2026
@bors
Unrolled build for #160851 in rollup 161979
e087545 
Rollup merge of #160851 - beetrees:f16-inline-asm-mips, r=folkertdev

Add MSA and `f16` inline ASM support for MIPS

This PR adds vector register support for MIPS inline ASM when using the MSA extension ([MSA specification](https://s3-eu-west-1.amazonaws.com/downloads-mips/documents/MD00868-1D-MSA64-AFP-01.12.pdf)), as well as adding support for the `f16` type.

Ping target maintainers of MIPS targets: @Itus-Shield @Gelbpunkt @ayrtonm @LukasWoodtli @wzssyqa @chenx97 @709924470 @Cyanoxygen @Fearyncess

Tracking issues:
`f16` inline ASM: #125398 (part of #116909)
MIPS inline ASM: #93335
MIPS target features: #150253
@rustbot rustbot added this to the 1.100.0 milestone Aug 29, 2026
@beetrees
beetrees deleted the f16-inline-asm-mips branch August 29, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folkertdev folkertdev folkertdev approved these changes
+1 more reviewer
@Gelbpunkt Gelbpunkt Gelbpunkt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@folkertdev folkertdev

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

6 participants

@beetrees @rustbot @rust-log-analyzer @folkertdev @Gelbpunkt @JohnTitor