Rollup of 11 pull requests by jhpratt · Pull Request #160830 · rust-lang/rust

jhpratt · 2026-08-10T03:25:46Z

Successful merges:

bootstrap: Remove PATH_REMAP from command-line selector handling #160675 (bootstrap: Remove PATH_REMAP from command-line selector handling )
Update rustc crate rkyv to 0.8.18 #160807 (Update rustc crate rkyv to 0.8.18)
Clarify --remap-path-scope impact on rustc metadata #159690 (Clarify --remap-path-scope impact on rustc metadata)
Add nightly-only support for Cargo unremap trim-paths files in rust-gdb #160560 (Add nightly-only support for Cargo unremap trim-paths files in rust-gdb)
normalization rework: clean up projection_ty_core #160608 (normalization rework: clean up projection_ty_core)
Get rid of LLM disclosure checkboxes #160785 (Get rid of LLM disclosure checkboxes)
Change .expect message on net/parser to follow precondition style #160804 (Change .expect message on net/parser to follow precondition style)
extern "custom": add tests #160805 (extern "custom": add tests)
Mark const ptr methods and free functions as inline(always) to match *mut #160816 (Mark const ptr methods and free functions as inline(always) to match *mut)
Stabilize fs_set_times #160820 (Stabilize fs_set_times)
Rename parse_delimited_token_tree in cfg_select #160826 (Rename parse_delimited_token_tree in cfg_select)

When registering selector paths/aliases, steps shouldn't need to know their kind.

Remapping of "rust-analyzer-proc-macro-srv" can be avoided by registering it as an alias attached to the real path. Remapping of "test" is not necessary at all, since `./x test tests` naturally selects all of the test suites in `tests`.

These had a bunch of issues: - They're extra work every time someone opens a PR - They didn't show up at all if people used `gh pr create` - They had "bad vibes" -- reviewers often don't want to think about LLMs, and adding a checkbox makes them very "in-your-face" for the reviewer. - Every PR now shows "1 of 2 tasks", which is useless noise. - The hovered PR description is now useless. Replace them with an HTML comment that says "remember to disclose if you used an LLM". This seems ok and low-noise for now. If we find that people are ignoring the comment, we could edit the triagebot welcome message to include a reminder and a link to the policy.

This fixes RUSTSEC-2026-0233, RUSTSEC-2026-0234 and RUSTSEC-2026-0235.

Many <*const T> methods (read family, copy_to{,_nonoverlapping}, offset_from, len, as_ptr, get_unchecked), the ptr::{read,write,replace,swap,...} free functions, and the PartialEq/PartialOrd impls were left as inline while their <*mut T> equivalents are inline(always). This left them with out-of-line calls in debug codegen; make them consistent.

This stabilizes both functions under this feature gate: * `std::fs::set_times` * `std::fs::set_times_nofollow`

bootstrap: Remove `PATH_REMAP` from command-line selector handling Remapping of "rust-analyzer-proc-macro-srv" can be avoided by registering it as an alias attached to the real path. Remapping of "test" is not necessary at all, since `./x test tests` naturally selects all of the test suites in `tests`. (This changes the order of steps listed in the relevant snapshot tests, but the set of steps is unchanged.) --- The removal of `ShouldRun::kind` is not essential to this PR, but I included it because it would have conflicted with changes to ShouldRun's alias-related methods.

… r=Mark-Simulacrum Update rustc crate rkyv to 0.8.18 See https://rustsec.org/advisories/RUSTSEC-2026-0233 https://rustsec.org/advisories/RUSTSEC-2026-0234 https://rustsec.org/advisories/RUSTSEC-2026-0235

@weihanglo

…hanglo,ShoyuVanilla Clarify `--remap-path-scope` impact on `rustc` metadata This PR clarifirs the impact of the `--remap-path-scope` flag on `rustc` metadata. Fixes rust-lang#159621 r? compiler cc @weihanglo

…rk-Simulacrum Add nightly-only support for Cargo unremap trim-paths files in `rust-gdb` This PR adds support in `rust-gdb` for the un-remapping file produced by Cargo with `-Ztrim-paths` (rust-lang/cargo#17303). This support is nightly-only, and only activated when `RUST_GDB_TRIM_PATHS=unstable` is set. An example of the unremap file: ```json {"v":1} {"rust_version":"1.96.0-nightly","workspace_root":"/home/me/app"} {"from":"/cargo/build-dir","to":"/home/me/app/target"} {"from":"/cargo/registry/6f17d22d3f0a95d1","to":"/home/me/.cargo/registry/src/index.crates.io-6f17d22d3f0a95d1"} {"from":"/rustc/abc123","to":"/home/me/.rustup/toolchains/nightly/lib/rustlib/src/rust"} ```

…e, r=adwinwhite normalization rework: clean up projection_ty_core in rust-lang#160443 I was overly conservative in reworking how normalization works in projection_ty_core, because the PR was about other things. However, we can assume PlaceTy::ty is normalized (... I think). r? lcnr

@Kobzol

…acrum Get rid of LLM disclosure checkboxes These had a bunch of issues: - They're extra work every time someone opens a PR - They didn't show up at all if people used `gh pr create` - They had "bad vibes" -- reviewers often don't want to think about LLMs, and adding a checkbox makes them very "in-your-face" for the reviewer. - Every PR now shows "1 of 2 tasks", which is useless noise. - The hovered PR description is now useless. Replace them with an HTML comment that says "remember to disclose if you used an LLM". This seems ok and low-noise for now. If we find that people are ignoring the comment, we could edit the triagebot welcome message to include a reminder and a link to the policy (cc @Kobzol, i believe you'd planned to do this already).

…et-parser, r=clarfonthey Change .expect message on net/parser to follow precondition style

…s, r=tgross35 `extern "custom"`: add tests tracking issue: rust-lang#140829 r? tgross35

…60809, r=nia-e Mark const ptr methods and free functions as inline(always) to match *mut Closes rust-lang#160809. The `*const` read/read_volatile/read_unaligned methods were `#[inline]` while the `*mut` equivalents are `#[inline(always)]` and verified the `*const` forms now inline in debug instead of emitting an out of line call.

…s, r=nia-e Stabilize fs_set_times This stabilizes both functions under this feature gate: * `std::fs::set_times` * `std::fs::set_times_nofollow` This closes rust-lang#147455, which has a completed FCP for this: rust-lang#147455 (comment)

…t-parsing-fn, r=jieyouxu Rename parse_delimited_token_tree in cfg_select  - [x] I did not use an LLM to create a change in this PR. - [ ] I used an LLM to create a change in this PR, and I have explained below how it was used. From rust-lang#160303 (comment) The fn `parse_delimited_token_tree` only for parsing `cfg_select`.

jhpratt · 2026-08-10T03:26:05Z

@bors r+ p=5

@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-,x86_64-mingw-1,i686-msvc-

rust-bors · 2026-08-10T03:26:08Z

📌 Commit a3ce0af has been approved by jhpratt

It is now in the queue for this repository.

Rollup of 11 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-* try-job: x86_64-mingw-1 try-job: i686-msvc-*

rust-bors · 2026-08-10T06:27:37Z

☀️ Try build successful (CI)
Build commit: b15fb18 (b15fb1823972e38f72e803819cb1e486998cf332)
Base parent: 969b803 (969b803cbe1d4499f841ae0a49c637d8c70a0458)

rust-bors · 2026-08-10T09:29:19Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 3m 49s
Pushing 8a2fbe3 to main...

github-actions · 2026-08-10T09:31:55Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 811367e (parent) -> 8a2fbe3 (this PR)

Test differences

Show 306 test diffs

Stage 0

core::builder::cli_paths::tests::x_build_proc_macro_srv_cli: [missing] -> pass (J0)
core::builder::cli_paths::tests::x_build_rust_analyzer: [missing] -> pass (J0)
core::builder::cli_paths::tests::x_build_rust_analyzer_proc_macro_srv: [missing] -> pass (J0)
core::builder::cli_paths::tests::x_build_rust_analyzer_proc_macro_srv_plus_full_path: [missing] -> pass (J0)
core::builder::cli_paths::tests::x_build_src_tools_rust_analyzer: [missing] -> pass (J0)
core::builder::cli_paths::tests::x_build_src_tools_rust_analyzer_crates_proc_macro_srv_cli: [missing] -> pass (J0)
core::builder::tests::check_missing_paths_for_x_test_tests: pass -> [missing] (J0)
core::builder::tests::validate_path_remap: pass -> [missing] (J0)

Additionally, 298 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: aarch64-apple-2, aarch64-apple-macos-26-2, aarch64-gnu, aarch64-gnu-llvm-21-2, aarch64-msvc-2, i686-gnu-2, i686-gnu-nopt-2, i686-msvc-2, x86_64-gnu, x86_64-gnu-llvm-21-1, x86_64-gnu-llvm-21-3, x86_64-gnu-llvm-22-1, x86_64-gnu-llvm-22-3, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-2, x86_64-msvc-2

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8a2fbe3ea881ec68b9f06510fd1a1484cdf5bb6b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-gcc: 50m 25s -> 1h 16m (+51.1%)
x86_64-gnu-nopt: 2h 22m -> 1h 30m (-36.9%)
tidy: 1m 57s -> 2m 34s (+31.8%)
dist-sparcv9-solaris: 1h 14m -> 1h 38m (+31.5%)
i686-gnu-2: 1h 39m -> 1h 8m (-31.3%)
dist-x86_64-mingw: 1h 57m -> 2h 33m (+29.9%)
i686-gnu-nopt-1: 2h 16m -> 1h 36m (-29.3%)
x86_64-msvc-ext1: 2h 18m -> 1h 38m (-28.9%)
dist-powerpc64-linux-musl: 1h 11m -> 1h 31m (+28.5%)
x86_64-gnu-llvm-21: 41m 58s -> 53m 16s (+26.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-08-10T09:32:44Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#160675	bootstrap: Remove `PATH_REMAP` from command-line selector h…	`014ad777bd1eb64d585d90d790a666af454e9ec8` (link)
#160807	Update rustc crate rkyv to 0.8.18	`8cb6859f76592b6777eade0dbedd17513b137e21` (link)
#159690	Clarify `--remap-path-scope` impact on `rustc` metadata	`fe2e9728d711aa120fcf469524169fb6ae1d916e` (link)
#160560	Add nightly-only support for Cargo unremap trim-paths files…	`b60cae90dbf72c2ed7b5aa1acdcfa1107375309c` (link)
#160608	normalization rework: clean up projection_ty_core	`657e352e16e098b7bb03a0bdd5f83b56745483df` (link)
#160785	Get rid of LLM disclosure checkboxes	`fb387c13cc498c3d2f0ec82f1965a4bde392289d` (link)
#160804	Change .expect message on net/parser to follow precondition…	`fa9085df4325704e5735c5935608ab3f831f2999` (link)
#160805	`extern "custom"`: add tests	`c01b325572f76f65571d8a5daa8ec51d116567b1` (link)
#160816	Mark const ptr methods and free functions as inline(always)…	`5ebec241cbcf087d7639577d488015223395ab77` (link)
#160820	Stabilize fs_set_times	`b5193bf2163583a9903cfd0a7f0874eac93cbf25` (link)
#160826	Rename parse_delimited_token_tree in cfg_select	`7e9d2869dba8f610f4c02cd5fd02559b239a037a` (link)

previous master: 811367e98c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-08-10T10:12:33Z

Finished benchmarking commit (8a2fbe3): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-0.7%, -0.7%]	1

Max RSS (memory usage)

Results (primary 0.5%, secondary 1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.2%	[2.0%, 4.2%]	3
Regressions ❌ (secondary)	1.3%	[0.4%, 7.6%]	22
Improvements ✅ (primary)	-3.7%	[-4.7%, -2.6%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[-4.7%, 4.2%]	5

Cycles

Results (secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[0.4%, 7.2%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	[-1.4%, -0.4%]	10
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[-0.4%, 0.3%]	6

Bootstrap: 456.009s -> 454.914s (-0.24%)
Artifact size: 396.12 MiB -> 398.40 MiB (0.58%)

Urgau and others added 26 commits July 21, 2026 23:06

Clarify --remap-path-scope impact on rustc metadata

e97ad31

normalization rework: clean up projection_ty_core

52dff85

Snapshot tests for building rust-analyzer-proc-macro-srv

60d200b

Remove field ShouldRun::kind

767d4aa

When registering selector paths/aliases, steps shouldn't need to know their kind.

Add nightly-only support for Cargo unremap trim-paths files in rust-gdb

9755a34

update expect message in library/core/src/net/parser.rs

44afeee

extern custom: test type generics

265b95f

Update rustc crate rkyv to 0.8.18 [SECURITY]

7ee723b

This fixes RUSTSEC-2026-0233, RUSTSEC-2026-0234 and RUSTSEC-2026-0235.

generalize from 'code' to 'any part of this PR'

91f0930

extern custom: test explicit unit return type

da0920b

Stabilize fs_set_times

7253b2b

This stabilizes both functions under this feature gate: * `std::fs::set_times` * `std::fs::set_times_nofollow`

Rename parse_delimited_token_tree to parse_cfg_select_branch_rhs

41e53fa

Rollup merge of rust-lang#160807 - rperier:bump_rkyv_security_issues,…

6e8c73d

… r=Mark-Simulacrum Update rustc crate rkyv to 0.8.18 See https://rustsec.org/advisories/RUSTSEC-2026-0233 https://rustsec.org/advisories/RUSTSEC-2026-0234 https://rustsec.org/advisories/RUSTSEC-2026-0235

Rollup merge of rust-lang#159690 - Urgau:remap-object-metadata, r=wei…

28adab8

…hanglo,ShoyuVanilla Clarify `--remap-path-scope` impact on `rustc` metadata This PR clarifirs the impact of the `--remap-path-scope` flag on `rustc` metadata. Fixes rust-lang#159621 r? compiler cc @weihanglo

Rollup merge of rust-lang#160804 - nakagawa-hayana:issue-159751-fix-n…

5aa89e9

…et-parser, r=clarfonthey Change .expect message on net/parser to follow precondition style

Rollup merge of rust-lang#160805 - folkertdev:extern-custom-more-test…

b764577

…s, r=tgross35 `extern "custom"`: add tests tracking issue: rust-lang#140829 r? tgross35

rust-bors Bot added the rollup A PR which is a rollup label Aug 10, 2026

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 10, 2026

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 10, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 10, 2026

rust-bors Bot merged commit 8a2fbe3 into rust-lang:main Aug 10, 2026
15 checks passed

rustbot added this to the 1.99.0 milestone Aug 10, 2026

This was referenced Aug 10, 2026

Upgrade and deduplicate dependencies #160529

Open

Compiler and tools lock file update #160261

Open

more strongly suggest linking to tracking issues #158737

Closed

Stabilize extern "custom" #158504

Open

jhpratt deleted the rollup-IMvXhX3 branch August 10, 2026 09:32

Navigation Menu

Uh oh!

Uh oh!

Rollup of 11 pull requests - #160830

Rollup of 11 pull requests#160830
rust-bors[bot] merged 26 commits into
rust-lang:mainfrom
jhpratt:rollup-IMvXhX3

jhpratt commented Aug 10, 2026

Uh oh!

jhpratt commented Aug 10, 2026

Uh oh!

rust-bors Bot commented Aug 10, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 10, 2026

Uh oh!

rust-bors Bot commented Aug 10, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 10, 2026

Stage 0

Uh oh!

rust-timer commented Aug 10, 2026

Uh oh!

rust-timer commented Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Uh oh!

Uh oh!

Conversation

jhpratt commented Aug 10, 2026

Uh oh!

jhpratt commented Aug 10, 2026

Uh oh!

rust-bors Bot commented Aug 10, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 10, 2026

Uh oh!

rust-bors Bot commented Aug 10, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 10, 2026

Test differences

Stage 0

Job duration changes

Uh oh!

rust-timer commented Aug 10, 2026

Uh oh!

rust-timer commented Aug 10, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants