dedup fallback - #160487
Closed
LusterSourav wants to merge 5 commits into
Closed
Conversation
Hidden items aren't added to the map, which causes each parent path to re-enqueue the entire subtree. This led to exponential rustdoc hangs, as noted in issue rust-lang#160439.
The rmake.rs script now builds dep.rs and runs rustdoc with a 60-second kill watchdog, since compiletest doesn't have individual test timeouts. This allows regressions to fail quickly instead of causing CI to hang.
This includes a nested #[doc(hidden)] fan structure (B=8, D=12) in dep.rs, which is only reachable through hidden parents. The main.rs file implements dep::Tr to trigger the trait path rendering that caused the issue.
rustbot
added
A-run-make
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
This comment has been minimized.
This comment has been minimized.
Member
This comment has been minimized.
This comment has been minimized.
Author
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #160439 (comment)
bisect.log
issue_comment.md