Avoid resolving path keywords outside `TypeNS` by mu001999 · Pull Request #160444 · rust-lang/rust

mu001999 · 2026-08-03T14:35:27Z

After allowing trailing self, self imports were resolved in all namespaces wrongly. Resolving path keywords should return Determined immediately outside TypeNS.

r? petrochenkov

mu001999 · 2026-08-04T14:07:01Z

@rustbot ready

petrochenkov · 2026-08-04T16:48:15Z

@bors r+

rust-bors · 2026-08-04T16:48:18Z

📌 Commit e3464ab has been approved by petrochenkov

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: manually handling queue due to backlog

…rochenkov Avoid resolving path keywords outside `TypeNS` Fixes rust-lang#160195 After allowing trailing `self`, `self` imports were resolved in all namespaces wrongly. Resolving path keywords should return `Determined` immediately outside `TypeNS`. r? petrochenkov

…uwer Rollup of 22 pull requests Successful merges: - #158147 (std: fix stack buffer overflow in Windows junction_point) - #159784 (Hint that memchr returns an in-bounds index) - #160130 (Select cache values to verify by key fingerprint, not value fingerprint) - #160343 (Rename `OutlivesPredicate` to `OutlivesClause`) - #160360 (Remove rustc_middle dependency on rustc_hir_pretty) - #160387 (rustc_codegen_ssa: Correctly apply the static `--jobs-backend` limit to backend parallelism) - #160422 (move mir-opt miri tests to CI logic) - #160444 (Avoid resolving path keywords outside `TypeNS`) - #160510 (Resolver: (un)tracked borrows for `CmRefCell` made safe my unsafe speculative flag) - #155424 ([blocked] Link to proposed LLM policy in CONTRIBUTING and pull request template) - #158726 (std: move futex implementations into sys::sync::futex) - #159225 (Split IncrCompSession out of Session) - #159820 (Make the `rustc_unsafe_specialization_marker` attribute actually `unsafe`) - #160198 (Rework `smallest_range_containing` to handle duplicates) - #160362 (Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk`) - #160390 (autodiff: Handle slice-tailed DSTs in type trees) - #160420 (Suggest `cast_signed()` for overflowing signed integer literals) - #160520 (Add some tests for specialization) - #160522 (fix(bootstrap): Normalize the names of proc macro dependency crates) - #160531 (docs: fix typo in AllowExprMetavar comment) - #160538 (Update expect messages in tcp.rs doc examples to follow the style guide) - #160548 (bootstrap: Register `coverage-map` and `coverage-run` aliases via a separate step)

…rochenkov Avoid resolving path keywords outside `TypeNS` Fixes rust-lang#160195 After allowing trailing `self`, `self` imports were resolved in all namespaces wrongly. Resolving path keywords should return `Determined` immediately outside `TypeNS`. r? petrochenkov

…uwer Rollup of 25 pull requests Successful merges: - #154585 (treat no_mangle_generic_items as hard error instead of lint warning) - #158147 (std: fix stack buffer overflow in Windows junction_point) - #160130 (Select cache values to verify by key fingerprint, not value fingerprint) - #160343 (Rename `OutlivesPredicate` to `OutlivesClause`) - #160360 (Remove rustc_middle dependency on rustc_hir_pretty) - #160387 (rustc_codegen_ssa: Correctly apply the static `--jobs-backend` limit to backend parallelism) - #160422 (move mir-opt miri tests to CI logic) - #160444 (Avoid resolving path keywords outside `TypeNS`) - #160510 (Resolver: (un)tracked borrows for `CmRefCell` made safe my unsafe speculative flag) - #155424 ([blocked] Link to proposed LLM policy in CONTRIBUTING and pull request template) - #158726 (std: move futex implementations into sys::sync::futex) - #158762 (Emit thumb code on VEX V5) - #159225 (Split IncrCompSession out of Session) - #159820 (Make the `rustc_unsafe_specialization_marker` attribute actually `unsafe`) - #160198 (Rework `smallest_range_containing` to handle duplicates) - #160362 (Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk`) - #160390 (autodiff: Handle slice-tailed DSTs in type trees) - #160420 (Suggest `cast_signed()` for overflowing signed integer literals) - #160516 (Add regression test for HRTB projection in closure) - #160520 (Add some tests for specialization) - #160522 (fix(bootstrap): Normalize the names of proc macro dependency crates) - #160523 (Add regression test for opaque type) - #160531 (docs: fix typo in AllowExprMetavar comment) - #160538 (Update expect messages in tcp.rs doc examples to follow the style guide) - #160548 (bootstrap: Register `coverage-map` and `coverage-run` aliases via a separate step)

…uwer Rollup of 25 pull requests Successful merges: - #158147 (std: fix stack buffer overflow in Windows junction_point) - #160130 (Select cache values to verify by key fingerprint, not value fingerprint) - #160343 (Rename `OutlivesPredicate` to `OutlivesClause`) - #160360 (Remove rustc_middle dependency on rustc_hir_pretty) - #160387 (rustc_codegen_ssa: Correctly apply the static `--jobs-backend` limit to backend parallelism) - #160422 (move mir-opt miri tests to CI logic) - #160444 (Avoid resolving path keywords outside `TypeNS`) - #160510 (Resolver: (un)tracked borrows for `CmRefCell` made safe by unsafe speculative flag) - #155424 ([blocked] Link to proposed LLM policy in CONTRIBUTING and pull request template) - #158726 (std: move futex implementations into sys::sync::futex) - #158762 (Emit thumb code on VEX V5) - #159225 (Split IncrCompSession out of Session) - #159820 (Make the `rustc_unsafe_specialization_marker` attribute actually `unsafe`) - #160198 (Rework `smallest_range_containing` to handle duplicates) - #160362 (Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk`) - #160390 (autodiff: Handle slice-tailed DSTs in type trees) - #160420 (Suggest `cast_signed()` for overflowing signed integer literals) - #160501 (Add bootstrap CLI snapshot test for testing miri) - #160516 (Add regression test for HRTB projection in closure) - #160520 (Add some tests for specialization) - #160522 (fix(bootstrap): Normalize the names of proc macro dependency crates) - #160523 (Add regression test for opaque type) - #160531 (docs: fix typo in AllowExprMetavar comment) - #160538 (Update expect messages in tcp.rs doc examples to follow the style guide) - #160548 (bootstrap: Register `coverage-map` and `coverage-run` aliases via a separate step)

Rollup merge of #160444 - mu001999-contrib:fix-160195, r=petrochenkov Avoid resolving path keywords outside `TypeNS` Fixes #160195 After allowing trailing `self`, `self` imports were resolved in all namespaces wrongly. Resolving path keywords should return `Determined` immediately outside `TypeNS`. r? petrochenkov

JonathanBrouwer · 2026-08-06T20:14:45Z

@rust-timer build b45ce0c

JonathanBrouwer · 2026-08-07T08:00:33Z

^ All PRs in the rollup are getting this identical regression, this will most likely be a false positive

rust-timer · 2026-08-07T08:21:46Z

Finished benchmarking commit (b45ce0c): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.8%	[0.2%, 2.5%]	13
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.6%, -0.2%]	10
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.2%, secondary 24.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.8%, 1.8%]	1
Regressions ❌ (secondary)	24.9%	[1.2%, 30.6%]	13
Improvements ✅ (primary)	-4.3%	[-4.3%, -4.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.2%	[-4.3%, 1.8%]	2

Cycles

Results (secondary 11.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	16.3%	[3.6%, 31.5%]	15
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.6%	[-14.6%, -2.6%]	4
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	21
Regressions ❌ (secondary)	0.0%	[0.0%, 0.1%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.1%]	21

Bootstrap: 454.551s -> 457.036s (0.55%)
Artifact size: 399.93 MiB -> 399.12 MiB (-0.20%)

shirok1 · 2026-08-07T08:22:31Z

I saw "rustbot added this to the 1.99.0 milestone" so there won't be a 1.97.2 for this fix?

rustbot assigned petrochenkov Aug 3, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 3, 2026

petrochenkov reviewed Aug 3, 2026

View reviewed changes

Comment thread compiler/rustc_resolve/src/ident.rs Outdated

Comment thread compiler/rustc_resolve/src/ident.rs Outdated

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2026

mu001999 force-pushed the fix-160195 branch from 1eb8fef to d08cf8f Compare August 4, 2026 09:30

petrochenkov reviewed Aug 4, 2026

View reviewed changes

Comment thread compiler/rustc_resolve/src/ident.rs

mu001999 force-pushed the fix-160195 branch from d08cf8f to ee1aba8 Compare August 4, 2026 11:06

shirok1 reviewed Aug 4, 2026

View reviewed changes

Comment thread tests/ui/resolve/macro-determinacy-non-module-issue-160195.rs

Avoid resolving path keywords outside TypeNS

e3464ab

mu001999 force-pushed the fix-160195 branch from ee1aba8 to e3464ab Compare August 4, 2026 12:07

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2026

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 11 pull requests #160547

Closed

jhpratt mentioned this pull request Aug 5, 2026

Rollup of 16 pull requests #160549

Closed

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 22 pull requests #160554

Closed

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 25 pull requests #160557

Closed

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 25 pull requests #160559

Merged

rust-bors Bot merged commit 1966d4f into rust-lang:main Aug 5, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 5, 2026

This comment has been minimized.

Sign in to view

rustbot added the perf-regression Performance regression. label Aug 7, 2026

Navigation Menu

Uh oh!

Uh oh!

Avoid resolving path keywords outside `TypeNS` - #160444

Avoid resolving path keywords outside `TypeNS`#160444
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mu001999-contrib:fix-160195

mu001999 commented Aug 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mu001999 commented Aug 4, 2026

Uh oh!

petrochenkov commented Aug 4, 2026

Uh oh!

rust-bors Bot commented Aug 4, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Aug 6, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Aug 7, 2026

Uh oh!

rust-timer commented Aug 7, 2026

Uh oh!

shirok1 commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

mu001999 commented Aug 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mu001999 commented Aug 4, 2026

Uh oh!

petrochenkov commented Aug 4, 2026

Uh oh!

rust-bors Bot commented Aug 4, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Aug 6, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Aug 7, 2026

Uh oh!

rust-timer commented Aug 7, 2026

Overall result: ❌✅ regressions and improvements - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

shirok1 commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants