Bump thorin-dwp (0.10), gimli (0.33), and object (0.38.1) - #160318
Conversation
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. cc @davidtwco, @BoxyUwU These commits modify the If this was unintentional then you should revert the changes before this PR is merged. The run-make-support library was changed cc @jieyouxu |
rustbot
added
A-LLVM
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
the
T-compiler
|
cc @mejrs who reminded me of this. |
This comment has been minimized.
This comment has been minimized.
|
Ah, looks like bumping the deps of |
| let entry_depth = entry.depth; | ||
| let Some(child_entry) = cursor.next_dfs().unwrap() else { | ||
| panic!("Missing child of DW_TAG_variant"); | ||
| }; | ||
| assert_eq!(child_entry.depth, entry_depth + 1); |
There was a problem hiding this comment.
Changed
read::EntriesCursor::next_dfsto no longer return the depth delta. Useread::DebuggingInformationEntry::depthinstead.
rust-bors
Bot
added
S-waiting-on-bors
Bump thorin-dwp (0.10), gimli (0.33), and object (0.38.1)
Originally, the hope was that this would reduce duplication of `object` within the compiler.
In practice, it turns out that this merely bumps the object major-version-set from {0.36, 0.37} to {0.37, 0.38}.
(The holdout for object@0.37 is `ar_archive_writer`, which does have a newer release available. But that would end up pulling in object@0.39 instead.)
There is still an object@0.36 entry in Cargo.lock, but that comes via `ui_test` which is a dev-dependency for clippy and miri.
…uwer Rollup of 5 pull requests Successful merges: - #159195 (Drop elaboration: Only create a reset block if there are flags to reset.) - #160318 (Bump thorin-dwp (0.10), gimli (0.33), and object (0.38.1)) - #159756 (bootstrap: Move some shared source files into a new `shim_utils` crate) - #160385 (Assign ownership for Renovate configuration file) - #160397 (Box::new: fix safety comment)
Rollup merge of #160318 - Zalathar:thorin, r=Mark-Simulacrum Bump thorin-dwp (0.10), gimli (0.33), and object (0.38.1) Originally, the hope was that this would reduce duplication of `object` within the compiler. In practice, it turns out that this merely bumps the object major-version-set from {0.36, 0.37} to {0.37, 0.38}. (The holdout for object@0.37 is `ar_archive_writer`, which does have a newer release available. But that would end up pulling in object@0.39 instead.) There is still an object@0.36 entry in Cargo.lock, but that comes via `ui_test` which is a dev-dependency for clippy and miri.
|
Yeah, if we follow up by bumping The question in my mind is whether we try to bump other in-tree crates from 0.38 to 0.39 at the same time, or leave everything else as-is for now. |
|
I think we just need a release with rust-lang/thorin#53 to align on object 0.39, and with gimli 0.34 as well then we'd get everything on hashbrown 0.17. |
6 participants
Originally, the hope was that this would reduce duplication of
objectwithin the compiler.In practice, it turns out that this merely bumps the object major-version-set from {0.36, 0.37} to {0.37, 0.38}.
(The holdout for object@0.37 is
ar_archive_writer, which does have a newer release available. But that would end up pulling in object@0.39 instead.)There is still an object@0.36 entry in Cargo.lock, but that comes via
ui_testwhich is a dev-dependency for clippy and miri.