Apply str debugger visualizer to *const str, *mut str and Box<str> - #159834
Conversation
rustbot
added
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Does GDB also need to change or did it already do this? |
|
are the missing closing |
I think it does need the change, but the last time i tried to change more than 1 debugger at once i got told to split the PRs.
It's a quirk of how vscode displays multiline strings. Technically avoidable by using python to escape the strings, but that can make them harder to read in non-vscode contexts. 
|
rust-bors
Bot
added
S-waiting-on-bors
…uwer Rollup of 9 pull requests Successful merges: - #156935 (Introduce a `PinSafePointer` trait that generalizes `PinCoerceUnsized`) - #159834 (Apply str debugger visualizer to `*const str`, `*mut str` and `Box<str>`) - #160663 (Suggest add async for function sig with return expr in body) - #160732 (Optimize slice::contains for one-byte BytewiseEq types) - #157944 (Make `char::is_default_ignorable` unstably public) - #158835 (rustc_passes: lint unused `#[path]` attributes on inline modules) - #160754 (Rename more diagnostic files to `diagnostics.rs`) - #160755 (Merge `rustc_lint/lints.rs` into `diagnostics.rs`) - #160757 (Merge `rustc_attr_parsing/session_diagnostics.rs` into `diagnostics.rs`)
Rollup merge of #159834 - Walnut356:ptr_str, r=Mark-Simulacrum Apply str debugger visualizer to `*const str`, `*mut str` and `Box<str>` Fairly straightforward. Note that the MSVC changes very likely aren't exercised by CI. My GSoC project is actively working on fixing that, but in the meantime i can personally verify that it works (note that the `ref$<str$> *` type name confirms this is MSVC): <img width="318" height="138" alt="image" src="https://github.com/user-attachments/assets/fd868f16-d9a5-438a-a155-a429771bf525" />
(I was planning to take a look at this one but haven't gotten around to it, didn't have specific concerns) |
6 participants
Fairly straightforward. Note that the MSVC changes very likely aren't exercised by CI. My GSoC project is actively working on fixing that, but in the meantime i can personally verify that it works (note that the
ref$<str$> *type name confirms this is MSVC):