Skip to content

Implement some trait for next solver's lang item enums - #156297

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
ChayimFriedman2:lang-items-traits
May 9, 2026
Merged

Implement some trait for next solver's lang item enums#156297
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
ChayimFriedman2:lang-items-traits

Conversation

@ChayimFriedman2

Copy link
Copy Markdown
Contributor

rust-analyzer needs that.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 8, 2026
@rustbot

rustbot commented May 8, 2026

Copy link
Copy Markdown
Collaborator

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, types
  • compiler, types expanded to 73 candidates
  • Random selection from 19 candidates

@mejrs mejrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 6b5890b has been approved by mejrs

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 9, 2026
@rust-bors

rust-bors Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: mejrs
Duration: 3h 18m 48s
Pushing 4a997ee to main...

@rust-bors
rust-bors Bot merged commit 4a997ee into rust-lang:main May 9, 2026
12 checks passed
@rustbot rustbot added this to the 1.97.0 milestone May 9, 2026
@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing fb0a5a5 (parent) -> 4a997ee (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4a997eeefbb8cf41617324bb6d08c72171c614e2 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-llvm-22-2: 1h 43m -> 1h 17m (-25.4%)
  2. i686-gnu-nopt-2: 2h 19m -> 1h 45m (-24.5%)
  3. optional-x86_64-gnu-parallel-frontend: 2h 13m -> 2h 45m (+23.9%)
  4. x86_64-gnu-aux: 2h 19m -> 1h 47m (-23.2%)
  5. dist-x86_64-mingw: 2h 36m -> 2h 1m (-22.5%)
  6. i686-msvc-1: 2h 21m -> 2h 51m (+21.6%)
  7. dist-i586-gnu-i586-i686-musl: 1h 14m -> 1h 27m (+17.1%)
  8. x86_64-gnu-llvm-21-2: 1h 30m -> 1h 17m (-14.9%)
  9. x86_64-gnu-llvm-21: 1h 12m -> 1h 21m (+13.0%)
  10. dist-x86_64-apple: 1h 56m -> 1h 42m (-12.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (4a997ee): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.0%, 2.4%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.2% [3.6%, 4.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.1% [-3.1%, -3.1%] 1
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 497.93s -> 497.359s (-0.11%)
Artifact size: 397.14 MiB -> 397.13 MiB (-0.00%)

@ChayimFriedman2
ChayimFriedman2 deleted the lang-items-traits branch May 9, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants