Skip to content

Add Copy to some AST enums.#149341

Merged
bors merged 1 commit intorust-lang:mainfrom
Jarcho:ast_copy
Nov 26, 2025
Merged

Add Copy to some AST enums.#149341
bors merged 1 commit intorust-lang:mainfrom
Jarcho:ast_copy

Conversation

@Jarcho
Copy link
Copy Markdown
Contributor

@Jarcho Jarcho commented Nov 26, 2025

It's a minor annoyance they aren't Copy and there doesn't seem to be any reason for them not to be.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 26, 2025
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Nov 26, 2025

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@chenyukang
Copy link
Copy Markdown
Member

chenyukang commented Nov 26, 2025

@bors r=chenyukang

@bors
Copy link
Copy Markdown
Collaborator

bors commented Nov 26, 2025

📌 Commit c87bebd has been approved by chenyukang

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 26, 2025
@jhpratt
Rollup merge of rust-lang#149341 - Jarcho:ast_copy, r=chenyukang
7fb0a40 
Add `Copy` to some AST enums.

It's a minor annoyance they aren't `Copy` and there doesn't seem to be any reason for them not to be.
@jhpratt jhpratt mentioned this pull request Nov 26, 2025
Closed
bors added a commit that referenced this pull request Nov 26, 2025
@bors
Auto merge of #149342 - jhpratt:rollup-03e84ll, r=jhpratt
3314b7c 
Rollup of 9 pull requests

Successful merges:

 - #147936 (Offload intrinsic)
 - #148358 (Fix some issues around `rustc_public`)
 - #148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors)
 - #148751 (Build gnullvm toolchains on Windows natively)
 - #148951 (rustc_target: aarch64: Remove deprecated FEAT_TME)
 - #149173 (Use rust rather than LLVM target features in the target spec)
 - #149307 (Deny const auto traits)
 - #149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target)
 - #149341 (Add `Copy` to some AST enums.)

r? `@ghost`
`@rustbot` modify labels: rollup
@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Nov 26, 2025

It's a minor annoyance they aren't Copy and there doesn't seem to be any reason for them not to be.

I'm sorry, but can you explain why they need to be Copy? Is there specific case or something for it?

@Zalathar Zalathar mentioned this pull request Nov 26, 2025
Merged
bors added a commit that referenced this pull request Nov 26, 2025
@bors
Auto merge of #149351 - Zalathar:rollup-ee06zha, r=Zalathar
99ca3fc 
Rollup of 12 pull requests

Successful merges:

 - #147936 (Offload intrinsic)
 - #148358 (Fix some issues around `rustc_public`)
 - #148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors)
 - #148751 (Build gnullvm toolchains on Windows natively)
 - #148951 (rustc_target: aarch64: Remove deprecated FEAT_TME)
 - #149149 ([rustdoc] misc search index cleanups)
 - #149173 (Use rust rather than LLVM target features in the target spec)
 - #149307 (Deny const auto traits)
 - #149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target)
 - #149317 (Handle inline asm in has_ffi_unwind_calls)
 - #149326 (Remove unused `Clone` derive on `DelayedLint`)
 - #149341 (Add `Copy` to some AST enums.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4a05348 into rust-lang:main Nov 26, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Nov 26, 2025
@rust-timer
Unrolled build for #149341
438ce38 
Rollup merge of #149341 - Jarcho:ast_copy, r=chenyukang

Add `Copy` to some AST enums.

It's a minor annoyance they aren't `Copy` and there doesn't seem to be any reason for them not to be.
@rustbot rustbot added this to the 1.93.0 milestone Nov 26, 2025
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Nov 27, 2025
@bors
Auto merge of #149351 - Zalathar:rollup-ee06zha, r=Zalathar
6174b1a 
Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#147936 (Offload intrinsic)
 - rust-lang/rust#148358 (Fix some issues around `rustc_public`)
 - rust-lang/rust#148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors)
 - rust-lang/rust#148751 (Build gnullvm toolchains on Windows natively)
 - rust-lang/rust#148951 (rustc_target: aarch64: Remove deprecated FEAT_TME)
 - rust-lang/rust#149149 ([rustdoc] misc search index cleanups)
 - rust-lang/rust#149173 (Use rust rather than LLVM target features in the target spec)
 - rust-lang/rust#149307 (Deny const auto traits)
 - rust-lang/rust#149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target)
 - rust-lang/rust#149317 (Handle inline asm in has_ffi_unwind_calls)
 - rust-lang/rust#149326 (Remove unused `Clone` derive on `DelayedLint`)
 - rust-lang/rust#149341 (Add `Copy` to some AST enums.)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Dec 10, 2025
@bors
Auto merge of #149351 - Zalathar:rollup-ee06zha, r=Zalathar
1a93fe8 
Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#147936 (Offload intrinsic)
 - rust-lang/rust#148358 (Fix some issues around `rustc_public`)
 - rust-lang/rust#148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors)
 - rust-lang/rust#148751 (Build gnullvm toolchains on Windows natively)
 - rust-lang/rust#148951 (rustc_target: aarch64: Remove deprecated FEAT_TME)
 - rust-lang/rust#149149 ([rustdoc] misc search index cleanups)
 - rust-lang/rust#149173 (Use rust rather than LLVM target features in the target spec)
 - rust-lang/rust#149307 (Deny const auto traits)
 - rust-lang/rust#149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target)
 - rust-lang/rust#149317 (Handle inline asm in has_ffi_unwind_calls)
 - rust-lang/rust#149326 (Remove unused `Clone` derive on `DelayedLint`)
 - rust-lang/rust#149341 (Add `Copy` to some AST enums.)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Dec 10, 2025
@Zalathar
Rollup merge of rust-lang#149341 - Jarcho:ast_copy, r=chenyukang
2065393 
Add `Copy` to some AST enums.

It's a minor annoyance they aren't `Copy` and there doesn't seem to be any reason for them not to be.
makai410 pushed a commit to makai410/rust that referenced this pull request Dec 10, 2025
@bors
Auto merge of rust-lang#149351 - Zalathar:rollup-ee06zha, r=Zalathar
d6ff760 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#147936 (Offload intrinsic)
 - rust-lang#148358 (Fix some issues around `rustc_public`)
 - rust-lang#148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors)
 - rust-lang#148751 (Build gnullvm toolchains on Windows natively)
 - rust-lang#148951 (rustc_target: aarch64: Remove deprecated FEAT_TME)
 - rust-lang#149149 ([rustdoc] misc search index cleanups)
 - rust-lang#149173 (Use rust rather than LLVM target features in the target spec)
 - rust-lang#149307 (Deny const auto traits)
 - rust-lang#149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target)
 - rust-lang#149317 (Handle inline asm in has_ffi_unwind_calls)
 - rust-lang#149326 (Remove unused `Clone` derive on `DelayedLint`)
 - rust-lang#149341 (Add `Copy` to some AST enums.)

r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #149351 - Zalathar:rollup-ee06zha, r=Zalathar
1e3129f 
Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#147936 (Offload intrinsic)
 - rust-lang/rust#148358 (Fix some issues around `rustc_public`)
 - rust-lang/rust#148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors)
 - rust-lang/rust#148751 (Build gnullvm toolchains on Windows natively)
 - rust-lang/rust#148951 (rustc_target: aarch64: Remove deprecated FEAT_TME)
 - rust-lang/rust#149149 ([rustdoc] misc search index cleanups)
 - rust-lang/rust#149173 (Use rust rather than LLVM target features in the target spec)
 - rust-lang/rust#149307 (Deny const auto traits)
 - rust-lang/rust#149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target)
 - rust-lang/rust#149317 (Handle inline asm in has_ffi_unwind_calls)
 - rust-lang/rust#149326 (Remove unused `Clone` derive on `DelayedLint`)
 - rust-lang/rust#149341 (Add `Copy` to some AST enums.)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Mar 19, 2026
@bors
Auto merge of #149351 - Zalathar:rollup-ee06zha, r=Zalathar
971e979 
Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#147936 (Offload intrinsic)
 - rust-lang/rust#148358 (Fix some issues around `rustc_public`)
 - rust-lang/rust#148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors)
 - rust-lang/rust#148751 (Build gnullvm toolchains on Windows natively)
 - rust-lang/rust#148951 (rustc_target: aarch64: Remove deprecated FEAT_TME)
 - rust-lang/rust#149149 ([rustdoc] misc search index cleanups)
 - rust-lang/rust#149173 (Use rust rather than LLVM target features in the target spec)
 - rust-lang/rust#149307 (Deny const auto traits)
 - rust-lang/rust#149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target)
 - rust-lang/rust#149317 (Handle inline asm in has_ffi_unwind_calls)
 - rust-lang/rust#149326 (Remove unused `Clone` derive on `DelayedLint`)
 - rust-lang/rust#149341 (Add `Copy` to some AST enums.)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Mar 27, 2026
@bors
Auto merge of #149351 - Zalathar:rollup-ee06zha, r=Zalathar
7e72b8d 
Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#147936 (Offload intrinsic)
 - rust-lang/rust#148358 (Fix some issues around `rustc_public`)
 - rust-lang/rust#148452 (Mangle symbols with a mangled name close to PDB limits with v0 instead of legacy mangling to avoid linker errors)
 - rust-lang/rust#148751 (Build gnullvm toolchains on Windows natively)
 - rust-lang/rust#148951 (rustc_target: aarch64: Remove deprecated FEAT_TME)
 - rust-lang/rust#149149 ([rustdoc] misc search index cleanups)
 - rust-lang/rust#149173 (Use rust rather than LLVM target features in the target spec)
 - rust-lang/rust#149307 (Deny const auto traits)
 - rust-lang/rust#149312 (Mark riscv64gc-unknown-linux-musl as tier 2 target)
 - rust-lang/rust#149317 (Handle inline asm in has_ffi_unwind_calls)
 - rust-lang/rust#149326 (Remove unused `Clone` derive on `DelayedLint`)
 - rust-lang/rust#149341 (Add `Copy` to some AST enums.)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@chenyukang chenyukang

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Jarcho @rustbot @chenyukang @bors @Kivooeo