Consolidate stage directories and group logs in bootstrap - #145295
Conversation
Now stageN-X corresponds to stage N X, as it should.
jieyouxu
left a comment
There was a problem hiding this comment.
Looks good, tiny nits, r=me after.
|
@rustbot author |
|
Resolved review remarks. I would bump the priority of this, because it will be very conflict-prone with anything done in bootstrap. |
|
@bors r+ rollup=5 (conflicts with other bootstrap work, conflict-prone) |
|
Aaa |
Consolidate stage directories and group logs in bootstrap My post-stage-0-redesign bootstrap fixes aren't done yet, but I think that enough steps have been migrated to the new system that it makes sense to actually modify the directories on disk, and what gets printed when bootstrap runs, so that it actually corresponds to the new system. Before, the printed stages didn't always make sense. This PR: - Fixes the numbering of `stageN` directories in the build directory. It was not corresponding to the correct stages before; notice that I did not modify `bootstrap/README.md`, as it was essentially describing what happens after this PR (first commit). - Unifies all steps that output a build group to use the `Builder::msg` method. It's probably not the final stage, and some of the test steps might not be fully accurate yet, because I didn't fix test step numbering yet, but I think that it's a clear improvement from before, and now that everything uses the same method, we can easily make changes across the board, to ensure that it stays unified (second commit). r? `@jieyouxu`
|
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Consolidate stage directories and group logs in bootstrap try-job: dist-x86_64-msvc try-job: dist-x86_64-linux
|
Fixes CI failure. @bors r=jieyouxu |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 8e62bfd (parent) -> 1553adf (this PR) Test differencesShow 4 test diffs4 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1553adfe6884a8f6c28f5a673d3e605535ee0113 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (1553adf): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 3.6%, secondary -3.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 465.671s -> 464.093s (-0.34%) |
…est, r=petrochenkov Add test for parallel compiler reproducible build Adds a test for reproducible binaries when using parallel compiler. Confirmed with bisection and manual testing that rust-lang#144722 fixed rust-lang#140413, added test fails before commit (075ce31) from rust-lang#144722. ```rust ******************************************************************************** Regression in nightly-2025-08-14 ******************************************************************************** fetching https://static.rust-lang.org/dist/2025-08-13/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-13: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 357.18 KB/s converted 2025-08-13 to 8e62bfd fetching https://static.rust-lang.org/dist/2025-08-14/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-14: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 123.86 KB/s converted 2025-08-14 to 3672a55 looking for regression commit between 2025-08-13 and 2025-08-14 fetching (via remote github) commits from max(8e62bfd, 2025-08-11) to 3672a55 ending github query because we found starting sha: 8e62bfd get_commits_between returning commits, len: 7 commit[0] 2025-08-12: Auto merge of rust-lang#144678 - jdonszelmann:no-mangle-extern, r=bjorn3 commit[1] 2025-08-12: Auto merge of rust-lang#145295 - Kobzol:unify-stages, r=jieyouxu commit[2] 2025-08-13: Auto merge of rust-lang#145093 - nikic:dead-on-return, r=nnethercote commit[3] 2025-08-13: Auto merge of rust-lang#145334 - Kobzol:rollup-fs5a133, r=Kobzol commit[4] 2025-08-13: Auto merge of rust-lang#144722 - ywxt:parallel-reproducibile, r=SparrowLii commit[5] 2025-08-13: Auto merge of rust-lang#145298 - nikic:llvm21-rc3, r=cuviper commit[6] 2025-08-13: Auto merge of rust-lang#145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez ``` Fixes rust-lang#140413. r? @petrochenkov
…est, r=petrochenkov Add test for parallel compiler reproducible build Adds a test for reproducible binaries when using parallel compiler. Confirmed with bisection and manual testing that rust-lang#144722 fixed rust-lang#140413, added test fails before commit (075ce31) from rust-lang#144722. ```rust ******************************************************************************** Regression in nightly-2025-08-14 ******************************************************************************** fetching https://static.rust-lang.org/dist/2025-08-13/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-13: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 357.18 KB/s converted 2025-08-13 to 8e62bfd fetching https://static.rust-lang.org/dist/2025-08-14/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-14: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 123.86 KB/s converted 2025-08-14 to 3672a55 looking for regression commit between 2025-08-13 and 2025-08-14 fetching (via remote github) commits from max(8e62bfd, 2025-08-11) to 3672a55 ending github query because we found starting sha: 8e62bfd get_commits_between returning commits, len: 7 commit[0] 2025-08-12: Auto merge of rust-lang#144678 - jdonszelmann:no-mangle-extern, r=bjorn3 commit[1] 2025-08-12: Auto merge of rust-lang#145295 - Kobzol:unify-stages, r=jieyouxu commit[2] 2025-08-13: Auto merge of rust-lang#145093 - nikic:dead-on-return, r=nnethercote commit[3] 2025-08-13: Auto merge of rust-lang#145334 - Kobzol:rollup-fs5a133, r=Kobzol commit[4] 2025-08-13: Auto merge of rust-lang#144722 - ywxt:parallel-reproducibile, r=SparrowLii commit[5] 2025-08-13: Auto merge of rust-lang#145298 - nikic:llvm21-rc3, r=cuviper commit[6] 2025-08-13: Auto merge of rust-lang#145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez ``` Fixes rust-lang#140413. r? @petrochenkov
…est, r=petrochenkov Add test for parallel compiler reproducible build Adds a test for reproducible binaries when using parallel compiler. Confirmed with bisection and manual testing that rust-lang#144722 fixed rust-lang#140413, added test fails before commit (075ce31) from rust-lang#144722. ```rust ******************************************************************************** Regression in nightly-2025-08-14 ******************************************************************************** fetching https://static.rust-lang.org/dist/2025-08-13/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-13: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 357.18 KB/s converted 2025-08-13 to 8e62bfd fetching https://static.rust-lang.org/dist/2025-08-14/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-14: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 123.86 KB/s converted 2025-08-14 to 3672a55 looking for regression commit between 2025-08-13 and 2025-08-14 fetching (via remote github) commits from max(8e62bfd, 2025-08-11) to 3672a55 ending github query because we found starting sha: 8e62bfd get_commits_between returning commits, len: 7 commit[0] 2025-08-12: Auto merge of rust-lang#144678 - jdonszelmann:no-mangle-extern, r=bjorn3 commit[1] 2025-08-12: Auto merge of rust-lang#145295 - Kobzol:unify-stages, r=jieyouxu commit[2] 2025-08-13: Auto merge of rust-lang#145093 - nikic:dead-on-return, r=nnethercote commit[3] 2025-08-13: Auto merge of rust-lang#145334 - Kobzol:rollup-fs5a133, r=Kobzol commit[4] 2025-08-13: Auto merge of rust-lang#144722 - ywxt:parallel-reproducibile, r=SparrowLii commit[5] 2025-08-13: Auto merge of rust-lang#145298 - nikic:llvm21-rc3, r=cuviper commit[6] 2025-08-13: Auto merge of rust-lang#145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez ``` Fixes rust-lang#140413. r? @petrochenkov
…est, r=petrochenkov Add test for parallel compiler reproducible build Adds a test for reproducible binaries when using parallel compiler. Confirmed with bisection and manual testing that rust-lang#144722 fixed rust-lang#140413, added test fails before commit (075ce31) from rust-lang#144722. ```rust ******************************************************************************** Regression in nightly-2025-08-14 ******************************************************************************** fetching https://static.rust-lang.org/dist/2025-08-13/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-13: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 357.18 KB/s converted 2025-08-13 to 8e62bfd fetching https://static.rust-lang.org/dist/2025-08-14/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-14: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 123.86 KB/s converted 2025-08-14 to 3672a55 looking for regression commit between 2025-08-13 and 2025-08-14 fetching (via remote github) commits from max(8e62bfd, 2025-08-11) to 3672a55 ending github query because we found starting sha: 8e62bfd get_commits_between returning commits, len: 7 commit[0] 2025-08-12: Auto merge of rust-lang#144678 - jdonszelmann:no-mangle-extern, r=bjorn3 commit[1] 2025-08-12: Auto merge of rust-lang#145295 - Kobzol:unify-stages, r=jieyouxu commit[2] 2025-08-13: Auto merge of rust-lang#145093 - nikic:dead-on-return, r=nnethercote commit[3] 2025-08-13: Auto merge of rust-lang#145334 - Kobzol:rollup-fs5a133, r=Kobzol commit[4] 2025-08-13: Auto merge of rust-lang#144722 - ywxt:parallel-reproducibile, r=SparrowLii commit[5] 2025-08-13: Auto merge of rust-lang#145298 - nikic:llvm21-rc3, r=cuviper commit[6] 2025-08-13: Auto merge of rust-lang#145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez ``` Fixes rust-lang#140413. r? @petrochenkov
…est, r=petrochenkov Add test for parallel compiler reproducible build Adds a test for reproducible binaries when using parallel compiler. Confirmed with bisection and manual testing that rust-lang#144722 fixed rust-lang#140413, added test fails before commit (075ce31) from rust-lang#144722. ```rust ******************************************************************************** Regression in nightly-2025-08-14 ******************************************************************************** fetching https://static.rust-lang.org/dist/2025-08-13/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-13: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 357.18 KB/s converted 2025-08-13 to 8e62bfd fetching https://static.rust-lang.org/dist/2025-08-14/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-14: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 123.86 KB/s converted 2025-08-14 to 3672a55 looking for regression commit between 2025-08-13 and 2025-08-14 fetching (via remote github) commits from max(8e62bfd, 2025-08-11) to 3672a55 ending github query because we found starting sha: 8e62bfd get_commits_between returning commits, len: 7 commit[0] 2025-08-12: Auto merge of rust-lang#144678 - jdonszelmann:no-mangle-extern, r=bjorn3 commit[1] 2025-08-12: Auto merge of rust-lang#145295 - Kobzol:unify-stages, r=jieyouxu commit[2] 2025-08-13: Auto merge of rust-lang#145093 - nikic:dead-on-return, r=nnethercote commit[3] 2025-08-13: Auto merge of rust-lang#145334 - Kobzol:rollup-fs5a133, r=Kobzol commit[4] 2025-08-13: Auto merge of rust-lang#144722 - ywxt:parallel-reproducibile, r=SparrowLii commit[5] 2025-08-13: Auto merge of rust-lang#145298 - nikic:llvm21-rc3, r=cuviper commit[6] 2025-08-13: Auto merge of rust-lang#145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez ``` Fixes rust-lang#140413. r? @petrochenkov
…est, r=petrochenkov Add test for parallel compiler reproducible build Adds a test for reproducible binaries when using parallel compiler. Confirmed with bisection and manual testing that rust-lang#144722 fixed rust-lang#140413, added test fails before commit (075ce31) from rust-lang#144722. ```rust ******************************************************************************** Regression in nightly-2025-08-14 ******************************************************************************** fetching https://static.rust-lang.org/dist/2025-08-13/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-13: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 357.18 KB/s converted 2025-08-13 to 8e62bfd fetching https://static.rust-lang.org/dist/2025-08-14/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-14: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 123.86 KB/s converted 2025-08-14 to 3672a55 looking for regression commit between 2025-08-13 and 2025-08-14 fetching (via remote github) commits from max(8e62bfd, 2025-08-11) to 3672a55 ending github query because we found starting sha: 8e62bfd get_commits_between returning commits, len: 7 commit[0] 2025-08-12: Auto merge of rust-lang#144678 - jdonszelmann:no-mangle-extern, r=bjorn3 commit[1] 2025-08-12: Auto merge of rust-lang#145295 - Kobzol:unify-stages, r=jieyouxu commit[2] 2025-08-13: Auto merge of rust-lang#145093 - nikic:dead-on-return, r=nnethercote commit[3] 2025-08-13: Auto merge of rust-lang#145334 - Kobzol:rollup-fs5a133, r=Kobzol commit[4] 2025-08-13: Auto merge of rust-lang#144722 - ywxt:parallel-reproducibile, r=SparrowLii commit[5] 2025-08-13: Auto merge of rust-lang#145298 - nikic:llvm21-rc3, r=cuviper commit[6] 2025-08-13: Auto merge of rust-lang#145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez ``` Fixes rust-lang#140413. r? @petrochenkov
…est, r=petrochenkov Add test for parallel compiler reproducible build Adds a test for reproducible binaries when using parallel compiler. Confirmed with bisection and manual testing that rust-lang#144722 fixed rust-lang#140413, added test fails before commit (075ce31) from rust-lang#144722. ```rust ******************************************************************************** Regression in nightly-2025-08-14 ******************************************************************************** fetching https://static.rust-lang.org/dist/2025-08-13/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-13: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 357.18 KB/s converted 2025-08-13 to 8e62bfd fetching https://static.rust-lang.org/dist/2025-08-14/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-14: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 123.86 KB/s converted 2025-08-14 to 3672a55 looking for regression commit between 2025-08-13 and 2025-08-14 fetching (via remote github) commits from max(8e62bfd, 2025-08-11) to 3672a55 ending github query because we found starting sha: 8e62bfd get_commits_between returning commits, len: 7 commit[0] 2025-08-12: Auto merge of rust-lang#144678 - jdonszelmann:no-mangle-extern, r=bjorn3 commit[1] 2025-08-12: Auto merge of rust-lang#145295 - Kobzol:unify-stages, r=jieyouxu commit[2] 2025-08-13: Auto merge of rust-lang#145093 - nikic:dead-on-return, r=nnethercote commit[3] 2025-08-13: Auto merge of rust-lang#145334 - Kobzol:rollup-fs5a133, r=Kobzol commit[4] 2025-08-13: Auto merge of rust-lang#144722 - ywxt:parallel-reproducibile, r=SparrowLii commit[5] 2025-08-13: Auto merge of rust-lang#145298 - nikic:llvm21-rc3, r=cuviper commit[6] 2025-08-13: Auto merge of rust-lang#145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez ``` Fixes rust-lang#140413. r? @petrochenkov
…est, r=petrochenkov Add test for parallel compiler reproducible build Adds a test for reproducible binaries when using parallel compiler. Confirmed with bisection and manual testing that rust-lang#144722 fixed rust-lang#140413, added test fails before commit (075ce31) from rust-lang#144722. ```rust ******************************************************************************** Regression in nightly-2025-08-14 ******************************************************************************** fetching https://static.rust-lang.org/dist/2025-08-13/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-13: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 357.18 KB/s converted 2025-08-13 to 8e62bfd fetching https://static.rust-lang.org/dist/2025-08-14/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-14: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 123.86 KB/s converted 2025-08-14 to 3672a55 looking for regression commit between 2025-08-13 and 2025-08-14 fetching (via remote github) commits from max(8e62bfd, 2025-08-11) to 3672a55 ending github query because we found starting sha: 8e62bfd get_commits_between returning commits, len: 7 commit[0] 2025-08-12: Auto merge of rust-lang#144678 - jdonszelmann:no-mangle-extern, r=bjorn3 commit[1] 2025-08-12: Auto merge of rust-lang#145295 - Kobzol:unify-stages, r=jieyouxu commit[2] 2025-08-13: Auto merge of rust-lang#145093 - nikic:dead-on-return, r=nnethercote commit[3] 2025-08-13: Auto merge of rust-lang#145334 - Kobzol:rollup-fs5a133, r=Kobzol commit[4] 2025-08-13: Auto merge of rust-lang#144722 - ywxt:parallel-reproducibile, r=SparrowLii commit[5] 2025-08-13: Auto merge of rust-lang#145298 - nikic:llvm21-rc3, r=cuviper commit[6] 2025-08-13: Auto merge of rust-lang#145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez ``` Fixes rust-lang#140413. r? @petrochenkov
…est, r=petrochenkov Add test for parallel compiler reproducible build Adds a test for reproducible binaries when using parallel compiler. Confirmed with bisection and manual testing that rust-lang#144722 fixed rust-lang#140413, added test fails before commit (075ce31) from rust-lang#144722. ```rust ******************************************************************************** Regression in nightly-2025-08-14 ******************************************************************************** fetching https://static.rust-lang.org/dist/2025-08-13/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-13: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 357.18 KB/s converted 2025-08-13 to 8e62bfd fetching https://static.rust-lang.org/dist/2025-08-14/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-14: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 123.86 KB/s converted 2025-08-14 to 3672a55 looking for regression commit between 2025-08-13 and 2025-08-14 fetching (via remote github) commits from max(8e62bfd, 2025-08-11) to 3672a55 ending github query because we found starting sha: 8e62bfd get_commits_between returning commits, len: 7 commit[0] 2025-08-12: Auto merge of rust-lang#144678 - jdonszelmann:no-mangle-extern, r=bjorn3 commit[1] 2025-08-12: Auto merge of rust-lang#145295 - Kobzol:unify-stages, r=jieyouxu commit[2] 2025-08-13: Auto merge of rust-lang#145093 - nikic:dead-on-return, r=nnethercote commit[3] 2025-08-13: Auto merge of rust-lang#145334 - Kobzol:rollup-fs5a133, r=Kobzol commit[4] 2025-08-13: Auto merge of rust-lang#144722 - ywxt:parallel-reproducibile, r=SparrowLii commit[5] 2025-08-13: Auto merge of rust-lang#145298 - nikic:llvm21-rc3, r=cuviper commit[6] 2025-08-13: Auto merge of rust-lang#145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez ``` Fixes rust-lang#140413. r? @petrochenkov
…est, r=petrochenkov Add test for parallel compiler reproducible build Adds a test for reproducible binaries when using parallel compiler. Confirmed with bisection and manual testing that rust-lang#144722 fixed rust-lang#140413, added test fails before commit (075ce31) from rust-lang#144722. ```rust ******************************************************************************** Regression in nightly-2025-08-14 ******************************************************************************** fetching https://static.rust-lang.org/dist/2025-08-13/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-13: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 357.18 KB/s converted 2025-08-13 to 8e62bfd fetching https://static.rust-lang.org/dist/2025-08-14/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-14: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 123.86 KB/s converted 2025-08-14 to 3672a55 looking for regression commit between 2025-08-13 and 2025-08-14 fetching (via remote github) commits from max(8e62bfd, 2025-08-11) to 3672a55 ending github query because we found starting sha: 8e62bfd get_commits_between returning commits, len: 7 commit[0] 2025-08-12: Auto merge of rust-lang#144678 - jdonszelmann:no-mangle-extern, r=bjorn3 commit[1] 2025-08-12: Auto merge of rust-lang#145295 - Kobzol:unify-stages, r=jieyouxu commit[2] 2025-08-13: Auto merge of rust-lang#145093 - nikic:dead-on-return, r=nnethercote commit[3] 2025-08-13: Auto merge of rust-lang#145334 - Kobzol:rollup-fs5a133, r=Kobzol commit[4] 2025-08-13: Auto merge of rust-lang#144722 - ywxt:parallel-reproducibile, r=SparrowLii commit[5] 2025-08-13: Auto merge of rust-lang#145298 - nikic:llvm21-rc3, r=cuviper commit[6] 2025-08-13: Auto merge of rust-lang#145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez ``` Fixes rust-lang#140413. r? @petrochenkov
Rollup merge of #161353 - aerooneqq:static-muts-repr-build-test, r=petrochenkov Add test for parallel compiler reproducible build Adds a test for reproducible binaries when using parallel compiler. Confirmed with bisection and manual testing that #144722 fixed #140413, added test fails before commit (075ce31) from #144722. ```rust ******************************************************************************** Regression in nightly-2025-08-14 ******************************************************************************** fetching https://static.rust-lang.org/dist/2025-08-13/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-13: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 357.18 KB/s converted 2025-08-13 to 8e62bfd fetching https://static.rust-lang.org/dist/2025-08-14/channel-rust-nightly-git-commit-hash.txt nightly manifest 2025-08-14: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 123.86 KB/s converted 2025-08-14 to 3672a55 looking for regression commit between 2025-08-13 and 2025-08-14 fetching (via remote github) commits from max(8e62bfd, 2025-08-11) to 3672a55 ending github query because we found starting sha: 8e62bfd get_commits_between returning commits, len: 7 commit[0] 2025-08-12: Auto merge of #144678 - jdonszelmann:no-mangle-extern, r=bjorn3 commit[1] 2025-08-12: Auto merge of #145295 - Kobzol:unify-stages, r=jieyouxu commit[2] 2025-08-13: Auto merge of #145093 - nikic:dead-on-return, r=nnethercote commit[3] 2025-08-13: Auto merge of #145334 - Kobzol:rollup-fs5a133, r=Kobzol commit[4] 2025-08-13: Auto merge of #144722 - ywxt:parallel-reproducibile, r=SparrowLii commit[5] 2025-08-13: Auto merge of #145298 - nikic:llvm21-rc3, r=cuviper commit[6] 2025-08-13: Auto merge of #145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez ``` Fixes #140413. r? @petrochenkov
My post-stage-0-redesign bootstrap fixes aren't done yet, but I think that enough steps have been migrated to the new system that it makes sense to actually modify the directories on disk, and what gets printed when bootstrap runs, so that it actually corresponds to the new system. Before, the printed stages didn't always make sense.
This PR:
stageNdirectories in the build directory. It was not corresponding to the correct stages before; notice that I did not modifybootstrap/README.md, as it was essentially describing what happens after this PR (first commit). This means thatstageN-<foo>now actually corresponds to<foo>(e.g.rustcortools) that is stage N. Before in some cases it means that it was built with the stage N compiler. So for examplestage0-rustcbecamestage1-rustc.Builder::msgmethod. It's probably not the final stage, and some of the test steps might not be fully accurate yet, because I didn't fix test step numbering yet, but I think that it's a clear improvement from before, and now that everything uses the same method, we can easily make changes across the board, to ensure that it stays unified (second commit).r? @jieyouxu
try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux