Move `#[do_not_recommend]` to the `#[diagnostic]` namespace by weiznich · Pull Request #125326 · rust-lang/rust

weiznich · 2024-05-20T13:27:24Z

This commit moves the #[do_not_recommend] attribute to the #[diagnostic] namespace. It still requires
#![feature(do_not_recommend)] to work.

r? @compiler-errors

rustbot · 2024-05-20T13:27:34Z

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

weiznich · 2024-05-20T13:27:57Z

+                .get_attrs_by_path(impl_def_id, &[sym::diagnostic, sym::do_not_recommend])
+                .next()
+                .is_some()


It might be worth to introduce a .has_attrs() method for this?

Yeah, could you do that? has_attrs_by_path? (or has_attrs_with_path)?

compiler-errors · 2024-05-20T14:11:37Z

        self.ident().unwrap_or_else(Ident::empty).name
    }

+    pub fn path(&self) -> Vec<Symbol> {


Can you use a SmallVec<[Symbol; 1]>

compiler-errors · 2024-05-20T14:12:23Z

-                sym::target_feature => self.check_target_feature(hir_id, attr, span, target, attrs),
-                sym::thread_local => self.check_thread_local(attr, span, target),
-                sym::track_caller => {
+            match attr.path().as_slice() {


Maybe this should just be a nested match? 🤷

compiler-errors · 2024-05-20T14:12:32Z

@bors try @rust-timer queue

compiler-errors · 2024-05-20T14:12:38Z

Let's test it in this state tho

…ganostic_namespace, r=<try> Move `#[do_not_recommend]` to the `#[diagnostic]` namespace This commit moves the `#[do_not_recommend]` attribute to the `#[diagnostic]` namespace. It still requires `#![feature(do_not_recommend)]` to work. r? `@compiler-errors`

bors · 2024-05-20T14:13:44Z

⌛ Trying commit 7bdea9a with merge 347462c...

bors · 2024-05-20T15:51:51Z

☀️ Try build successful - checks-actions
Build commit: 347462c (347462cb8c1895dfeb2a789892c644bb2739dddd)

rust-timer · 2024-05-20T20:38:10Z

Finished benchmarking commit (347462c): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.4%, 0.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.1%, secondary 2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.7%, 2.2%]	2
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-2.0%	[-2.4%, -1.7%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-2.4%, 2.2%]	4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.145s -> 671.106s (-0.01%)
Artifact size: 316.05 MiB -> 316.07 MiB (0.01%)

This commit moves the `#[do_not_recommend]` attribute to the `#[diagnostic]` namespace. It still requires `#![feature(do_not_recommend)]` to work.

compiler-errors · 2024-05-21T17:57:14Z

@bors r+

bors · 2024-05-21T17:57:16Z

📌 Commit 2cff3e9 has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2024-05-22T04:14:12Z

⌛ Testing commit 2cff3e9 with merge b54dd08...

bors · 2024-05-22T06:18:22Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing b54dd08 to master...

rust-timer · 2024-05-22T07:32:58Z

Finished benchmarking commit (b54dd08): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.377s -> 672.666s (-0.11%)
Artifact size: 316.17 MiB -> 315.47 MiB (-0.22%)

rustbot assigned compiler-errors May 20, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 20, 2024

weiznich commented May 20, 2024

View reviewed changes

compiler-errors reviewed May 20, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 20, 2024

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 20, 2024

Move #[do_not_recommend] to the #[diagnostic] namespace

2cff3e9

This commit moves the `#[do_not_recommend]` attribute to the `#[diagnostic]` namespace. It still requires `#![feature(do_not_recommend)]` to work.

weiznich force-pushed the move/do_not_recommend_to_diganostic_namespace branch from 7bdea9a to 2cff3e9 Compare May 21, 2024 11:15

compiler-errors approved these changes May 21, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label May 22, 2024

bors merged commit b54dd08 into rust-lang:master May 22, 2024

rustbot added this to the 1.80.0 milestone May 22, 2024

This was referenced May 22, 2024

Implement a lint for implicit autoref of raw pointer dereference - take 2 #123239

Merged

Parse unsafe attributes #124214

Merged

compiler-errors mentioned this pull request Jul 11, 2024

Tracking issue for RFC 2397, "#[do_not_recommend]" #51992

Closed

3 tasks

Uh oh!

Conversation

weiznich commented May 20, 2024

Uh oh!

rustbot commented May 20, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented May 20, 2024

Uh oh!

This comment has been minimized.

compiler-errors commented May 20, 2024

Uh oh!

bors commented May 20, 2024

Uh oh!

bors commented May 20, 2024

Uh oh!

This comment has been minimized.

rust-timer commented May 20, 2024

Overall result: ❌ regressions - no action needed

Uh oh!

compiler-errors commented May 21, 2024

Uh oh!

bors commented May 21, 2024

Uh oh!

bors commented May 22, 2024

Uh oh!

bors commented May 22, 2024

Uh oh!

rust-timer commented May 22, 2024

Overall result: ✅ improvements - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants