Experiment: lint resetting mut bindings - #120095
Conversation
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
cd7b1fb to
6da4ec1
Compare
This comment has been minimized.
This comment has been minimized.
6da4ec1 to
ce7328b
Compare
|
@bors try |
Experiment: lint resetting `mut` bindings We would like to fix rust-lang#105647 in rust 2024. To evaluate the breakage, I wrote a lint that detects the cases where there would be a difference between now and rust 2024. I'd like to request a crater run with `dereferencing_mut_binding` set to `deny` to see how many crates would be affected.
|
☀️ Try build successful - checks-actions |
|
@craterbot run mode=check-only start=master#8424f8e8cdf07010967a57584fd647b30e930d4d end=try#047472f299946caf090d1b5608ae4bd9f0416256+rustflags=-Ddereferencing_mut_binding |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
|
craterbot
added
S-waiting-on-review
|
Looking through it, that's indeed ~400 failures due to the lint, and seems to be a decent number failing because they depend on a failing crate. I don't know if that's a lot all things considered. I expected worse |
Nadrieril
removed
the
S-waiting-on-review
Dylan-DPC
added
the
S-experimental
|
Superceded by #123076 |
dereferencing_mut_binding was added in Rust 1.79.0 as an experiment and removed in Rust 1.80.0. See: - https://doc.rust-lang.org/1.79.0/rustc/lints/listing/allowed-by-default.html#dereferencing-mut-binding - rust-lang/rust#120095 - rust-lang/rust#123076
dereferencing_mut_binding was added in Rust 1.79.0 as an experiment and removed in Rust 1.80.0. See: - https://doc.rust-lang.org/1.79.0/rustc/lints/listing/allowed-by-default.html#dereferencing-mut-binding - rust-lang/rust#120095 - rust-lang/rust#123076
dereferencing_mut_binding was added in Rust 1.79.0 as an experiment and removed in Rust 1.80.0. See: - https://doc.rust-lang.org/1.79.0/rustc/lints/listing/allowed-by-default.html#dereferencing-mut-binding - rust-lang/rust#120095 - rust-lang/rust#123076
8 participants
We would like to fix #105647 in rust 2024. To evaluate the breakage, I wrote a lint that detects the cases where there would be a difference between now and rust 2024.
I'd like to request a crater run with
dereferencing_mut_bindingset todenyto see how many crates would be affected.