Skip to content

Revert new naming - #10796

Merged
bors merged 3 commits into
rust-lang:masterfrom
lilyball:revert-new-naming
Dec 5, 2013
Merged

Revert new naming#10796
bors merged 3 commits into
rust-lang:masterfrom
lilyball:revert-new-naming

Conversation

@lilyball

@lilyball lilyball commented Dec 4, 2013

Copy link
Copy Markdown
Contributor

Rename the *::init() functions back to *::new(), since new is not
going to become a keyword.

@lilyball

lilyball commented Dec 4, 2013

Copy link
Copy Markdown
Contributor Author

Running the rustpkg tests with logging, I see

/private/var/folders/cs/l6c6g06x0974_0w5pdg8dps80000gn/T/qPOPMYz68t9RECSptemp_workspace/src/cdep-0.1/main.rs:2:0: 2:18 error: the `link_args` attribute is not portable across platforms, it is recommended to use `#[link(name = "foo")]` instead
/private/var/folders/cs/l6c6g06x0974_0w5pdg8dps80000gn/T/qPOPMYz68t9RECSptemp_workspace/src/cdep-0.1/main.rs:2 extern { fn f(); } 
                                                                                                               ^~~~~~~~~~~~~~~~~~

This error is completely unrelated to my PR. Why isn't this test failing every single PR?

@lilyball

lilyball commented Dec 4, 2013

Copy link
Copy Markdown
Contributor Author

@alexcrichton I had to force-push to update the Path::new commit to include the #[ignore]s that were added to the rustpkg tests in the reverted commit. Can you r+ again?

This reverts commit c54427d.

Leave the #[ignores] in that were added to rustpkg tests.

Conflicts:
	src/librustc/driver/driver.rs
	src/librustc/metadata/creader.rs
@lilyball

lilyball commented Dec 5, 2013

Copy link
Copy Markdown
Contributor Author

Updated due to bitrot. r? @alexcrichton

bors added a commit that referenced this pull request Dec 5, 2013
Rename the `*::init()` functions back to `*::new()`, since `new` is not
going to become a keyword.
@bors bors closed this Dec 5, 2013
@bors
bors merged commit b170571 into rust-lang:master Dec 5, 2013
chris-morgan added a commit to chris-morgan/rust-http that referenced this pull request Dec 5, 2013
@lilyball
lilyball deleted the revert-new-naming branch December 10, 2013 20:25
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
10796: ide: display static values in hover r=Veykril a=jhgg

Continuation from rust-lang#10785 - does the same thing, but for `static`'s as well.

Co-authored-by: Jake Heinz <jh@discordapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants