Rename std::util::ignore to std::util::drop - #10783
Merged
Merged
Conversation
Member
|
I think that we want to remove I don't think we ever had an official consensus, but now may be as good a time as any. Do others have opinions on moving this function to the prelude? (I would be in favor). |
Contributor
|
+1 |
Contributor
|
+1 on everything suggested by @alexcrichton |
It's a more fitting name for the most common use case of this function.
bors
added a commit
that referenced
this pull request
Dec 4, 2013
It's a more fitting name for the most common use case of this function.
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
10785: ide: show const value in hover r=jhgg a=jhgg fixes rust-lang#10783 I think my original attempt was incorrect, because it looks like `HirDisplay` is used in more places than just the hover. So, I've attempted it again in 312eafe, this time specifically just rendering the value in `hover::render` pictoral:  Co-authored-by: Jake Heinz <jh@discordapp.com> Co-authored-by: Jake <jh@discordapp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a more fitting name for the most common use case of this function.