Skip to content

rustdoc: use the same URL escape rules for fragments as for examples - #107655

Merged
bors merged 2 commits into
rust-lang:masterfrom
notriddle:notriddle/small-url-encode
Feb 9, 2023
Merged

rustdoc: use the same URL escape rules for fragments as for examples#107655
bors merged 2 commits into
rust-lang:masterfrom
notriddle:notriddle/small-url-encode

Conversation

@notriddle

@notriddle notriddle commented Feb 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Carries over improvements from #107284

@rustbot

rustbot commented Feb 4, 2023

Copy link
Copy Markdown
Collaborator

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 4, 2023
@notriddle
notriddle force-pushed the notriddle/small-url-encode branch from 160b630 to 5f98a7f Compare February 4, 2023 01:02
@rustbot

rustbot commented Feb 4, 2023

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@notriddle
notriddle force-pushed the notriddle/small-url-encode branch from f16b612 to fa6c3a2 Compare February 4, 2023 02:03
@notriddle

notriddle commented Feb 4, 2023

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 4, 2023
@bors

bors commented Feb 4, 2023

Copy link
Copy Markdown
Collaborator

⌛ Trying commit fa6c3a2 with merge 0ecc2de42b5ff940fd84861f29e99755cd966d44...

@bors

bors commented Feb 4, 2023

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 0ecc2de42b5ff940fd84861f29e99755cd966d44 (0ecc2de42b5ff940fd84861f29e99755cd966d44)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Feb 4, 2023

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0ecc2de42b5ff940fd84861f29e99755cd966d44): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.8% [0.7%, 0.9%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.1% [0.8%, 2.7%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) - - 0

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 4, 2023
@notriddle

notriddle commented Feb 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

None of the instruction count changes are doc benchmarks, so I don't think it's possible for them to be affected by this.

The doc bytes results, on the other hand, seem pretty good.

@notriddle notriddle assigned GuillaumeGomez and unassigned jsha Feb 9, 2023
@GuillaumeGomez

GuillaumeGomez commented Feb 9, 2023

Copy link
Copy Markdown
Member

It does look great, indeed. Thanks!

@bors r+ rollup

@bors

bors commented Feb 9, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit fa6c3a2 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request Feb 9, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2023
@bors
Auto merge of rust-lang#107853 - Dylan-DPC:rollup-macf1qo, r=Dylan-DPC
8996ea9 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#107648 (unused-lifetimes: don't warn about lifetimes originating from expanded code)
 - rust-lang#107655 (rustdoc: use the same URL escape rules for fragments as for examples)
 - rust-lang#107659 (test: snapshot for derive suggestion in diff files)
 - rust-lang#107786 (Implement some tweaks in the new solver)
 - rust-lang#107803 (Do not bring trait alias supertraits into scope)
 - rust-lang#107815 (Disqualify `auto trait` built-in impl in new solver if explicit `impl` exists)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 188dd72 into rust-lang:master Feb 9, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 9, 2023
@notriddle
notriddle deleted the notriddle/small-url-encode branch February 10, 2023 00:07
@jsha jsha mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

6 participants

@notriddle @rustbot @rust-timer @bors @GuillaumeGomez @jsha