Add JSON output to -Zdump-mono-stats#106274
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
rust-cloud-vms
Bot
force-pushed
the
dump-mono-stats
branch
from
December 29, 2022 22:36
75ce3b5 to
83aaf93
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
Bot
force-pushed
the
dump-mono-stats
branch
from
December 30, 2022 18:15
83aaf93 to
5bdea3b
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
Bot
force-pushed
the
dump-mono-stats
branch
from
December 30, 2022 19:24
5bdea3b to
8511d36
Compare
lqd
reviewed
Dec 30, 2022
lqd
left a comment
lqd
left a comment
Member
There was a problem hiding this comment.
Sweet, thank you! I left a couple comments below.
rust-cloud-vms
Bot
force-pushed
the
dump-mono-stats
branch
from
December 31, 2022 01:29
8511d36 to
e5d7f63
Compare
rustbot
added
T-bootstrap
Collaborator
|
The Miri subtree was changed cc @rust-lang/miri Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in HTML/CSS themes. A change occurred in the Ayu theme. cc @Cldfire Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
rust-cloud-vms
Bot
force-pushed
the
dump-mono-stats
branch
3 times, most recently
from
January 1, 2023 22:09
6478964 to
3c9bc35
Compare
lqd
reviewed
Jan 1, 2023
lqd
reviewed
Jan 1, 2023
bjorn3
reviewed
Jan 2, 2023
This allows analyzing the output programatically; for example, finding the item with the highest `total_estimate`. I also took the liberty of adding `untracked` tests to `rustc_session` and documentation to the unstable book for `dump-mono-items`.
rust-cloud-vms
Bot
force-pushed
the
dump-mono-stats
branch
from
January 2, 2023 23:05
3c9bc35 to
5c79624
Compare
Member
|
@bors r+ Thanks! |
Collaborator
bors
added
S-waiting-on-bors
wesleywiser
approved these changes
Jan 3, 2023
wesleywiser
left a comment
wesleywiser
left a comment
Member
There was a problem hiding this comment.
Thanks for following up on this @jyn514! ❤️
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 4, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#106200 (Suggest `impl Fn*` and `impl Future` in `-> _` return suggestions) - rust-lang#106274 (Add JSON output to -Zdump-mono-stats) - rust-lang#106292 (Add codegen test for `Box::new(uninit)` of big arrays) - rust-lang#106327 (Add tidy check for dbg) - rust-lang#106361 (Note maximum integer literal for `IntLiteralTooLarge`) - rust-lang#106396 (Allow passing a specific date to `bump-stage0`) - rust-lang#106436 (Enable doctests for rustc_query_impl) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #105481
r? @lqd cc @wesleywiser