Retain ParamEnv constness when running deferred cast checks#103683
Merged
bors merged 1 commit intoOct 28, 2022
Conversation
Collaborator
|
r? @estebank (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
fix-deferred-cast-checks-constness
branch
from
3a0b9b0 to
6000491
Compare
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
fix-deferred-cast-checks-constness
branch
from
6000491 to
a990b4c
Compare
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Member
Author
|
r? @oli-obk |
Contributor
|
@bors r+ p=1 (prioritizing, as it could make the beta cut and avoid a beta backport) |
Collaborator
bors
added
S-waiting-on-bors
Member
|
@bors p=10 |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (9565dfe): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 31, 2025
…dead Fix deferred cast checks using the wrong body for determining constness re-introduces rust-lang#103683 it was lost in rust-lang@4fec845 deferred checks possibly have more such issues, needs investigation. r? `@fee1-dead`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103677.