When I was reading through the test cases, these function names seemed to blur into one another. object_contains_any_symbol_substring, object_contains_all_symbol_substring, object_contains_any_symbol and object_contains_all_symbols are all long names sometimes with only a few characters difference in the middle. So I could see mistakes being missed.
However, I don't have a clear idea of what would be an improvement here (hence why I don't want to block this). Maybe some more namespacing or an iterator type? Idk.
Originally posted by @ChrisDenton in #143837 (review)
I.e. less symbol (hah) soup names for
|
Substring match |
Exact match |
| Match any |
object_contains_any_symbol_substring |
object_contains_any_symbol |
| Match all |
object_contains_all_symbol_substring |
object_contains_all_symbols |
Originally posted by @ChrisDenton in #143837 (review)
I.e. less symbol (hah) soup names for
object_contains_any_symbol_substringobject_contains_any_symbolobject_contains_all_symbol_substringobject_contains_all_symbols