x test tidy can be faster #141074

Activity

1. onur-ozkan

   added

   C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.

   T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

   on May 16, 2025
2. rustbot

   added

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on May 16, 2025
3. onur-ozkan

   removed

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on May 16, 2025
4. chenyukang commented on May 16, 2025

   

   chenyukang

   on May 16, 2025

   Member

   More actions

   absolutely worth to improve here, on my machine it cost 16 seconds now:

   ➜  rust git:(up-master) x test tidy       
   Building bootstrap
       Finished `dev` profile [unoptimized] target(s) in 0.25s
   Building stage0 tool tidy (aarch64-apple-darwin)
       Finished `release` profile [optimized + debuginfo] target(s) in 0.39s
   fmt check
   fmt info: No modified files detected for formatting.
   tidy check
   x.py completions check
   Build completed successfully in 0:00:16
5. onur-ozkan

   changed the title [-]`x test tidy` can be slightly faster[/-] [+]`x test tidy` can be faster[/+] on May 16, 2025
6. the8472 commented on Jun 26, 2025

   

   the8472

   on Jun 26, 2025

   Last edited by the8472

   Member

   More actions

   One problem is that x is supposed to obey parallelism limits (-j) and both tidy and rustfmt individually respect that but via explicitly passed limits, not via jobserver support. So executing them in parallel would mean they'd not cooperatively limit themselves.
7. JonathanBrouwer

   added 2 commits that reference this issue on Oct 8, 2026

   Rollup merge of rust-lang#161201 - the8472:tidy-opts, r=Kobzol

   ...

   79d2894

   Rollup merge of rust-lang#161201 - the8472:tidy-opts, r=Kobzol

   ...

   a0ae9d9
8. rust-bors

   closed this as completedin a0ae9d9on Oct 8, 2026
9. rust-bors

   added a commit that references this issue on Oct 8, 2026

   Unrolled build for #161201 in rollup 164005

   ...

   a699e3c
10. programskillforverification

    added a commit that references this issue on Oct 9, 2026

    Rollup merge of #161201 - the8472:tidy-opts, r=Kobzol

    ...

    b479a4c