-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Fix internal Wtf8Buf::extend_from_slice check #126977
Copy link
Copy link
Closed
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.O-windowsOperating system: WindowsOperating system: WindowsT-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.
Description
Metadata
Metadata
Assignees
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.O-windowsOperating system: WindowsOperating system: WindowsT-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Reviewing PR #126885 had some oversight regarding valid utf8 checks. This was graciously brought to our (meaning myself and @workingjubilee) attention by @yhx-12243 in this comment. Fix should really just be changing line 483 of wtf8.rs to setting
self.is_known_utf8tofalse, unless we decide there may be some merit to iterating again through theotherbuffer.