Skip to content

Rustup to latest rustc master#4328

Merged
bors merged 2 commits into
rust-lang:masterfrom
phansch:rustup
Aug 3, 2019
Merged

Rustup to latest rustc master#4328
bors merged 2 commits into
rust-lang:masterfrom
phansch:rustup

Conversation

@phansch

@phansch phansch commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

Broken due to:

* rust-lang/rust#63180 (`Existential` -> `OpaqueTy`)
* rust-lang/rust#63121 (New fields for `FormatSpec`)
@phansch

phansch commented Aug 3, 2019

Copy link
Copy Markdown
Contributor Author

@bors r+ doesn't seem very controversial, so I'm going to r+ myself

@bors

bors commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

📌 Commit d61df4f has been approved by phansch

@bors

bors commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit d61df4f with merge 5f57b68...

bors added a commit that referenced this pull request Aug 3, 2019
Rustup to latest rustc master

Broken due to:

* rust-lang/rust#63180 (`Existential` -> `OpaqueTy`)
* rust-lang/rust#63121 (New fields for `FormatSpec`)
@bors

bors commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - status-appveyor

@ghost

ghost commented Aug 3, 2019

Copy link
Copy Markdown

In appveyor.yml, Try replacing

    - rustup component add rustfmt --toolchain nightly || echo "rustfmt nightly is unavailable"

with

    - rustup component add rustfmt --toolchain nightly & exit 0

It looks like that is the correct way to ignore if a command fails.
https://help.appveyor.com/discussions/questions/752-how-to-ignore-exit-codes-of-a-cmd

The format test should be able to handle rustfmt being missing.

@phansch

phansch commented Aug 3, 2019

Copy link
Copy Markdown
Contributor Author

Thanks, let's see if that works!

@bors r+

@bors

bors commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

📌 Commit ff59f4a has been approved by phansch

@bors

bors commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit ff59f4a with merge a492dfc...

bors added a commit that referenced this pull request Aug 3, 2019
Rustup to latest rustc master

Broken due to:

* rust-lang/rust#63180 (`Existential` -> `OpaqueTy`)
* rust-lang/rust#63121 (New fields for `FormatSpec`)
@phansch

phansch commented Aug 3, 2019

Copy link
Copy Markdown
Contributor Author

@bors retry (forgot changelog)

@bors

bors commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit ff59f4a with merge 6b88a62...

bors added a commit that referenced this pull request Aug 3, 2019
Rustup to latest rustc master

Broken due to:

changelog: none

* rust-lang/rust#63180 (`Existential` -> `OpaqueTy`)
* rust-lang/rust#63121 (New fields for `FormatSpec`)
@bors

bors commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-travis

@phansch

phansch commented Aug 3, 2019

Copy link
Copy Markdown
Contributor Author

@bors retry (spurious)

@bors

bors commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit ff59f4a with merge a24c704...

bors added a commit that referenced this pull request Aug 3, 2019
Rustup to latest rustc master

Broken due to:

* rust-lang/rust#63180 (`Existential` -> `OpaqueTy`)
* rust-lang/rust#63121 (New fields for `FormatSpec`)

changelog: none
@bors

bors commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing a24c704 to master...

@bors bors merged commit ff59f4a into rust-lang:master Aug 3, 2019
@phansch phansch deleted the rustup branch August 3, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants