fix(len_zero): don't eagerly call GenericArgs::type_at#15660
Merged
Conversation
Results in an ICE if the output type has no generic type params
rustbot
added
the
S-waiting-on-review
y21
approved these changes
Sep 11, 2025
rustbot
removed
the
S-waiting-on-review
Member
|
I believe this fix wouldn't make it into the same release cycle as the commit that introduced it, and the repro seems not too uncommon for people to hit, so let's also: @rustbot label +beta-nominated |
rustbot
added
the
beta-nominated
Member
|
Ping @flip1995 Edit: the bug report was for 0.91, so on the contrary we may have time. |
flip1995
added
beta-accepted
flip1995
removed
the
beta-accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15657
changelog: [
len_zero]: fix ICE whenfn lenhas a return type without generic type paramsr? @y21