ui_test annotation cleanup#14232
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
flip1995
approved these changes
Feb 16, 2025
flip1995
left a comment
flip1995
left a comment
Member
There was a problem hiding this comment.
Thanks for taking another look and fixing up those files! One ICE test needs its fixed file updated or a no-rustfix annotation. With that, feel free to merge.
Alexendoo
force-pushed
the
test-annotation-cleanup
branch
from
e59ed29 to
d03ae8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up some changes from #11421
I searched for any
.stderrfiles where the number of errors changed and reverted + manually added the annotations for themAlso fixes
tests/ui/asm_syntax_not_x86.rsr? @flip1995
changelog: none