Skip to content

Add config flag for reborrows in explicit_iter_loop#11418

Merged
bors merged 2 commits into
rust-lang:masterfrom
Benjscho:explicit_iter_loop_config
Aug 31, 2023
Merged

Add config flag for reborrows in explicit_iter_loop#11418
bors merged 2 commits into
rust-lang:masterfrom
Benjscho:explicit_iter_loop_config

Conversation

@Benjscho

Copy link
Copy Markdown
Contributor

This PR adds a config flag for enforcing explicit into iter lint for reborrowed values. The config flag, enforce_iter_loop_reborrow, can be added to clippy.toml files to enable the linting behaviour. By default the reborrow lint is disabled.

fixes: #11074

changelog: [explicit_iter_loop]: add config flag enforce_iter_loop_reborrow to disable reborrow linting by default

This commit adds a config flag for enforcing explicit into iter lint
for reborrowed values. The config flag, enforce_iter_loop_reborrow, can be
added to clippy.toml files to enable the linting behaviour. By default
the lint is not enabled.
@rustbot

rustbot commented Aug 28, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 28, 2023
@llogiq

llogiq commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

Thank you!

@bors r+

@bors

bors commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

📌 Commit be55a96 has been approved by llogiq

It is now in the queue for this repository.

@bors

bors commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit be55a96 with merge 21ab218...

bors added a commit that referenced this pull request Aug 30, 2023
Add config flag for reborrows in explicit_iter_loop

This PR adds a config flag for enforcing explicit into iter lint for reborrowed values. The config flag, `enforce_iter_loop_reborrow`, can be added to clippy.toml files to enable the linting behaviour. By default the reborrow lint is disabled.

fixes: #11074

changelog: [`explicit_iter_loop`]: add config flag `enforce_iter_loop_reborrow` to disable reborrow linting by default
@bors

bors commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-action_test

@Benjscho

Copy link
Copy Markdown
Contributor Author

Updated metadata for the failed test!

@llogiq

llogiq commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

Ok, let's retry.

@bors r+

@bors

bors commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

📌 Commit 55bd0fe has been approved by llogiq

It is now in the queue for this repository.

@bors

bors commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit 55bd0fe with merge c50d86f...

@bors

bors commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing c50d86f to master...

1 similar comment
@bors

bors commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing c50d86f to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

explicit_iter_loop: x.iter_mut() vs &mut *x

4 participants