Skip to content

[panic_in_result_fn] remove todo!, unimplemented!, unreachable!#11123

Merged
bors merged 1 commit into
rust-lang:masterfrom
panosfol:master
Jul 13, 2023
Merged

[panic_in_result_fn] remove todo!, unimplemented!, unreachable!#11123
bors merged 1 commit into
rust-lang:masterfrom
panosfol:master

Conversation

@panosfol

@panosfol panosfol commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

This commit fixes #11025 by removing checks for todo!, unimplemented! and unreachable!.

changelog: [panic_in_result_fn] remove todo!, unimplemented!, unreachable!

@rustbot

rustbot commented Jul 7, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 7, 2023
giraffate
giraffate reviewed Jul 11, 2023
View reviewed changes

@giraffate giraffate left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave these tests as they are without removing them?

@panosfol
[panic_in_result_fn] remove todo!, unimplemented!, unreachable!
c49c177 
This commit fixes rust-lang#11025 by removing checks for `todo!`,
`unimplemented!` and `unreachable!`.

Signed-off-by: Panagiotis Foliadis <pfoliadis@hotmail.com>
@panosfol

panosfol commented Jul 12, 2023

Copy link
Copy Markdown
Contributor Author

Can we leave these tests as they are without removing them?

@giraffate I restored the tests, but may I ask why do we keep them unchanged?

@giraffate

giraffate commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

I restored the tests, but may I ask why do we keep them unchanged?

I want to check that this lint doesn't warn the tests by this change.

@giraffate

giraffate commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

@bors r+

Thanks!

@bors

bors commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

📌 Commit c49c177 has been approved by giraffate

It is now in the queue for this repository.

@bors

bors commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit c49c177 with merge df92b52...

@bors

bors commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing df92b52 to master...

@bors bors merged commit df92b52 into rust-lang:master Jul 13, 2023
This was referenced Oct 5, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@giraffate giraffate giraffate left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@giraffate giraffate

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

panic_in_result_fn shouldn't fire on todo!()/unimplemented!()/unreachable!()

4 participants

@panosfol @rustbot @giraffate @bors