[type_repetition_in_bounds]: Don't lint on derived code#10894
Merged
Conversation
Collaborator
|
r? @xFrednet (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Centri3
commented
Jun 5, 2023
Member
In this new commit, it's about ~15% faster. Not really worth it only for performance, but the clean code really makes this worth it imo (and making it easier for future contributions). |
Contributor
|
Sounds like you're back in action. Ain't no rest for the wicket, right? ^^ I'll give this a final review in the next couple of days. Thank you for the reviewing effort @blyxyas |
xFrednet
reviewed
Jun 11, 2023
xFrednet
left a comment
xFrednet
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just one tiny question before the merge :)
xFrednet
approved these changes
Jun 12, 2023
Contributor
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10504.
changelog: [
type_repetition_in_bounds]: Don't lint on derived code